Re: [PATCH mptcp-next v10 00/12] BPF path manager, part 5

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 06/03/2025 12:01, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v10:
>  - drop pm->init in mptcp_pm_validate, move mptcp_pm_validate into a new
>    patch.
>  - remove tlb, use ctl instead in proc_pm_type.
>  - use "strncmp() == 0" instead of "!strncmp()".
>  - set pm_type __MPTCP_PM_TYPE_NR for other names.
>  - add WARN_ON_ONCE in mptcp_pm_unregister.
>  - drop mptcp_userspace_pm_init.
>  - rename "struct mptcp_pm_ops *pm" to "struct mptcp_pm_ops *pm_ops".
>  - drop pm_ops NULL check in mptcp_pm_release.
>  - add struct_group for struct mptcp_pm_data.
>  - move selftests into userspace_pm.sh.

Thank you for the new version and the changelog!

I have some comments, almost there. If you already have patches adding
the remaining function pointers to the new mptcp_pm_ops, feel free to
add them in the next version.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.