Re: [PATCH mptcp-next v10 10/12] mptcp: sysctl: map pm_type to path_manager

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 06/03/2025 12:01, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This patch adds a new proc_handler "proc_pm_type" for "pm_type" to
> map old path manager sysctl "pm_type" to the newly added "path_manager".
> 
> 	path_manager		   pm_type
> 
> 	MPTCP_PM_TYPE_KERNEL    -> "kernel"
> 	MPTCP_PM_TYPE_USERSPACE -> "userspace"
> 
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> ---
>  net/mptcp/ctrl.c | 25 ++++++++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c
> index 6a35e6bb0a63..357083977ba5 100644
> --- a/net/mptcp/ctrl.c
> +++ b/net/mptcp/ctrl.c
> @@ -228,6 +228,29 @@ static int proc_path_manager(const struct ctl_table *ctl, int write,
>  	return ret;
>  }
>  
> +static int proc_pm_type(const struct ctl_table *ctl, int write,
> +			void *buffer, size_t *lenp, loff_t *ppos)
> +{
> +	struct mptcp_pernet *pernet = container_of(ctl->data,
> +						   struct mptcp_pernet,
> +						   pm_type);
> +	int ret;
> +
> +	ret = proc_dou8vec_minmax(ctl, write, buffer, lenp, ppos);
> +	if (write && ret == 0) {
> +		u8 pm_type = READ_ONCE(*(u8 *)ctl->data);
> +		char *pm_name = "unknown";

Small detail: thanks to proc_dou8vec_minmax, pm_name cannot be
"unknown": it should only be 0 or 1. Then you can either not assign it,
or assign it to an empty string "just in case"?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.