All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: "Guido Günther" <agx@sigxcpu.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	kernel@puri.sm
Subject: Re: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press
Date: Mon, 10 Jun 2024 10:17:55 +0000	[thread overview]
Message-ID: <6cc32fceb4d74833e045e0acbc51515b5ef3065b.camel@posteo.de> (raw)
In-Reply-To: <fa416916049e85ca159805e8602fa8361d5e6d83.1716202515.git.agx@sigxcpu.org>

Am Montag, dem 20.05.2024 um 12:57 +0200 schrieb Guido Günther:
> The only key that should wake up the phone is power button press.
> This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Reviewed-by: Martin Kepplinger <martink@posteo.de>

thank you,

                              martin

> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ffb5fe61630d..1b39514d5c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -45,7 +45,6 @@ key-vol-down {
>                         gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEDOWN>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>  
>                 key-vol-up {
> @@ -53,7 +52,6 @@ key-vol-up {
>                         gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEUP>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>         };
>  


WARNING: multiple messages have this Message-ID (diff)
From: Martin Kepplinger <martink@posteo.de>
To: "Guido Günther" <agx@sigxcpu.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
	kernel@puri.sm
Subject: Re: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press
Date: Mon, 10 Jun 2024 10:17:55 +0000	[thread overview]
Message-ID: <6cc32fceb4d74833e045e0acbc51515b5ef3065b.camel@posteo.de> (raw)
In-Reply-To: <fa416916049e85ca159805e8602fa8361d5e6d83.1716202515.git.agx@sigxcpu.org>

Am Montag, dem 20.05.2024 um 12:57 +0200 schrieb Guido Günther:
> The only key that should wake up the phone is power button press.
> This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Reviewed-by: Martin Kepplinger <martink@posteo.de>

thank you,

                              martin

> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ffb5fe61630d..1b39514d5c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -45,7 +45,6 @@ key-vol-down {
>                         gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEDOWN>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>  
>                 key-vol-up {
> @@ -53,7 +52,6 @@ key-vol-up {
>                         gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEUP>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>         };
>  

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-06-10 10:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20 10:57 [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press Guido Günther
2024-05-20 10:57 ` Guido Günther
2024-06-10 10:17 ` Martin Kepplinger [this message]
2024-06-10 10:17   ` Martin Kepplinger
2024-06-15  8:29 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cc32fceb4d74833e045e0acbc51515b5ef3065b.camel@posteo.de \
    --to=martink@posteo.de \
    --cc=agx@sigxcpu.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.