From: Miaoqian Lin <linmq006@gmail.com>
To: Miles Chen <miles.chen@mediatek.com>
Cc: bhelgaas@google.com, jianjun.wang@mediatek.com, kw@linux.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com,
matthias.bgg@gmail.com, maz@kernel.org, robh@kernel.org,
ryder.lee@mediatek.com
Subject: Re: [PATCH] PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains
Date: Mon, 30 May 2022 14:54:03 +0800 [thread overview]
Message-ID: <6cf820cf-a2e7-c93e-3c00-08bc366f2eb2@gmail.com> (raw)
In-Reply-To: <20220530021923.31601-1-miles.chen@mediatek.com>
Hi, Miles
On 2022/5/30 10:19, Miles Chen wrote:
> Hi Miaoqian,
>
>>>> &intx_domain_ops, pcie);
>>>> if (!pcie->intx_domain) {
>>>> dev_err(dev, "failed to create INTx IRQ domain\n");
>>>> + of_node_put(intc_node);
>>>> return -ENODEV;
>>>> }
>>> Thanks for doing this.
>>>
>>> I checked mtk_pcie_init_irq_domains() and there are multiple exit paths like
>>> err_msi_domain and err_msi_bottom_domain and the normal path which also
>>> need of_node_put(intc_node).
>> Thanks for your reply,
>>
>> I didn't add of_node_put() in other paths because I am not sure if the reference passed through irq_domain_add_linear(), since intc_node is passed to irq_domain_add_linear().
>>
>> __irq_domain_add() keeps &node->fwnode in the irq_domain structure.
>>
>> and use fwnode_handle_get() to get the reference of fwnode, but I still uncertain.
>>
>> If the reference don't needed anymore after irq_domain_add_linear(),
>>
>> your suggestion looks fine, and I will submit v2.
>
> Thanks for your reply, I think we can do similar things like
> rtl8365mb_irq_setup() in drivers/net/dsa/realtek/rtl8365mb.c
I checked rtl8365mb_irq_setup(), it calls of_node_put() by goto statement for error paths.
and calls of_node_put() before return 0 in normal path. I didn't see the same problem.
> Thanks,
> Miles
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Miaoqian Lin <linmq006@gmail.com>
To: Miles Chen <miles.chen@mediatek.com>
Cc: bhelgaas@google.com, jianjun.wang@mediatek.com, kw@linux.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com,
matthias.bgg@gmail.com, maz@kernel.org, robh@kernel.org,
ryder.lee@mediatek.com
Subject: Re: [PATCH] PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains
Date: Mon, 30 May 2022 14:54:03 +0800 [thread overview]
Message-ID: <6cf820cf-a2e7-c93e-3c00-08bc366f2eb2@gmail.com> (raw)
In-Reply-To: <20220530021923.31601-1-miles.chen@mediatek.com>
Hi, Miles
On 2022/5/30 10:19, Miles Chen wrote:
> Hi Miaoqian,
>
>>>> &intx_domain_ops, pcie);
>>>> if (!pcie->intx_domain) {
>>>> dev_err(dev, "failed to create INTx IRQ domain\n");
>>>> + of_node_put(intc_node);
>>>> return -ENODEV;
>>>> }
>>> Thanks for doing this.
>>>
>>> I checked mtk_pcie_init_irq_domains() and there are multiple exit paths like
>>> err_msi_domain and err_msi_bottom_domain and the normal path which also
>>> need of_node_put(intc_node).
>> Thanks for your reply,
>>
>> I didn't add of_node_put() in other paths because I am not sure if the reference passed through irq_domain_add_linear(), since intc_node is passed to irq_domain_add_linear().
>>
>> __irq_domain_add() keeps &node->fwnode in the irq_domain structure.
>>
>> and use fwnode_handle_get() to get the reference of fwnode, but I still uncertain.
>>
>> If the reference don't needed anymore after irq_domain_add_linear(),
>>
>> your suggestion looks fine, and I will submit v2.
>
> Thanks for your reply, I think we can do similar things like
> rtl8365mb_irq_setup() in drivers/net/dsa/realtek/rtl8365mb.c
I checked rtl8365mb_irq_setup(), it calls of_node_put() by goto statement for error paths.
and calls of_node_put() before return 0 in normal path. I didn't see the same problem.
> Thanks,
> Miles
WARNING: multiple messages have this Message-ID (diff)
From: Miaoqian Lin <linmq006@gmail.com>
To: Miles Chen <miles.chen@mediatek.com>
Cc: bhelgaas@google.com, jianjun.wang@mediatek.com, kw@linux.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com,
matthias.bgg@gmail.com, maz@kernel.org, robh@kernel.org,
ryder.lee@mediatek.com
Subject: Re: [PATCH] PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains
Date: Mon, 30 May 2022 14:54:03 +0800 [thread overview]
Message-ID: <6cf820cf-a2e7-c93e-3c00-08bc366f2eb2@gmail.com> (raw)
In-Reply-To: <20220530021923.31601-1-miles.chen@mediatek.com>
Hi, Miles
On 2022/5/30 10:19, Miles Chen wrote:
> Hi Miaoqian,
>
>>>> &intx_domain_ops, pcie);
>>>> if (!pcie->intx_domain) {
>>>> dev_err(dev, "failed to create INTx IRQ domain\n");
>>>> + of_node_put(intc_node);
>>>> return -ENODEV;
>>>> }
>>> Thanks for doing this.
>>>
>>> I checked mtk_pcie_init_irq_domains() and there are multiple exit paths like
>>> err_msi_domain and err_msi_bottom_domain and the normal path which also
>>> need of_node_put(intc_node).
>> Thanks for your reply,
>>
>> I didn't add of_node_put() in other paths because I am not sure if the reference passed through irq_domain_add_linear(), since intc_node is passed to irq_domain_add_linear().
>>
>> __irq_domain_add() keeps &node->fwnode in the irq_domain structure.
>>
>> and use fwnode_handle_get() to get the reference of fwnode, but I still uncertain.
>>
>> If the reference don't needed anymore after irq_domain_add_linear(),
>>
>> your suggestion looks fine, and I will submit v2.
>
> Thanks for your reply, I think we can do similar things like
> rtl8365mb_irq_setup() in drivers/net/dsa/realtek/rtl8365mb.c
I checked rtl8365mb_irq_setup(), it calls of_node_put() by goto statement for error paths.
and calls of_node_put() before return 0 in normal path. I didn't see the same problem.
> Thanks,
> Miles
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-30 6:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 11:02 [PATCH] PCI: mediatek-gen3: Fix refcount leak in mtk_pcie_init_irq_domains Miaoqian Lin
2022-05-26 11:02 ` Miaoqian Lin
2022-05-26 11:02 ` Miaoqian Lin
2022-05-26 18:44 ` Rob Herring
2022-05-26 18:44 ` Rob Herring
2022-05-26 18:44 ` Rob Herring
2022-05-27 8:45 ` Miles Chen
2022-05-27 8:45 ` Miles Chen
2022-05-27 8:45 ` Miles Chen
2022-05-28 9:19 ` Miaoqian Lin
2022-05-28 9:19 ` Miaoqian Lin
2022-05-28 9:19 ` Miaoqian Lin
2022-05-30 2:19 ` Miles Chen
2022-05-30 2:19 ` Miles Chen
2022-05-30 2:19 ` Miles Chen
2022-05-30 6:54 ` Miaoqian Lin [this message]
2022-05-30 6:54 ` Miaoqian Lin
2022-05-30 6:54 ` Miaoqian Lin
2022-05-30 7:35 ` Miles Chen
2022-05-30 7:35 ` Miles Chen
2022-05-30 7:35 ` Miles Chen
2022-05-31 14:01 ` Miaoqian Lin
2022-05-31 14:01 ` Miaoqian Lin
2022-05-31 14:01 ` Miaoqian Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cf820cf-a2e7-c93e-3c00-08bc366f2eb2@gmail.com \
--to=linmq006@gmail.com \
--cc=bhelgaas@google.com \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=miles.chen@mediatek.com \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.