From: Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
To: Dave Hansen <dave.hansen@intel.com>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<x86@kernel.org>, <hpa@zytor.com>, <tony.luck@intel.com>,
<seanjc@google.com>, <fenghua.yu@intel.com>,
<thomas.lendacky@amd.com>, <kyung.min.park@intel.com>,
<kim.phillips@amd.com>, <mgross@linux.intel.com>,
<peterz@infradead.org>, <krish.sadhukhan@oracle.com>,
<liam.merwick@oracle.com>, <mlevitsk@redhat.com>,
<reinette.chatre@intel.com>, <babu.moger@amd.com>,
<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <TimGuo-oc@zhaoxin.com>, <CooperYan@zhaoxin.com>,
<QiyuanWang@zhaoxin.com>, <HerryYang@zhaoxin.com>,
<CobeChen@zhaoxin.com>, <SilviaZhao@zhaoxin.com>
Subject: Re: [PATCH v1 2/3] x86/cpu: Set low performance CRC32C flag on some Zhaoxin CPUs
Date: Mon, 11 Jan 2021 18:54:12 +0800 [thread overview]
Message-ID: <6d2f1d21-635d-d359-ee2c-ce0665f519d7@zhaoxin.com> (raw)
In-Reply-To: <607494aa-674a-fe93-50f6-2c45f385f7e9@intel.com>
On 07/01/2021 23:52, Dave Hansen wrote:
> On 1/6/21 10:19 PM, Tony W Wang-oc wrote:
>> + /*
>> + * These CPUs declare support SSE4.2 instruction sets but
>> + * having low performance CRC32C instruction implementation.
>> + */
>> + if (c->x86 == 0x6 || (c->x86 == 0x7 && c->x86_model <= 0x3b))
>> + set_cpu_cap(c, X86_FEATURE_CRC32C);
>> }
>
> On the Intel side, we've tried to move away from open-coded model
> numbers. Say another CPU is released that has a microarchitecture close
> to 0x3b, but has a model of 0x3c. It's a *LOT* easier to grep for
> INTEL_FAM6_NEHALEM (or whatever) than 0x3c. See:
>
> arch/x86/include/asm/intel-family.h
>
> for examples.
> .
>
Got it, thanks for your suggestion.
Sincerely
Tonyw
next prev parent reply other threads:[~2021-01-11 10:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 6:19 [PATCH v1 0/3] crypto: x86/crc32c-intel - Exclude some Zhaoxin CPUs Tony W Wang-oc
2021-01-07 6:19 ` [PATCH v1 1/3] x86/cpufeatures: Add low performance CRC32C instruction CPU feature Tony W Wang-oc
2021-01-07 6:37 ` Borislav Petkov
2021-01-11 10:51 ` Tony W Wang-oc
2021-01-11 11:03 ` Borislav Petkov
2021-01-15 1:43 ` Tony W Wang-oc
2021-01-11 15:20 ` hpa
2021-01-07 6:19 ` [PATCH v1 2/3] x86/cpu: Set low performance CRC32C flag on some Zhaoxin CPUs Tony W Wang-oc
2021-01-07 15:52 ` Dave Hansen
2021-01-11 10:54 ` Tony W Wang-oc [this message]
2021-01-07 6:19 ` [PATCH v1 3/3] crypto: x86/crc32c-intel Exclude low performance CRC32C instruction CPUs Tony W Wang-oc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d2f1d21-635d-d359-ee2c-ce0665f519d7@zhaoxin.com \
--to=tonywwang-oc@zhaoxin.com \
--cc=CobeChen@zhaoxin.com \
--cc=CooperYan@zhaoxin.com \
--cc=HerryYang@zhaoxin.com \
--cc=QiyuanWang@zhaoxin.com \
--cc=SilviaZhao@zhaoxin.com \
--cc=TimGuo-oc@zhaoxin.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=kim.phillips@amd.com \
--cc=krish.sadhukhan@oracle.com \
--cc=kyung.min.park@intel.com \
--cc=liam.merwick@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.