From: <Conor.Dooley@microchip.com>
To: <panqinglin2020@iscas.ac.cn>, <Conor.Dooley@microchip.com>
Cc: <jszhang@kernel.org>, <palmer@dabbelt.com>,
<linux-riscv@lists.infradead.org>, <jeff@riscv.org>,
<xuyinan@ict.ac.cn>
Subject: Re: [PATCH v2 1/4] riscv, mm: detect svnapot cpu support at runtime
Date: Sat, 16 Jul 2022 13:51:51 +0000 [thread overview]
Message-ID: <6e37baa9-a1b5-47f3-e61f-3bc40a7c29c3@microchip.com> (raw)
In-Reply-To: <6bb47d92.12c94.182073e1feb.Coremail.panqinglin2020@iscas.ac.cn>
On 16/07/2022 14:41, 潘庆霖 wrote:
> > On 16/07/2022 13:35, Jisheng Zhang wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > >
> > > On Sat, Jul 16, 2022 at 04:56:45PM +0800, panqinglin2020@iscas.ac.cn wrote:
> > >> From: Qinglin Pan <panqinglin2020@iscas.ac.cn>
> > >>
> > >> This patch add two erratas to enable/disable svnapot support, patches code
> > >> dynamicly when "svnapot" is in the "riscv,isa" field of fdt and SVNAPOT compile
> > >> option is set. It will influence the behavior of has_svnapot function and
> > >> pte_pfn function. All code dependent on svnapot should make sure that has_svnapot
> > >> return true firstly.
> > >>
> > >> Also, this patch modifies PTE definition for Svnapot, and creates some functions in
> > >> pgtable.h to mark a PTE as napot and check if it is a Svnapot PTE.
> > >> Until now, only 64KB napot size is supported in draft spec, so some macros
> > >> has only 64KB version.
> > >>
> > >> Yours,
> > >> Qinglin
> > >
> > > hmm, this "Yours ..." should be removed in commit msg
> >
> > And while they're at it, they can drop the "This patch".
> >
> > I might've said this on a v1 (I know I said it on someone's
> > v1 recently) that having "Also, this patch" makes it sound
> > like this should actually be two patches and not one.
> >
> > Thanks,
> > Conor.
> >
^ might want to fix your mail client to not do that too! :)
Thanks,
Conor
>
> Thanks for the hints, will do in a newer version patch.
>
>
> Thanks,
> Qinglin.</panqinglin2020@iscas.ac.cn>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-07-16 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 8:56 [PATCH v2 0/4] riscv: mm: add Svnapot support panqinglin2020
2022-07-16 8:56 ` [PATCH v2 1/4] riscv, mm: detect svnapot cpu support at runtime panqinglin2020
2022-07-16 12:35 ` Jisheng Zhang
2022-07-16 13:33 ` Conor.Dooley
2022-07-16 13:41 ` 潘庆霖
2022-07-16 13:51 ` Conor.Dooley [this message]
2022-07-16 13:42 ` 潘庆霖
2022-07-16 8:56 ` [PATCH v2 2/4] mm: support Svnapot in physical page linear-mapping panqinglin2020
2022-07-16 8:56 ` [PATCH v2 3/4] mm: support Svnapot in hugetlb page panqinglin2020
2022-07-16 8:56 ` [PATCH v2 4/4] mm: support Svnapot in huge vmap panqinglin2020
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e37baa9-a1b5-47f3-e61f-3bc40a7c29c3@microchip.com \
--to=conor.dooley@microchip.com \
--cc=jeff@riscv.org \
--cc=jszhang@kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=panqinglin2020@iscas.ac.cn \
--cc=xuyinan@ict.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.