From: Luck, Tony <tony.luck@intel.com>
To: lkp@lists.01.org
Subject: Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression
Date: Mon, 24 Aug 2020 15:38:53 +0000 [thread overview]
Message-ID: <6e996ad05e434a6fb13f069ee72b876b@intel.com> (raw)
In-Reply-To: <20200824153300.GA56944@shbuild999.sh.intel.com>
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
> Yes, that's what we suspected. And I just did another try to force the
> percpu mce structure aligned. And the regression seems to be gone (reduced
> from 14.1% to 2%), which further proved it.
I wonder whether it would be useful for bisection of performance issues
for you to change the global definition of DEFINE_PER_CPU() to make
all per CPU definitions aligned. Just like you switch compiler flags to make
all functions aligned.
-Tony
WARNING: multiple messages have this Message-ID (diff)
From: "Luck, Tony" <tony.luck@intel.com>
To: "Tang, Feng" <feng.tang@intel.com>, Borislav Petkov <bp@suse.de>
Cc: "Chen, Rong A" <rong.a.chen@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"lkp@lists.01.org" <lkp@lists.01.org>,
"Mel Gorman" <mgorman@suse.com>
Subject: RE: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression
Date: Mon, 24 Aug 2020 15:38:53 +0000 [thread overview]
Message-ID: <6e996ad05e434a6fb13f069ee72b876b@intel.com> (raw)
In-Reply-To: <20200824153300.GA56944@shbuild999.sh.intel.com>
> Yes, that's what we suspected. And I just did another try to force the
> percpu mce structure aligned. And the regression seems to be gone (reduced
> from 14.1% to 2%), which further proved it.
I wonder whether it would be useful for bisection of performance issues
for you to change the global definition of DEFINE_PER_CPU() to make
all per CPU definitions aligned. Just like you switch compiler flags to make
all functions aligned.
-Tony
next prev parent reply other threads:[~2020-08-24 15:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 11:44 [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression kernel test robot
2020-04-25 11:44 ` kernel test robot
2020-04-25 13:01 ` Borislav Petkov
2020-04-25 13:01 ` Borislav Petkov
2020-08-18 8:29 ` Feng Tang
2020-08-18 8:29 ` [LKP] " Feng Tang
2020-08-18 20:06 ` Luck, Tony
2020-08-18 20:06 ` [LKP] " Luck, Tony
2020-08-19 2:04 ` Feng Tang
2020-08-19 2:04 ` [LKP] " Feng Tang
2020-08-19 2:23 ` Luck, Tony
2020-08-19 2:23 ` [LKP] " Luck, Tony
2020-08-19 3:04 ` Feng Tang
2020-08-19 3:04 ` [LKP] " Feng Tang
2020-08-19 3:15 ` Feng Tang
2020-08-19 3:15 ` [LKP] " Feng Tang
2020-08-21 2:02 ` Feng Tang
2020-08-21 2:02 ` [LKP] " Feng Tang
2020-08-24 15:14 ` Borislav Petkov
2020-08-24 15:14 ` [LKP] " Borislav Petkov
2020-08-24 15:33 ` Feng Tang
2020-08-24 15:33 ` [LKP] " Feng Tang
2020-08-24 15:38 ` Luck, Tony [this message]
2020-08-24 15:38 ` Luck, Tony
2020-08-24 15:48 ` Feng Tang
2020-08-24 15:48 ` [LKP] " Feng Tang
2020-08-24 16:12 ` Borislav Petkov
2020-08-24 16:12 ` [LKP] " Borislav Petkov
2020-08-24 16:56 ` Mel Gorman
2020-08-24 16:56 ` [LKP] " Mel Gorman
2020-08-25 6:49 ` Feng Tang
2020-08-25 6:49 ` [LKP] " Feng Tang
2020-08-25 6:23 ` Feng Tang
2020-08-25 6:23 ` [LKP] " Feng Tang
2020-08-25 16:44 ` Luck, Tony
2020-08-25 16:44 ` [LKP] " Luck, Tony
2020-08-26 1:45 ` Feng Tang
2020-08-26 1:45 ` [LKP] " Feng Tang
2020-08-28 17:48 ` Borislav Petkov
2020-08-28 17:48 ` [LKP] " Borislav Petkov
2020-08-31 2:16 ` Feng Tang
2020-08-31 2:16 ` [LKP] " Feng Tang
2020-08-31 7:56 ` Mel Gorman
2020-08-31 7:56 ` [LKP] " Mel Gorman
2020-08-31 8:23 ` Feng Tang
2020-08-31 8:23 ` [LKP] " Feng Tang
2020-08-31 8:55 ` Mel Gorman
2020-08-31 8:55 ` [LKP] " Mel Gorman
2020-08-31 12:53 ` Feng Tang
2020-08-31 12:53 ` [LKP] " Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e996ad05e434a6fb13f069ee72b876b@intel.com \
--to=tony.luck@intel.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.