RE: [OE-core] [PATCH 2/2] oe-setup-builddir: Do not hardcode invalid paths for templates

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: Alexander Kanavin <alex.kanavin@gmail.com>
> Sent: den 22 september 2022 17:53
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 2/2] oe-setup-builddir: Do not hardcode
> invalid paths for templates
> 
> .templateconf is not the way to specify the location of custom
> templates, and never was. It got added to documentation by
> misunderstanding, this has now been removed, and so you need to update
> your tooling so that templates are set with TEMPLATECONF going
> forward.
> 
> Alex

[Irritated rant below, and I apologize in advance. Sorry. I know 
you want to improve things, but I just have to state my opinion.]

Ok, this is silly. .templateconf _is_ the documented way to specify a 
default TEMPLATECONF and has been so for a long time. Just because 
you don't use it or like it does not mean that you can just rip it 
out and say we now have to use some (for us) inferior method. We have 
500+ developers and a huge number of CI/CD pipelines configured and 
built thousand times a day. They all expect the current setup, one 
they have used for ten years. The _exact same setup_ you get if you 
only fetch Poky and start a build.

All I want to do is remove hardcoded values in favor of remaining 
useful for all users of Yocto. Why is that a problem? I simply cannot 
understand it. To me, hardcoded values should never be used when a 
generic solution is possible. Why is it better to hardcode knowledge 
about Poky in OE-Core, when there is no reason to do so?

I know (or rather hope) you have some plan going forward for how to 
setup the build environment, but it is not there in Langdale. Also, 
I want to be able to continue with fetching the layers ourselves 
the way we always have done it and then continue to tell bitbake 
where to find them as we always have done without having to go 
through hoops or having to duplicate a lot of bitbake's internals.
And I believe this was actually said during all discussions about 
how to add support for a common way of setting up the build 
environment, that it should be possible for us that already have 
ways to do it (be they repo, submodules, kas, whisk or whatever) 
to continue to do so. So please, please be mindful of simple changes 
that allow us to continue to use the processes we already have in 
place when it really doesn't cost anything.

//Peter

> On Thu, 22 Sept 2022 at 15:26, Peter Kjellerstedt
> <peter.kjellerstedt@axis.com> wrote:
> >
> > > -----Original Message-----
> > > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > Sent: den 22 september 2022 15:14
> > > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded-
> core@lists.openembedded.org
> > > Subject: Re: [OE-core] [PATCH 2/2] oe-setup-builddir: Do not hardcode
> invalid paths for templates
> > >
> > > On Thu, 2022-09-22 at 14:47 +0200, Peter Kjellerstedt wrote:
> > > > Previously, the paths "meta/conf" and "meta-poky/conf" were
> hardcoded
> > > > as invalid paths for templates. However, this is suboptimal for
> other
> > > > distros that are setup similarly to Poky. Instead, add support for a
> > > > new variable INVALID_TEMPLATECONFS, which takes a list of invalid
> > > > paths.  It is expected that this variable is set in the
> .templateconf
> > > > file together with the default value for TEMPLATECONF, typically at
> > > > the same time that TEMPLATECONF is updated to match the new
> > > > requirements.
> > > >
> > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > > > ---
> > > >  scripts/oe-setup-builddir | 21 +++++++++++++--------
> > > >  1 file changed, 13 insertions(+), 8 deletions(-)
> > > >
> > > > diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir
> > > > index 225919be92..c1148daf4f 100755
> > > > --- a/scripts/oe-setup-builddir
> > > > +++ b/scripts/oe-setup-builddir
> > > > @@ -34,14 +34,19 @@ chmod -st "$BUILDDIR/conf" 2>/dev/null || echo
> "WARNING: unable to chmod $BUILDD
> > > >
> > > >  cd "$BUILDDIR" || die "Failed to change directory to $BUILDDIR!"
> > > >
> > > > -if [ -z "$TEMPLATECONF" ] && [ -f "$BUILDDIR/conf/templateconf.cfg"
> ]; then
> > > > -    TEMPLATECONF=$(cat "$BUILDDIR/conf/templateconf.cfg")
> > > > -    # The following two are no longer valid; unsetting them will
> automatically get them replaced
> > > > -    # with correct ones.
> > > > -    if [ "$TEMPLATECONF" = meta/conf ] || [ "$TEMPLATECONF" = meta-
> poky/conf ]; then
> > > > -        unset TEMPLATECONF
> > > > -        rm "$BUILDDIR/conf/templateconf.cfg"
> > > > -    fi
> > > > +TEMPLATECONF_CFG="$BUILDDIR/conf/templateconf.cfg"
> > > > +if [ -z "$TEMPLATECONF" ] && [ -f "$TEMPLATECONF_CFG" ]; then
> > > > +    TEMPLATECONF=$(cat "$TEMPLATECONF_CFG")
> > > > +    # Unset TEMPLATECONF if it is set to a known invalid value to
> have it
> > > > +    # automatically replaced with a correct one.
> > > > +    for dir in $INVALID_TEMPLATECONFS; do
> > > > +        if [ "$TEMPLATECONF" = "$dir" ]; then
> > > > +           echo "WARNING: Removing $TEMPLATECONF_CFG as it
> contained the invalid value '$TEMPLATECONF'"
> > > > +           unset TEMPLATECONF
> > > > +           rm "$TEMPLATECONF_CFG"
> > > > +      break;
> > > > +        fi
> > > > +    done
> > > >  fi
> > >
> > > I've been trying to keep out this discussion but I really don't like
> > > piling in more complexity and more things we have to support because
> of
> > > a legacy code path we're trying to obsolete.
> > >
> > > I also suspect this is going to be used to "subvert" the move to try
> > > and standardise and if that happens, we may as well not have bothered
> > > making changes at all :(.
> > >
> > > As such I'm worried about this direction.
> > >
> > > Cheers,
> > >
> > > Richard
> >
> > All I want is to remove the hardcoded superficial limitations and
> > allow us that provide distros setup just as Poky is setup to continue
> > to do so.
> >
> > //Peter
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#170981):
> https://lists.openembedded.org/g/openembedded-core/message/170981
> > Mute This Topic: https://lists.openembedded.org/mt/93847437/1686489
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
> [alex.kanavin@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >