Re: [PATCH v7 2/7] mux: Add helper functions for getting optional and selected mux-state

From: Josua Mayer <josua@solid-run.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Peter Rosin <peda@axentia.se>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Andreas Kemnade <andreas@kemnade.info>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Vignesh R <vigneshr@ti.com>, Andi Shyti <andi.shyti@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	Jon Nettleton <jon@solid-run.com>,
	Mikhail Anikin <mikhail.anikin@solid-run.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v7 2/7] mux: Add helper functions for getting optional and selected mux-state
Date: Tue, 3 Feb 2026 15:31:07 +0000	[thread overview]
Message-ID: <6f23c76f-9ced-4675-b262-ffa8dbaf6b33@solid-run.com> (raw)
In-Reply-To: <aYIOnErmiSZ6wnP1@stanley.mountain>

On 03/02/2026 17:05, Dan Carpenter wrote:
> Sorry about that, I just looked at the implementation in linux-next and
> didn't read the code from the patch too closely.
:)
>
> On Wed, Jan 28, 2026 at 04:46:10PM +0200, Josua Mayer wrote:
>> +/**
>> + * mux_control_get_optional() - Get the optional mux-control for a device.
>> + * @dev: The device that needs a mux-control.
>> + * @mux_name: The name identifying the mux-control.
>> + *
>> + * Return: A pointer to the mux-control, an ERR_PTR with a negative errno.
> I wish the documentation for these "optional" said it could return NULL.
Same. I fixed that for v8 on most functions, but missed one .... .
>
>> + */
>> +struct mux_control *mux_control_get_optional(struct device *dev, const char *mux_name)
>> +{
>> +	return mux_get(dev, mux_name, NULL, true);
>> +}
>> +EXPORT_SYMBOL_GPL(mux_control_get_optional);
>> +