From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH 1/3] x86/Intel: skip PLATFORM_INFO reads on family 0xf
Date: Thu, 10 Feb 2022 15:55:52 +0100 [thread overview]
Message-ID: <6f56a75c-cd68-0dad-b1ef-a3421271ee47@suse.com> (raw)
In-Reply-To: <5d275d7a-7751-af19-db4f-d91e3592d30f@suse.com>
This avoids unnecessary (and always somewhat scary) log messages for the
recovered from #GP(0).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Perhaps even use "!= 6" in at least the CPUID-faulting family check?
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -127,9 +127,12 @@ bool __init probe_cpuid_faulting(void)
/*
* Don't bother looking for CPUID faulting if we aren't virtualised on
- * AMD or Hygon hardware - it won't be present.
+ * AMD or Hygon hardware - it won't be present. Likewise for Fam0F
+ * Intel hardware.
*/
- if ((boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) &&
+ if (((boot_cpu_data.x86_vendor & (X86_VENDOR_AMD | X86_VENDOR_HYGON)) ||
+ ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) &&
+ boot_cpu_data.x86 == 0xf)) &&
!cpu_has_hypervisor)
return false;
--- a/xen/arch/x86/cpu/intel.c
+++ b/xen/arch/x86/cpu/intel.c
@@ -455,7 +455,7 @@ static void intel_log_freq(const struct
}
}
- if ( rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msrval) )
+ if ( c->x86 == 0xf || rdmsr_safe(MSR_INTEL_PLATFORM_INFO, msrval) )
return;
max_ratio = msrval >> 8;
next prev parent reply other threads:[~2022-02-10 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 14:54 [PATCH 0/3] x86/Intel: family 0xF tidying Jan Beulich
2022-02-10 14:55 ` Jan Beulich [this message]
2022-02-11 9:40 ` [PATCH 1/3] x86/Intel: skip PLATFORM_INFO reads on family 0xf Roger Pau Monné
2022-02-11 9:59 ` Jan Beulich
2022-02-11 10:41 ` Roger Pau Monné
2022-02-10 14:56 ` [PATCH 2/3] x86/Intel: skip CORE_THREAD_COUNT read " Jan Beulich
2022-02-11 10:58 ` Roger Pau Monné
2022-02-11 11:05 ` Jan Beulich
2022-02-10 14:56 ` [PATCH 3/3] x86/Intel: also display CPU freq for " Jan Beulich
2022-02-11 10:22 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f56a75c-cd68-0dad-b1ef-a3421271ee47@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.