All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/3] x86/Intel: skip PLATFORM_INFO reads on family 0xf
Date: Fri, 11 Feb 2022 10:40:08 +0100	[thread overview]
Message-ID: <YgYu+OoAovYmTg8E@Air-de-Roger> (raw)
In-Reply-To: <6f56a75c-cd68-0dad-b1ef-a3421271ee47@suse.com>

On Thu, Feb 10, 2022 at 03:55:52PM +0100, Jan Beulich wrote:
> This avoids unnecessary (and always somewhat scary) log messages for the
> recovered from #GP(0).

Could we maybe get rid of the #GP messages for cases like this where we
are explicitly probing for MSR presence? (ie: it's expected that we
can get a #GP)

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Perhaps even use "!= 6" in at least the CPUID-faulting family check?

Likely, or else you would also need to check for family 11 (Knights
Corner?) which doesn't seem to support PLATFORM_INFO either.

Thanks, Roger.


  reply	other threads:[~2022-02-11  9:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 14:54 [PATCH 0/3] x86/Intel: family 0xF tidying Jan Beulich
2022-02-10 14:55 ` [PATCH 1/3] x86/Intel: skip PLATFORM_INFO reads on family 0xf Jan Beulich
2022-02-11  9:40   ` Roger Pau Monné [this message]
2022-02-11  9:59     ` Jan Beulich
2022-02-11 10:41       ` Roger Pau Monné
2022-02-10 14:56 ` [PATCH 2/3] x86/Intel: skip CORE_THREAD_COUNT read " Jan Beulich
2022-02-11 10:58   ` Roger Pau Monné
2022-02-11 11:05     ` Jan Beulich
2022-02-10 14:56 ` [PATCH 3/3] x86/Intel: also display CPU freq for " Jan Beulich
2022-02-11 10:22   ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgYu+OoAovYmTg8E@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.