Re: [dpdk-dev] [PATCH v3 3/6] bbdev: add capability for 4G CB CRC DROP

[Tom Rix <trix@redhat.com>]

On 9/7/21 6:15 PM, Nicolas Chautru wrote:
> Adding option to drop CRC24B to align with existing
> feature for 5G
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   app/test-bbdev/test_bbdev_vector.c | 2 ++
>   lib/bbdev/rte_bbdev_op.h           | 5 ++++-
>   2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c
> index 8d796b1..f020836 100644
> --- a/app/test-bbdev/test_bbdev_vector.c
> +++ b/app/test-bbdev/test_bbdev_vector.c
> @@ -149,6 +149,8 @@
>   		*op_flag_value = RTE_BBDEV_TURBO_DEC_SCATTER_GATHER;
>   	else if (!strcmp(token, "RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP"))
>   		*op_flag_value = RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP;
> +	else if (!strcmp(token, "RTE_BBDEV_TURBO_DEC_CRC_24B_DROP"))
> +		*op_flag_value = RTE_BBDEV_TURBO_DEC_CRC_24B_DROP;
>   	else {
>   		printf("The given value is not a turbo decoder flag\n");
>   		return -1;
> diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
> index 7c44ddd..5512859 100644
> --- a/lib/bbdev/rte_bbdev_op.h
> +++ b/lib/bbdev/rte_bbdev_op.h
> @@ -114,7 +114,10 @@ enum rte_bbdev_op_td_flag_bitmasks {
>   	/** Set to keep CRC24B bits appended while decoding. Only usable when
>   	 * decoding Transport Block mode.
>   	 */
> -	RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP = (1ULL << 16)
> +	RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP = (1ULL << 16),
> +	/** Set to drop CRC24B bits not to be appended while decoding.
> +	 */
> +	RTE_BBDEV_TURBO_DEC_CRC_24B_DROP = (1ULL << 17)
>   };
>   
>   

This is ok, thanks.

Reviewed-by: Tom Rix <trix@redhat.com>