[meta-browser] host leaking wayland-scanner?

[meta-browser] host leaking wayland-scanner?

[Ulrich Ölmann]

Hi developers of meta-browser,

while building meta-browser's latest chromium-ozone-wayland recipe (my
meta-browser's current state is [1], integrated into a customer's thud
based Yocto-BSP) I faced the following problem (excerpt from log.do_com-
pile)

  [9109/37430] python ../../third_party/wayland/wayland_scanner_wrapper.py third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml --src-root ../../ --root-gen-dir gen --cmd /usr/bin/wayland-scanner
  FAILED: gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-protocol.c gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-client-protocol.h gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-server-protocol.h
  python ../../third_party/wayland/wayland_scanner_wrapper.py third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml --src-root ../../ --root-gen-dir gen --cmd /usr/bin/wayland-scanner
  Traceback (most recent call last):
    File "../../third_party/wayland/wayland_scanner_wrapper.py", line 48, in <module>
      main(sys.argv)
    File "../../third_party/wayland/wayland_scanner_wrapper.py", line 40, in main
      generate_code(cmd, "code", protocol_path, out_base_name + "-protocol.c")
    File "../../third_party/wayland/wayland_scanner_wrapper.py", line 18, in generate_code
      ret = subprocess.call([wayland_scanner_cmd, code_type, path_in, path_out])
    File "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 172, in call
      return Popen(*popenargs, **kwargs).wait()
    File "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 394, in __init__
      errread, errwrite)
    File "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child
      raise child_exception
  OSError: [Errno 2] No such file or directory

which seems to come from my build host not providing '/usr/bin/wayland-
scanner' and which suggests that we have a host tool leakage here. This
all originally results from Chromium's commit [2], particularly [3].

Unfortunately up to now I am not familiar with Google's build tool 'GN'
(see [4]), so I can't present a solution straightaway. But I would like
to start working on a patch now, hence my questions are:

  - did anyone notice the same issue?
  - is my analysis correct that [3] has to be patched somehow and the
    recipe [5] lacks a dependency on wayland-native?

Best regards
Ulrich


P.S.: Sending this message a second time as I have not been subscribed
to the oe-devel list before so that the original mail got rejected.


[1] e0d1e299d691 ("chromium: fix "pure virtual method called" problem.")
[2] https://chromium.googlesource.com/chromium/src/+/a64f758399d26a1c80ab0d3dfecee3abf0714305
    a64f758399d2 ("Run wayland-scanner as part of build")
[3] https://chromium.googlesource.com/chromium/src/+/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/features.gni#12
[4] https://gn.googlesource.com/gn/
[5] https://github.com/OSSystems/meta-browser/blob/master/recipes-browser/chromium/chromium-ozone-wayland_75.0.3770.100.bb
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [meta-browser] host leaking wayland-scanner?

[Ulrich Ölmann]

Hi Maksim,

On Wed, Jun 26 2019 at 14:39 +0200, Maksim Sisov <msisov@igalia.com> wrote:
> The wayland-scanner issue must have been fixed by
> https://github.com/OSSystems/meta-browser/commit/cd88d7be61bc39726b8ecf7ddc19e6942bcf8cb4

ah, okay - that's right. But unfortunately it was re-introduced by
commit [6] later. At least that shows how to fix it again - I will
prepare a patch.

Thanks & best regards
Ulrich


[6] 1f363e25cb7d ("chromium: Update to 74.0.3729.131")

> On 26.06.2019 15:29, Ulrich Ölmann wrote:
>> Hi developers of meta-browser,
>>
>> while building meta-browser's latest chromium-ozone-wayland recipe (my
>> meta-browser's current state is [1], integrated into a customer's thud
>> based Yocto-BSP) I faced the following problem (excerpt from log.do_com-
>> pile)
>>
>>   [9109/37430] python
>> ../../third_party/wayland/wayland_scanner_wrapper.py
>> third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
>> --src-root ../../ --root-gen-dir gen --cmd /usr/bin/wayland-scanner
>>   FAILED:
>> gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-protocol.c
>> gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-client-protocol.h
>> gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-server-protocol.h
>>   python ../../third_party/wayland/wayland_scanner_wrapper.py
>> third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
>> --src-root ../../ --root-gen-dir gen --cmd /usr/bin/wayland-scanner
>>   Traceback (most recent call last):
>>     File "../../third_party/wayland/wayland_scanner_wrapper.py", line
>> 48, in <module>
>>       main(sys.argv)
>>     File "../../third_party/wayland/wayland_scanner_wrapper.py", line
>> 40, in main
>>       generate_code(cmd, "code", protocol_path, out_base_name + "-protocol.c")
>>     File "../../third_party/wayland/wayland_scanner_wrapper.py", line
>> 18, in generate_code
>>       ret = subprocess.call([wayland_scanner_cmd, code_type, path_in, path_out])
>>     File
>> "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",
>> line 172, in call
>>       return Popen(*popenargs, **kwargs).wait()
>>     File
>> "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",
>> line 394, in __init__
>>       errread, errwrite)
>>     File
>> "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py",
>> line 1047, in _execute_child
>>       raise child_exception
>>   OSError: [Errno 2] No such file or directory
>>
>> which seems to come from my build host not providing '/usr/bin/wayland-
>> scanner' and which suggests that we have a host tool leakage here. This
>> all originally results from Chromium's commit [2], particularly [3].
>>
>> Unfortunately up to now I am not familiar with Google's build tool 'GN'
>> (see [4]), so I can't present a solution straightaway. But I would like
>> to start working on a patch now, hence my questions are:
>>
>>   - did anyone notice the same issue?
>>   - is my analysis correct that [3] has to be patched somehow and the
>>     recipe [5] lacks a dependency on wayland-native?
>>
>> Best regards
>> Ulrich
>>
>>
>> P.S.: Sending this message a second time as I have not been subscribed
>> to the oe-devel list before so that the original mail got rejected.
>>
>>
>> [1] e0d1e299d691 ("chromium: fix "pure virtual method called" problem.")
>> [2]
>> https://chromium.googlesource.com/chromium/src/+/a64f758399d26a1c80ab0d3dfecee3abf0714305
>>     a64f758399d2 ("Run wayland-scanner as part of build")
>> [3]
>> https://chromium.googlesource.com/chromium/src/+/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/features.gni#12
>> [4] https://gn.googlesource.com/gn/
>> [5]
>> https://github.com/OSSystems/meta-browser/blob/master/recipes-browser/chromium/chromium-ozone-wayland_75.0.3770.100.bb


--
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [meta-browser] host leaking wayland-scanner?

[Ulrich Ölmann]

Again it's me with another small question regarding meta-browser's
maintainership - I got the following back from our mail delivery system:

    From: Mail Delivery System <Mailer-Daemon@pengutronix.de>
    To: uol@pengutronix.de
    Subject: Mail delivery failed: returning message to sender
    Date: Wed 26.06.2019
    Flags: seen
    Maildir: /
    Message-Id: E1hg7dM-00010M-3n@metis.ext.pengutronix.de
    Attachments: [1]Re- [meta-browser] host leaking wayland-scanner?.eml

    This message was created automatically by mail delivery software.

    A message that you sent could not be delivered to one or more of its
    recipients. This is a permanent error. The following address(es) failed:

      denis@eukrea.com
        host mx1.ovh.net [188.165.47.122]
        SMTP error from remote mail server after RCPT TO:<denis@eukrea.com>:
        554 5.7.1 <denis@eukrea.com>: Relay access denied
      eric@eukrea.com
        host mx1.ovh.net [188.165.47.122]
        SMTP error from remote mail server after RCPT TO:<eric@eukrea.com>:
        554 5.7.1 <eric@eukrea.com>: Relay access denied

Are Denis Carikli and Eric Bénard still actively maintaining meta-
browser? (Their last commits are from 2012-07-12 and 2013-03-08
respectively). As both are listed as maintainers in [6] I would like to
ask if a patch to update the README file is welcome? Are there other
maintainers that shall be listed there instead?

Best regards
Ulrich


[6] https://github.com/OSSystems/meta-browser/blob/master/README

On Wed, Jun 26 2019 at 14:29 +0200, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
> Hi developers of meta-browser,
>
> while building meta-browser's latest chromium-ozone-wayland recipe (my
> meta-browser's current state is [1], integrated into a customer's thud
> based Yocto-BSP) I faced the following problem (excerpt from log.do_com-
> pile)
>
>   [9109/37430] python ../../third_party/wayland/wayland_scanner_wrapper.py third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml --src-root ../../ --root-gen-dir gen --cmd /usr/bin/wayland-scanner
>   FAILED: gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-protocol.c gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-client-protocol.h gen/third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1-server-protocol.h
>   python ../../third_party/wayland/wayland_scanner_wrapper.py third_party/wayland-protocols/src/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml --src-root ../../ --root-gen-dir gen --cmd /usr/bin/wayland-scanner
>   Traceback (most recent call last):
>     File "../../third_party/wayland/wayland_scanner_wrapper.py", line 48, in <module>
>       main(sys.argv)
>     File "../../third_party/wayland/wayland_scanner_wrapper.py", line 40, in main
>       generate_code(cmd, "code", protocol_path, out_base_name + "-protocol.c")
>     File "../../third_party/wayland/wayland_scanner_wrapper.py", line 18, in generate_code
>       ret = subprocess.call([wayland_scanner_cmd, code_type, path_in, path_out])
>     File "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 172, in call
>       return Popen(*popenargs, **kwargs).wait()
>     File "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 394, in __init__
>       errread, errwrite)
>     File "<UNDISCLOSED_PATH>/build/YOCTO.BSP/tmp/work/cortexa9hf-neon-pmc-linux-gnueabi/chromium-ozone-wayland/75.0.3770.100-r0/recipe-sysroot-native/usr/lib/python2.7/subprocess.py", line 1047, in _execute_child
>       raise child_exception
>   OSError: [Errno 2] No such file or directory
>
> which seems to come from my build host not providing '/usr/bin/wayland-
> scanner' and which suggests that we have a host tool leakage here. This
> all originally results from Chromium's commit [2], particularly [3].
>
> Unfortunately up to now I am not familiar with Google's build tool 'GN'
> (see [4]), so I can't present a solution straightaway. But I would like
> to start working on a patch now, hence my questions are:
>
>   - did anyone notice the same issue?
>   - is my analysis correct that [3] has to be patched somehow and the
>     recipe [5] lacks a dependency on wayland-native?
>
> Best regards
> Ulrich
>
>
> P.S.: Sending this message a second time as I have not been subscribed
> to the oe-devel list before so that the original mail got rejected.
>
>
> [1] e0d1e299d691 ("chromium: fix "pure virtual method called" problem.")
> [2] https://chromium.googlesource.com/chromium/src/+/a64f758399d26a1c80ab0d3dfecee3abf0714305
>     a64f758399d2 ("Run wayland-scanner as part of build")
> [3] https://chromium.googlesource.com/chromium/src/+/a64f758399d26a1c80ab0d3dfecee3abf0714305/third_party/wayland/features.gni#12
> [4] https://gn.googlesource.com/gn/
> [5] https://github.com/OSSystems/meta-browser/blob/master/recipes-browser/chromium/chromium-ozone-wayland_75.0.3770.100.bb
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [meta-browser] host leaking wayland-scanner?

[Otavio Salvador]

Hello Ulrich,

On Wed, Jun 26, 2019 at 10:29 AM Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
> Again it's me with another small question regarding meta-browser's
> maintainership - I got the following back from our mail delivery system:
...
> Are Denis Carikli and Eric Bénard still actively maintaining meta-
> browser? (Their last commits are from 2012-07-12 and 2013-03-08
> respectively).

They are not.

> As both are listed as maintainers in [6] I would like to
> ask if a patch to update the README file is welcome? Are there other
> maintainers that shall be listed there instead?

Absolutely, please prepare it.

Raphael, Maksim, Khem, Fabio and I are the active people.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

[meta-browser][PATCH] README: update list of maintainers

[Ulrich Ölmann]

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
 README | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/README b/README
index 0a005a8b5ea6..31d361d2ab41 100644
--- a/README
+++ b/README
@@ -23,13 +23,15 @@ revision: HEAD
 Contributing
 ------------
 
-To contribute to this layer you should the patches for review to the
+To contribute to this layer you should send the patches for review to the
 OpenEmbedded dev mailing list openembedded-devel@lists.openembedded.org
 and please cc the maintainers.
 
-Maintainers: Eric Bénard <eric@eukrea.com>
-             Denis Carikli <denis@eukrea.com>
+Maintainers: Fabio Berton <fabio.berton@ossystems.com.br>
+             Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
+             Khem Raj <raj.khem@gmail.com>
              Otavio Salvador <otavio@ossystems.com.br>
+             Maksim Sisov <msisov@igalia.com>
 
 When sending single patches, please use something like :
 git send-email -1 -s --to openembedded-devel@lists.openembedded.org --subject-prefix='meta-browser][PATCH'
-- 
2.20.1

Re: [meta-browser][PATCH] README: update list of maintainers

[Ulrich Ölmann]

Hi there,

to ease the development flow I created a pull request on GitHub for this
subthread's patch as well :)

  https://github.com/OSSystems/meta-browser/pull/279

Best regards
Ulrich


On Thu, Jun 27 2019 at 01:23 +0200, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  README | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/README b/README
> index 0a005a8b5ea6..31d361d2ab41 100644
> --- a/README
> +++ b/README
> @@ -23,13 +23,15 @@ revision: HEAD
>  Contributing
>  ------------
>
> -To contribute to this layer you should the patches for review to the
> +To contribute to this layer you should send the patches for review to the
>  OpenEmbedded dev mailing list openembedded-devel@lists.openembedded.org
>  and please cc the maintainers.
>
> -Maintainers: Eric Bénard <eric@eukrea.com>
> -             Denis Carikli <denis@eukrea.com>
> +Maintainers: Fabio Berton <fabio.berton@ossystems.com.br>
> +             Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
> +             Khem Raj <raj.khem@gmail.com>
>               Otavio Salvador <otavio@ossystems.com.br>
> +             Maksim Sisov <msisov@igalia.com>
>
>  When sending single patches, please use something like :
>  git send-email -1 -s --to openembedded-devel@lists.openembedded.org --subject-prefix='meta-browser][PATCH'
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |