From: Florian Fainelli <florian@openwrt.org>
To: linux-mips@linux-mips.org
Cc: "Steven J. Hill" <sjhill@mips.com>, ralf@linux-mips.org
Subject: Re: [PATCH 00/35] Cleanup firmware support across multiple platforms.
Date: Wed, 06 Jun 2012 14:16:36 +0200 [thread overview]
Message-ID: <7001181.e1a1v1VHCx@flexo> (raw)
In-Reply-To: <1338931179-9611-1-git-send-email-sjhill@mips.com>
Hi Steven,
On Tuesday 05 June 2012 16:19:04 Steven J. Hill wrote:
> From: "Steven J. Hill" <sjhill@mips.com>
>
> The firmware/bootloader support code has been duplicated across a lot
> of platforms and continues to self-replicate. These patches move the
> support code into the common 'arch/mips/fw/lib' directory. All affected
> platforms have been built and produce a linked kernel. Any files that
> were modified also had their headers cleaned up and the checkpatch
> script ran on them.
The rationale for your patches look good to me, as well as the impressive
diffstat. You seem to be mixing fixes with cleanups however. Otherwise, for the
AR7 and RB532 bits, you have my ack.
>
> Steven J. Hill (35):
> MIPS: Add environment variable processing code to firmware library.
> MIPS: Alchemy: Cleanup firmware support for Alchemy platforms.
> MIPS: Alchemy: Cleanup files effected by firmware changes.
> MIPS: AR7: Cleanup firmware support for the AR7 platform.
> MIPS: AR7: Cleanup files effected by firmware changes.
> MIPS: ath79: Cleanup firmware support for the ath79 platform.
> MIPS: ath79: Cleanup files effected by firmware changes.
> MIPS: Cobalt: Cleanup firmware support for the Cobalt platform.
> MIPS: Cobalt: Cleanup files effected by firmware changes.
> MIPS: Emma: Cleanup firmware support for the Emma platform.
> MIPS: Emma: Cleanup files effected by firmware changes.
> MIPS: jz4740: Cleanup firmware support for the JZ4740 platform.
> MIPS: jz4740: Cleanup files effected by firmware changes.
> MIPS: lantiq: Cleanup firmware support for the lantiq platform.
> MIPS: lantiq: Cleanup files effected by firmware changes.
> MIPS: Lasat: Cleanup firmware support for the Lasat platform.
> MIPS: Lasat: Cleanup files effected by firmware changes.
> MIPS: Loongson: Cleanup firmware support for the Loongson platform.
> MIPS: Loongson: Cleanup files effected by firmware changes.
> MIPS: Malta: Cleanup firmware support for the Malta platform.
> MIPS: Malta: Cleanup files effected by firmware changes.
> MIPS: Netlogic: Cleanup firmware support for the XLR platform.
> MIPS: Netlogic: Cleanup files effected by firmware changes.
> MIPS: MSP71xx, Yosemite: Cleanup firmware support for PMC platforms.
> MIPS: MSP71xx, Yosemite: Cleanup files effected by firmware changes.
> MIPS: PNX83xx, PNX8550: Cleanup firmware support for PNX platforms.
> MIPS: PNX83xx, PNX8550: Cleanup files effected by firmware changes.
> MIPS: PowerTV: Cleanup firmware support for PowerTV platform.
> MIPS: PowerTV: Cleanup files effected by firmware changes.
> MIPS: RB532: Cleanup firmware support for RB532 platform.
> MIPS: RB532: Cleanup files effected by firmware changes.
> MIPS: txx9: Cleanup firmware support for txx9 platforms.
> MIPS: txx9: Cleanup files effected by firmware changes.
> MIPS: vr41xx: Cleanup firmware support for vr41xx platforms.
> MIPS: vr41xx: Cleanup files effected by firmware changes.
>
> arch/mips/alchemy/board-gpr.c | 48 ++---
> arch/mips/alchemy/board-mtx1.c | 48 ++---
> arch/mips/alchemy/board-xxs1500.c | 45 ++---
> arch/mips/alchemy/common/platform.c | 30 +--
> arch/mips/alchemy/common/prom.c | 79 ++------
> arch/mips/alchemy/devboards/db1000.c | 1 -
> arch/mips/alchemy/devboards/db1300.c | 1 -
> arch/mips/alchemy/devboards/db1550.c | 1 -
> arch/mips/alchemy/devboards/pb1100.c | 1 -
> arch/mips/alchemy/devboards/pb1500.c | 1 -
> arch/mips/alchemy/devboards/prom.c | 54 ++---
> arch/mips/ar7/memory.c | 22 +--
> arch/mips/ar7/platform.c | 63 +++---
> arch/mips/ar7/prom.c | 62 ++----
> arch/mips/ar7/setup.c | 26 +--
> arch/mips/ath79/prom.c | 33 +---
> arch/mips/cobalt/setup.c | 42 ++--
> arch/mips/emma/common/prom.c | 44 +----
> arch/mips/fw/lib/Makefile | 2 +
> arch/mips/fw/lib/cmdline.c | 86 ++++++++
> arch/mips/include/asm/fw/fw.h | 47 +++++
> arch/mips/include/asm/mach-ar7/prom.h | 25 ---
> arch/mips/include/asm/mach-au1x00/au1xxx_eth.h | 1 +
> arch/mips/include/asm/mach-au1x00/prom.h | 12 --
> arch/mips/include/asm/mach-loongson/loongson.h | 54 ++---
> arch/mips/include/asm/mips-boards/generic.h | 30 +--
> arch/mips/include/asm/mips-boards/prom.h | 47 -----
> .../mips/include/asm/pmc-sierra/msp71xx/msp_prom.h | 52 +----
> arch/mips/include/asm/txx9/generic.h | 1 -
> arch/mips/jz4740/prom.c | 50 ++---
> arch/mips/lantiq/prom.c | 32 +--
> arch/mips/lasat/prom.c | 24 +--
> arch/mips/loongson/common/Makefile | 2 +-
> arch/mips/loongson/common/cmdline.c | 48 -----
> arch/mips/loongson/common/env.c | 40 ++--
> arch/mips/loongson/common/init.c | 16 +-
> arch/mips/mti-malta/Makefile | 2 +-
> arch/mips/mti-malta/malta-cmdline.c | 59 ------
> arch/mips/mti-malta/malta-display.c | 40 ++--
> arch/mips/mti-malta/malta-init.c | 157 +++------------
> arch/mips/mti-malta/malta-memory.c | 108 ++++------
> arch/mips/mti-malta/malta-setup.c | 59 ++----
> arch/mips/mti-malta/malta-time.c | 65 ++----
> arch/mips/netlogic/xlr/setup.c | 82 ++------
> arch/mips/pmc-sierra/msp71xx/msp_prom.c | 207
+++++---------------
> arch/mips/pmc-sierra/msp71xx/msp_serial.c | 69 +++----
> arch/mips/pmc-sierra/msp71xx/msp_setup.c | 43 ++--
> arch/mips/pmc-sierra/msp71xx/msp_time.c | 75 ++-----
> arch/mips/pmc-sierra/msp71xx/msp_usb.c | 45 ++---
> arch/mips/pmc-sierra/yosemite/prom.c | 46 ++---
> arch/mips/pnx833x/common/Makefile | 2 +-
> arch/mips/pnx833x/common/prom.c | 64 ------
> arch/mips/pnx833x/common/setup.c | 39 ++--
> arch/mips/pnx833x/stb22x/board.c | 70 +++----
> arch/mips/pnx8550/common/Makefile | 2 +-
> arch/mips/pnx8550/common/prom.c | 128 ------------
> arch/mips/pnx8550/common/setup.c | 69 +++----
> arch/mips/pnx8550/jbs/init.c | 45 +----
> arch/mips/pnx8550/stb810/prom_init.c | 36 +---
> arch/mips/powertv/asic/asic_int.c | 45 ++---
> arch/mips/powertv/init.c | 81 ++------
> arch/mips/powertv/memory.c | 39 ++--
> arch/mips/powertv/powertv_setup.c | 29 +--
> arch/mips/rb532/prom.c | 69 +++----
> arch/mips/txx9/generic/setup.c | 85 ++------
> arch/mips/vr41xx/common/init.c | 41 +---
> drivers/mtd/maps/pmcmsp-flash.c | 58 ++----
> drivers/net/ethernet/amd/au1000_eth.c | 1 -
> 68 files changed, 890 insertions(+), 2240 deletions(-)
> create mode 100644 arch/mips/fw/lib/cmdline.c
> create mode 100644 arch/mips/include/asm/fw/fw.h
> delete mode 100644 arch/mips/include/asm/mach-ar7/prom.h
> delete mode 100644 arch/mips/include/asm/mach-au1x00/prom.h
> delete mode 100644 arch/mips/include/asm/mips-boards/prom.h
> delete mode 100644 arch/mips/loongson/common/cmdline.c
> delete mode 100644 arch/mips/mti-malta/malta-cmdline.c
> delete mode 100644 arch/mips/pnx833x/common/prom.c
> delete mode 100644 arch/mips/pnx8550/common/prom.c
>
> --
> 1.7.10.3
>
>
--
Florian
next prev parent reply other threads:[~2012-06-06 12:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 21:19 [PATCH 00/35] Cleanup firmware support across multiple platforms Steven J. Hill
2012-06-05 21:19 ` [PATCH 01/35] MIPS: Add environment variable processing code to firmware library Steven J. Hill
2012-06-05 21:19 ` [PATCH 02/35] MIPS: Alchemy: Cleanup firmware support for Alchemy platforms Steven J. Hill
2012-06-05 21:19 ` [PATCH 03/35] MIPS: Alchemy: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 04/35] MIPS: AR7: Cleanup firmware support for the AR7 platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 05/35] MIPS: AR7: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 06/35] MIPS: ath79: Cleanup firmware support for the ath79 platform Steven J. Hill
2012-06-06 13:04 ` Gabor Juhos
2012-06-05 21:19 ` [PATCH 07/35] MIPS: ath79: Cleanup files effected by firmware changes Steven J. Hill
2012-06-06 11:16 ` Sergei Shtylyov
2012-06-05 21:19 ` [PATCH 08/35] MIPS: Cobalt: Cleanup firmware support for the Cobalt platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 09/35] MIPS: Cobalt: Cleanup files effected by firmware changes Steven J. Hill
2012-06-06 2:09 ` Yuasa Yoichi
2012-06-06 2:22 ` Hill, Steven
2012-06-05 21:19 ` [PATCH 10/35] MIPS: Emma: Cleanup firmware support for the Emma platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 11/35] MIPS: Emma: Cleanup files effected by firmware changes Steven J. Hill
2012-06-06 11:29 ` Sergei Shtylyov
2012-06-05 21:19 ` [PATCH 12/35] MIPS: jz4740: Cleanup firmware support for the JZ4740 platform Steven J. Hill
2012-06-06 12:13 ` Lars-Peter Clausen
2012-06-05 21:19 ` [PATCH 13/35] MIPS: jz4740: Cleanup files effected by firmware changes Steven J. Hill
2012-06-06 11:38 ` Sergei Shtylyov
2012-06-06 12:18 ` Lars-Peter Clausen
2012-06-05 21:19 ` [PATCH 14/35] MIPS: lantiq: Cleanup firmware support for the lantiq platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 15/35] MIPS: lantiq: Cleanup files effected by firmware changes Steven J. Hill
2012-06-06 5:38 ` John Crispin
2012-06-05 21:19 ` [PATCH 16/35] MIPS: Lasat: Cleanup firmware support for the Lasat platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 17/35] MIPS: Lasat: Cleanup files effected by firmware changes Steven J. Hill
2012-06-06 11:54 ` Sergei Shtylyov
2012-06-05 21:19 ` [PATCH 18/35] MIPS: Loongson: Cleanup firmware support for the Loongson platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 19/35] MIPS: Loongson: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 20/35] MIPS: Malta: Cleanup firmware support for the Malta platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 21/35] MIPS: Malta: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 22/35] MIPS: Netlogic: Cleanup firmware support for the XLR platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 23/35] MIPS: Netlogic: Cleanup files effected by firmware changes Steven J. Hill
2012-06-06 8:42 ` Jayachandran C.
2012-06-06 12:00 ` Sergei Shtylyov
2012-06-05 21:19 ` [PATCH 24/35] MIPS: MSP71xx, Yosemite: Cleanup firmware support for PMC platforms Steven J. Hill
2012-06-05 21:19 ` [PATCH 25/35] MIPS: MSP71xx, Yosemite: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 26/35] MIPS: PNX83xx, PNX8550: Cleanup firmware support for PNX platforms Steven J. Hill
2012-06-05 21:19 ` [PATCH 27/35] MIPS: PNX83xx, PNX8550: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 28/35] MIPS: PowerTV: Cleanup firmware support for PowerTV platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 29/35] MIPS: PowerTV: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 30/35] MIPS: RB532: Cleanup firmware support for RB532 platform Steven J. Hill
2012-06-05 21:19 ` [PATCH 31/35] MIPS: RB532: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 32/35] MIPS: txx9: Cleanup firmware support for txx9 platforms Steven J. Hill
2012-06-06 13:27 ` Geert Uytterhoeven
2012-06-05 21:19 ` [PATCH 33/35] MIPS: txx9: Cleanup files effected by firmware changes Steven J. Hill
2012-06-05 21:19 ` [PATCH 34/35] MIPS: vr41xx: Cleanup firmware support for vr41xx platforms Steven J. Hill
2012-06-06 2:20 ` Yuasa Yoichi
2012-06-06 2:27 ` Hill, Steven
2012-06-06 2:36 ` Yuasa Yoichi
2012-06-05 21:19 ` [PATCH 35/35] MIPS: vr41xx: Cleanup files effected by firmware changes Steven J. Hill
2012-06-06 2:14 ` Yuasa Yoichi
2012-06-06 2:18 ` Hill, Steven
2012-06-06 2:33 ` Yuasa Yoichi
2012-06-06 12:16 ` Florian Fainelli [this message]
2012-06-07 14:46 ` [PATCH 00/35] Cleanup firmware support across multiple platforms Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7001181.e1a1v1VHCx@flexo \
--to=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.