All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Sergiu Moga <sergiu.moga@microchip.com>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski@canonical.com>,
	<alexandre.belloni@bootlin.com>, <claudiu.beznea@microchip.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-i2c@vger.kernel.org>,
	Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH v2 1/3] ARM: dts: at91: sama7g5: Swap `rx` and `tx` for `i2c` nodes
Date: Wed, 13 Apr 2022 18:36:52 +0200	[thread overview]
Message-ID: <703ee79c-3b25-5b1f-dfe1-bfafade468fd@microchip.com> (raw)
In-Reply-To: <20220310114553.184763-2-sergiu.moga@microchip.com>

On 10/03/2022 at 12:45, Sergiu Moga wrote:
> Swap `rx` and `tx` for the `dma-names` property of the `i2c` nodes
> in order to maintain consistency across Microchip/Atmel SoC files.
> 
> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
As it fixes some of the warning in dt schema check in 5.18-rc1, I queue 
this patch in "fixes" branch for 5.18.

Thanks, best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/sama7g5.dtsi | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index 4decd3a91a76..f691c8f08d04 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -601,9 +601,9 @@ i2c1: i2c@600 {
>   				#size-cells = <0>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 39>;
>   				atmel,fifo-size = <32>;
> -				dmas = <&dma0 AT91_XDMAC_DT_PERID(7)>,
> -					<&dma0 AT91_XDMAC_DT_PERID(8)>;
> -				dma-names = "rx", "tx";
> +				dmas = <&dma0 AT91_XDMAC_DT_PERID(8)>,
> +					<&dma0 AT91_XDMAC_DT_PERID(7)>;
> +				dma-names = "tx", "rx";
>   				status = "disabled";
>   			};
>   		};
> @@ -786,9 +786,9 @@ i2c8: i2c@600 {
>   				#size-cells = <0>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 46>;
>   				atmel,fifo-size = <32>;
> -				dmas = <&dma0 AT91_XDMAC_DT_PERID(21)>,
> -					<&dma0 AT91_XDMAC_DT_PERID(22)>;
> -				dma-names = "rx", "tx";
> +				dmas = <&dma0 AT91_XDMAC_DT_PERID(22)>,
> +					<&dma0 AT91_XDMAC_DT_PERID(21)>;
> +				dma-names = "tx", "rx";
>   				status = "disabled";
>   			};
>   		};
> @@ -810,9 +810,9 @@ i2c9: i2c@600 {
>   				#size-cells = <0>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 47>;
>   				atmel,fifo-size = <32>;
> -				dmas = <&dma0 AT91_XDMAC_DT_PERID(23)>,
> -					<&dma0 AT91_XDMAC_DT_PERID(24)>;
> -				dma-names = "rx", "tx";
> +				dmas = <&dma0 AT91_XDMAC_DT_PERID(24)>,
> +					<&dma0 AT91_XDMAC_DT_PERID(23)>;
> +				dma-names = "tx", "rx";
>   				status = "disabled";
>   			};
>   		};


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Sergiu Moga <sergiu.moga@microchip.com>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski@canonical.com>,
	<alexandre.belloni@bootlin.com>, <claudiu.beznea@microchip.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-i2c@vger.kernel.org>,
	Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH v2 1/3] ARM: dts: at91: sama7g5: Swap `rx` and `tx` for `i2c` nodes
Date: Wed, 13 Apr 2022 18:36:52 +0200	[thread overview]
Message-ID: <703ee79c-3b25-5b1f-dfe1-bfafade468fd@microchip.com> (raw)
In-Reply-To: <20220310114553.184763-2-sergiu.moga@microchip.com>

On 10/03/2022 at 12:45, Sergiu Moga wrote:
> Swap `rx` and `tx` for the `dma-names` property of the `i2c` nodes
> in order to maintain consistency across Microchip/Atmel SoC files.
> 
> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
As it fixes some of the warning in dt schema check in 5.18-rc1, I queue 
this patch in "fixes" branch for 5.18.

Thanks, best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/sama7g5.dtsi | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index 4decd3a91a76..f691c8f08d04 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -601,9 +601,9 @@ i2c1: i2c@600 {
>   				#size-cells = <0>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 39>;
>   				atmel,fifo-size = <32>;
> -				dmas = <&dma0 AT91_XDMAC_DT_PERID(7)>,
> -					<&dma0 AT91_XDMAC_DT_PERID(8)>;
> -				dma-names = "rx", "tx";
> +				dmas = <&dma0 AT91_XDMAC_DT_PERID(8)>,
> +					<&dma0 AT91_XDMAC_DT_PERID(7)>;
> +				dma-names = "tx", "rx";
>   				status = "disabled";
>   			};
>   		};
> @@ -786,9 +786,9 @@ i2c8: i2c@600 {
>   				#size-cells = <0>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 46>;
>   				atmel,fifo-size = <32>;
> -				dmas = <&dma0 AT91_XDMAC_DT_PERID(21)>,
> -					<&dma0 AT91_XDMAC_DT_PERID(22)>;
> -				dma-names = "rx", "tx";
> +				dmas = <&dma0 AT91_XDMAC_DT_PERID(22)>,
> +					<&dma0 AT91_XDMAC_DT_PERID(21)>;
> +				dma-names = "tx", "rx";
>   				status = "disabled";
>   			};
>   		};
> @@ -810,9 +810,9 @@ i2c9: i2c@600 {
>   				#size-cells = <0>;
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 47>;
>   				atmel,fifo-size = <32>;
> -				dmas = <&dma0 AT91_XDMAC_DT_PERID(23)>,
> -					<&dma0 AT91_XDMAC_DT_PERID(24)>;
> -				dma-names = "rx", "tx";
> +				dmas = <&dma0 AT91_XDMAC_DT_PERID(24)>,
> +					<&dma0 AT91_XDMAC_DT_PERID(23)>;
> +				dma-names = "tx", "rx";
>   				status = "disabled";
>   			};
>   		};


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-13 16:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 11:45 [PATCH v2 0/3] dt-bindings: i2c: convert i2c-at91 to json-schema Sergiu Moga
2022-03-10 11:45 ` Sergiu Moga
2022-03-10 11:45 ` [PATCH v2 1/3] ARM: dts: at91: sama7g5: Swap `rx` and `tx` for `i2c` nodes Sergiu Moga
2022-03-10 11:45   ` Sergiu Moga
2022-04-13 16:36   ` Nicolas Ferre [this message]
2022-04-13 16:36     ` Nicolas Ferre
2022-03-10 11:45 ` [PATCH v2 2/3] dt-bindings: i2c: convert i2c-at91 to json-schema Sergiu Moga
2022-03-10 11:45   ` Sergiu Moga
2022-03-10 23:26   ` Rob Herring
2022-03-10 23:26     ` Rob Herring
2022-03-10 11:45 ` [PATCH v2 3/3] dt-bindings: i2c: at91: Add SAMA7G5 compatible strings list Sergiu Moga
2022-03-10 11:45   ` Sergiu Moga
2022-03-10 23:26   ` Rob Herring
2022-03-10 23:26     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=703ee79c-3b25-5b1f-dfe1-bfafade468fd@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sergiu.moga@microchip.com \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.