From: Alexey Kardashevskiy <aik@amd.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Shivaprasad G Bhat <sbhat@linux.ibm.com>
Cc: kvm@vger.kernel.org, aik@ozlabs.ru, linux-kernel@vger.kernel.org,
oohall@gmail.com, ruscur@russell.cc, brking@linux.vnet.ibm.com,
robh@kernel.org, svaidy@linux.ibm.com, aneesh.kumar@kernel.org,
joel@jms.id.au, naveen.n.rao@linux.ibm.com, msuchanek@suse.de,
jroedel@suse.de, gbatra@linux.vnet.ibm.com, npiggin@gmail.com,
alex.williamson@redhat.com, mahesh@linux.ibm.com,
tpearson@raptorengineering.com, vaibhav@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH v2 0/6] powerpc: pSeries: vfio: iommu: Re-enable support for SPAPR TCE VFIO
Date: Thu, 2 May 2024 11:29:04 +1000 [thread overview]
Message-ID: <703f15b0-d895-4518-9886-0827a6c4e769@amd.com> (raw)
In-Reply-To: <20240501140942.GA1723318@ziepe.ca>
On 2/5/24 00:09, Jason Gunthorpe wrote:
> On Tue, Apr 30, 2024 at 03:05:34PM -0500, Shivaprasad G Bhat wrote:
>> RFC v1 was posted here [1]. As I was testing more and fixing the
>> issues, I realized its clean to have the table_group_ops implemented
>> the way it is done on PowerNV and stop 'borrowing' the DMA windows
>> for pSeries.
>>
>> This patch-set implements the iommu table_group_ops for pSeries for
>> VFIO SPAPR TCE sub-driver thereby enabling the VFIO support on POWER
>> pSeries machines.
>
> Wait, did they previously not have any support?
>
> Again, this TCE stuff needs to go away, not grow. I can grudgingly
> accept fixing it where it used to work, but not enabling more HW that
> never worked before! :(
This used to work when I tried last time 2+ years ago, not a new stuff.
Thanks,
--
Alexey
WARNING: multiple messages have this Message-ID (diff)
From: Alexey Kardashevskiy <aik@amd.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Shivaprasad G Bhat <sbhat@linux.ibm.com>
Cc: mpe@ellerman.id.au, tpearson@raptorengineering.com,
alex.williamson@redhat.com, linuxppc-dev@lists.ozlabs.org,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com,
gbatra@linux.vnet.ibm.com, brking@linux.vnet.ibm.com,
aik@ozlabs.ru, ruscur@russell.cc, robh@kernel.org,
linux-kernel@vger.kernel.org, joel@jms.id.au,
kvm@vger.kernel.org, msuchanek@suse.de, oohall@gmail.com,
mahesh@linux.ibm.com, jroedel@suse.de, vaibhav@linux.ibm.com,
svaidy@linux.ibm.com
Subject: Re: [RFC PATCH v2 0/6] powerpc: pSeries: vfio: iommu: Re-enable support for SPAPR TCE VFIO
Date: Thu, 2 May 2024 11:29:04 +1000 [thread overview]
Message-ID: <703f15b0-d895-4518-9886-0827a6c4e769@amd.com> (raw)
In-Reply-To: <20240501140942.GA1723318@ziepe.ca>
On 2/5/24 00:09, Jason Gunthorpe wrote:
> On Tue, Apr 30, 2024 at 03:05:34PM -0500, Shivaprasad G Bhat wrote:
>> RFC v1 was posted here [1]. As I was testing more and fixing the
>> issues, I realized its clean to have the table_group_ops implemented
>> the way it is done on PowerNV and stop 'borrowing' the DMA windows
>> for pSeries.
>>
>> This patch-set implements the iommu table_group_ops for pSeries for
>> VFIO SPAPR TCE sub-driver thereby enabling the VFIO support on POWER
>> pSeries machines.
>
> Wait, did they previously not have any support?
>
> Again, this TCE stuff needs to go away, not grow. I can grudgingly
> accept fixing it where it used to work, but not enabling more HW that
> never worked before! :(
This used to work when I tried last time 2+ years ago, not a new stuff.
Thanks,
--
Alexey
next prev parent reply other threads:[~2024-05-02 5:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 20:05 [RFC PATCH v2 0/6] powerpc: pSeries: vfio: iommu: Re-enable support for SPAPR TCE VFIO Shivaprasad G Bhat
2024-04-30 20:05 ` Shivaprasad G Bhat
2024-04-30 20:05 ` [RFC PATCH v2 1/6] powerpc/iommu: Move pSeries specific functions to pseries/iommu.c Shivaprasad G Bhat
2024-04-30 20:05 ` Shivaprasad G Bhat
2024-04-30 20:06 ` [RFC PATCH v2 2/6] powerpc/pseries/iommu: Fix the VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl output Shivaprasad G Bhat
2024-04-30 20:06 ` Shivaprasad G Bhat
2024-04-30 20:06 ` [RFC PATCH v2 3/6] powerpc/pseries/iommu: Use the iommu table[0] for IOV VF's DDW Shivaprasad G Bhat
2024-04-30 20:06 ` Shivaprasad G Bhat
2024-04-30 20:06 ` [RFC PATCH v2 4/6] vfio/spapr: Always clear TCEs before unsetting the window Shivaprasad G Bhat
2024-04-30 20:06 ` Shivaprasad G Bhat
2024-04-30 20:06 ` [RFC PATCH v2 5/6] powerpc/iommu: Move dev_has_iommu_table() to iommu.c Shivaprasad G Bhat
2024-04-30 20:06 ` Shivaprasad G Bhat
2024-04-30 20:06 ` [RFC PATCH v2 6/6] powerpc/iommu: Implement the iommu_table_group_ops for pSeries Shivaprasad G Bhat
2024-04-30 20:06 ` Shivaprasad G Bhat
2024-05-01 14:09 ` [RFC PATCH v2 0/6] powerpc: pSeries: vfio: iommu: Re-enable support for SPAPR TCE VFIO Jason Gunthorpe
2024-05-01 14:09 ` Jason Gunthorpe
2024-05-02 1:29 ` Alexey Kardashevskiy [this message]
2024-05-02 1:29 ` Alexey Kardashevskiy
2024-05-03 19:03 ` Shivaprasad G Bhat
2024-05-03 19:03 ` Shivaprasad G Bhat
2024-05-06 17:43 ` Jason Gunthorpe
2024-05-06 17:43 ` Jason Gunthorpe
2024-05-07 15:10 ` Shivaprasad G Bhat
2024-05-07 15:10 ` Shivaprasad G Bhat
2024-05-10 18:33 ` Shawn Anastasio
2024-05-10 18:33 ` Shawn Anastasio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703f15b0-d895-4518-9886-0827a6c4e769@amd.com \
--to=aik@amd.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=aneesh.kumar@kernel.org \
--cc=brking@linux.vnet.ibm.com \
--cc=gbatra@linux.vnet.ibm.com \
--cc=jgg@ziepe.ca \
--cc=joel@jms.id.au \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=msuchanek@suse.de \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=robh@kernel.org \
--cc=ruscur@russell.cc \
--cc=sbhat@linux.ibm.com \
--cc=svaidy@linux.ibm.com \
--cc=tpearson@raptorengineering.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.