From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: ksummit-discuss@lists.linuxfoundation.org
Cc: Carlos O'Donell <carlos@redhat.com>,
linux-api@vger.kernel.org,
Thorsten Leemhuis <linux@leemhuis.info>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Thu, 06 Jul 2017 14:34:38 +0300 [thread overview]
Message-ID: <7042009.5tkGy6PEBL@avalon> (raw)
In-Reply-To: <20170705121000.5430d7d0@gandalf.local.home>
On Wednesday 05 Jul 2017 12:10:00 Steven Rostedt wrote:
> On Wed, 5 Jul 2017 11:08:48 -0400 Carlos O'Donell wrote:
> > On 07/05/2017 10:33 AM, Steven Rostedt wrote:
> > > No test should be written for a single specific hardware. It should be a
> > > general functionality that different hardware can execute.
> >
> > Why? We test all sorts of hardware in userspace and we see value in that
> > testing.
>
> One reason is for bit rot. I'm not totally against it. But I envision
> that if we have hundreds of tests for very specific pieces of hardware,
> it's value will diminish over time. Unless we can get a good
> infrastructure written where the hardware info is more of a data sheet
> then a single test itself.
That's all nice, but when the hardware is complex and not fully abstracted
behind a kernel API, tests are bound to be hardware-specific. Of course, a bug
or regression observed only with a specific device, but triggered through the
usage of abstract APIs only, can lead to a test case written for that device
but runnable with any device in the same category. In that case the test case
should certainly be added to a test suite for the corresponding API/subsystem,
not to an hidden test suite for a particular device.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: ksummit-discuss-cunTk1MwBs98uUxBSJOaYoYkZiVZrdSR2LY78lusg7I@public.gmane.org
Cc: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
Carlos O'Donell <carlos-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Thorsten Leemhuis <linux-rCxcAJFjeRkk+I/owrrOrA@public.gmane.org>,
Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking
Date: Thu, 06 Jul 2017 14:34:38 +0300 [thread overview]
Message-ID: <7042009.5tkGy6PEBL@avalon> (raw)
In-Reply-To: <20170705121000.5430d7d0-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
On Wednesday 05 Jul 2017 12:10:00 Steven Rostedt wrote:
> On Wed, 5 Jul 2017 11:08:48 -0400 Carlos O'Donell wrote:
> > On 07/05/2017 10:33 AM, Steven Rostedt wrote:
> > > No test should be written for a single specific hardware. It should be a
> > > general functionality that different hardware can execute.
> >
> > Why? We test all sorts of hardware in userspace and we see value in that
> > testing.
>
> One reason is for bit rot. I'm not totally against it. But I envision
> that if we have hundreds of tests for very specific pieces of hardware,
> it's value will diminish over time. Unless we can get a good
> infrastructure written where the hardware info is more of a data sheet
> then a single test itself.
That's all nice, but when the hardware is complex and not fully abstracted
behind a kernel API, tests are bound to be hardware-specific. Of course, a bug
or regression observed only with a specific device, but triggered through the
usage of abstract APIs only, can lead to a test case written for that device
but runnable with any device in the same category. In that case the test case
should certainly be added to a test suite for the corresponding API/subsystem,
not to an hidden test suite for a particular device.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-07-06 11:34 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-02 17:51 [Ksummit-discuss] [MAINTAINERS SUMMIT] & [TECH TOPIC] Improve regression tracking Thorsten Leemhuis
2017-07-03 16:30 ` Steven Rostedt
2017-07-03 16:30 ` Steven Rostedt
2017-07-03 18:50 ` Dan Williams
2017-07-03 18:50 ` Dan Williams
2017-07-04 19:03 ` Thorsten Leemhuis
2017-07-04 19:03 ` Thorsten Leemhuis
2017-07-05 12:45 ` Steven Rostedt
2017-07-05 12:45 ` Steven Rostedt
2017-07-05 13:09 ` Carlos O'Donell
2017-07-05 13:09 ` Carlos O'Donell
2017-07-05 13:27 ` Steven Rostedt
2017-07-05 13:27 ` Steven Rostedt
2017-07-05 14:06 ` Greg KH
2017-07-05 14:06 ` Greg KH
2017-07-05 14:28 ` Carlos O'Donell
2017-07-05 14:28 ` Carlos O'Donell
2017-07-05 14:33 ` Steven Rostedt
2017-07-05 14:33 ` Steven Rostedt
2017-07-05 14:52 ` Mark Brown
2017-07-05 14:52 ` Mark Brown
2017-07-05 15:08 ` Carlos O'Donell
2017-07-05 15:08 ` Carlos O'Donell
2017-07-05 16:10 ` Steven Rostedt
2017-07-05 16:10 ` Steven Rostedt
2017-07-06 11:34 ` Laurent Pinchart [this message]
2017-07-06 11:34 ` Laurent Pinchart
2017-07-09 13:46 ` Thorsten Leemhuis
2017-07-09 13:46 ` Thorsten Leemhuis
2017-07-05 14:33 ` Mark Brown
2017-07-05 14:33 ` Mark Brown
2017-07-05 14:36 ` Steven Rostedt
2017-07-05 14:36 ` Steven Rostedt
2017-07-05 14:50 ` James Bottomley
2017-07-05 14:50 ` James Bottomley
2017-07-05 14:56 ` Steven Rostedt
2017-07-05 14:56 ` Steven Rostedt
2017-07-05 15:09 ` James Bottomley
2017-07-05 15:09 ` James Bottomley
2017-07-05 15:20 ` Mark Brown
2017-07-05 15:20 ` Mark Brown
2017-07-05 15:40 ` Geert Uytterhoeven
2017-07-05 15:40 ` Geert Uytterhoeven
2017-07-05 15:20 ` Steven Rostedt
2017-07-05 15:20 ` Steven Rostedt
2017-07-05 15:32 ` James Bottomley
2017-07-05 15:32 ` James Bottomley
2017-07-05 15:43 ` Steven Rostedt
2017-07-05 15:43 ` Steven Rostedt
2017-07-05 18:24 ` Daniel Vetter
2017-07-05 18:24 ` Daniel Vetter
2017-07-05 18:17 ` Daniel Vetter
2017-07-05 18:17 ` Daniel Vetter
2017-07-05 15:16 ` Guenter Roeck
2017-07-05 15:16 ` Guenter Roeck
2017-07-05 15:27 ` Steven Rostedt
2017-07-05 15:27 ` Steven Rostedt
2017-07-05 15:36 ` James Bottomley
2017-07-05 15:36 ` James Bottomley
2017-07-05 16:04 ` Steven Rostedt
2017-07-05 16:04 ` Steven Rostedt
2017-07-05 16:58 ` James Bottomley
2017-07-05 16:58 ` James Bottomley
2017-07-05 17:07 ` Steven Rostedt
2017-07-05 17:07 ` Steven Rostedt
2017-07-05 16:48 ` Guenter Roeck
2017-07-05 16:48 ` Guenter Roeck
2017-07-05 16:58 ` Dan Williams
2017-07-05 16:58 ` Dan Williams
2017-07-05 17:02 ` Steven Rostedt
2017-07-05 17:02 ` Steven Rostedt
2017-07-06 9:28 ` Mark Brown
2017-07-06 9:28 ` Mark Brown
2017-07-06 9:41 ` Daniel Vetter
2017-07-06 9:41 ` Daniel Vetter
2017-07-06 14:53 ` Theodore Ts'o
2017-07-06 14:53 ` Theodore Ts'o
2017-07-06 21:28 ` Daniel Vetter
2017-07-06 21:28 ` Daniel Vetter
2017-07-06 14:48 ` James Bottomley
2017-07-06 14:48 ` James Bottomley
2017-07-07 10:03 ` Mark Brown
2017-07-07 10:03 ` Mark Brown
2017-07-31 16:54 ` Eric W. Biederman
2017-07-31 16:54 ` Eric W. Biederman
2017-07-31 20:11 ` Steven Rostedt
2017-07-31 20:11 ` Steven Rostedt
2017-07-31 20:12 ` Eric W. Biederman
2017-07-31 20:12 ` Eric W. Biederman
2017-08-02 16:53 ` Shuah Khan
2017-08-02 16:53 ` Shuah Khan
2017-08-02 17:33 ` Eric W. Biederman
2017-08-02 17:33 ` Eric W. Biederman
2017-08-02 17:46 ` Shuah Khan
2017-08-02 17:46 ` Shuah Khan
2017-08-02 17:58 ` Shuah Khan
2017-08-02 17:58 ` Shuah Khan
2017-08-02 18:04 ` Eric W. Biederman
2017-08-02 18:04 ` Eric W. Biederman
2017-08-02 18:23 ` Randy Dunlap
2017-08-02 18:23 ` Randy Dunlap
2017-08-02 18:42 ` Shuah Khan
2017-08-02 18:42 ` Shuah Khan
2017-08-03 3:03 ` Theodore Ts'o
2017-08-03 3:03 ` Theodore Ts'o
2017-08-03 17:42 ` Bird, Timothy
2017-08-03 17:42 ` Bird, Timothy
2017-08-03 22:11 ` Shuah Khan
2017-08-03 22:11 ` Shuah Khan
2017-08-03 18:51 ` Shuah Khan
2017-08-03 18:51 ` Shuah Khan
2017-08-04 1:15 ` Theodore Ts'o
2017-08-04 1:15 ` Theodore Ts'o
2017-07-07 3:33 ` Fengguang Wu
2017-07-07 3:33 ` Fengguang Wu
2017-07-07 4:52 ` Frank Rowand
2017-07-07 4:52 ` Frank Rowand
2017-07-05 15:32 ` Greg KH
2017-07-05 15:32 ` Greg KH
2017-07-05 15:36 ` Carlos O'Donell
2017-07-05 15:36 ` Carlos O'Donell
2017-07-05 15:52 ` Steven Rostedt
2017-07-05 15:52 ` Steven Rostedt
2017-07-05 18:42 ` Greg KH
2017-07-05 18:42 ` Greg KH
2017-07-05 18:29 ` Daniel Vetter
2017-07-05 18:29 ` Daniel Vetter
2017-07-06 22:24 ` Shuah Khan
2017-07-06 22:24 ` Shuah Khan
2017-07-06 22:32 ` Steven Rostedt
2017-07-06 22:32 ` Steven Rostedt
2017-07-06 22:40 ` Shuah Khan
2017-07-06 22:40 ` Shuah Khan
2017-07-05 16:54 ` Dan Williams
2017-07-05 16:54 ` Dan Williams
2017-07-05 18:45 ` Greg KH
2017-07-05 18:45 ` Greg KH
2017-07-05 19:47 ` Dan Williams
2017-07-05 19:47 ` Dan Williams
2017-07-05 14:06 ` Carlos O'Donell
2017-07-05 14:06 ` Carlos O'Donell
2017-07-05 15:47 ` Mark Brown
2017-07-05 15:47 ` Mark Brown
2017-07-07 6:15 ` Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7042009.5tkGy6PEBL@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=carlos@redhat.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.