All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: patrice.chotard@foss.st.com, Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Jerome Audu <jerome.audu@st.com>
Subject: Re: [PATCH] usb: dwc3: st: Fix node's child name
Date: Mon, 26 Sep 2022 15:52:26 +0200	[thread overview]
Message-ID: <704b3687-d102-711a-0686-833ddc95b77f@kernel.org> (raw)
In-Reply-To: <20220926124359.304770-1-patrice.chotard@foss.st.com>

On 26/09/2022 14:43, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Update node's child name from "dwc3" to "usb", this fixes
> the following issue:
> 
> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
> 
> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
> 
> Reported-by: Jerome Audu <jerome.audu@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>  drivers/usb/dwc3/dwc3-st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 166b5bde45cb..6c14a79279f9 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>  	/* Manage SoftReset */
>  	reset_control_deassert(dwc3_data->rstc_rst);
>  
> -	child = of_get_child_by_name(node, "dwc3");
> +	child = of_get_child_by_name(node, "usb");

While this is a ok, the proper fix is not to rely on any other device
nodes or document it in the bindings.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: patrice.chotard@foss.st.com, Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Jerome Audu <jerome.audu@st.com>
Subject: Re: [PATCH] usb: dwc3: st: Fix node's child name
Date: Mon, 26 Sep 2022 15:52:26 +0200	[thread overview]
Message-ID: <704b3687-d102-711a-0686-833ddc95b77f@kernel.org> (raw)
In-Reply-To: <20220926124359.304770-1-patrice.chotard@foss.st.com>

On 26/09/2022 14:43, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Update node's child name from "dwc3" to "usb", this fixes
> the following issue:
> 
> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
> 
> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
> 
> Reported-by: Jerome Audu <jerome.audu@st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>  drivers/usb/dwc3/dwc3-st.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 166b5bde45cb..6c14a79279f9 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>  	/* Manage SoftReset */
>  	reset_control_deassert(dwc3_data->rstc_rst);
>  
> -	child = of_get_child_by_name(node, "dwc3");
> +	child = of_get_child_by_name(node, "usb");

While this is a ok, the proper fix is not to rely on any other device
nodes or document it in the bindings.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-26 15:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 12:43 [PATCH] usb: dwc3: st: Fix node's child name patrice.chotard
2022-09-26 12:43 ` patrice.chotard
2022-09-26 13:52 ` Krzysztof Kozlowski [this message]
2022-09-26 13:52   ` Krzysztof Kozlowski
2022-09-27 15:15 ` Felipe Balbi
2022-09-27 15:15   ` Felipe Balbi
2022-09-28  6:45   ` Patrice CHOTARD
2022-09-28  6:45     ` Patrice CHOTARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=704b3687-d102-711a-0686-833ddc95b77f@kernel.org \
    --to=krzk@kernel.org \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jerome.audu@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=patrice.chotard@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.