All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: dts: exynos: added mailbox node
Date: Thu, 20 Mar 2014 17:12:46 +0100	[thread overview]
Message-ID: <7073716.9YBOcHOu36@wuerfel> (raw)
In-Reply-To: <CABb+yY1rvozkGS34CHt8YEJqvGRXuHV09=AdS3=zQBx=DjFDCQ@mail.gmail.com>

On Thursday 20 March 2014 21:39:56 Jassi Brar wrote:
> On Wed, Mar 19, 2014 at 11:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 17 March 2014, Jassi Brar wrote:
> 
> >>   Perhaps the mailbox controller driver should name its links as it
> >> wants. By how the remote works with the mailbox links, the client
> >> driver asks for a specific mailbox link (which maybe a hardcoded
> >> string in the driver or be gotten alongside other data via client's
> >> DT) ?
> >
> > I don't see why we should do it any different from the other bindings.
> > Let's just stick with mboxes/mbox-names or mailboxes/mailbox-names
> > if you prefer.
> >
> >>   IOW we can't have a generic API/DT-bindings that could get us
> >> reusable client drivers. But only common framework/code that would
> >> otherwise be duplicated by every platform.
> >
> > That is a major benefit though.
> > Also even if most drivers won't work across multiple platforms, there
> > is still a reasonable chance that /some/ drivers will.
> >
> It seems those /some/ drivers will have to work with everything same
> but the channel name (which the client could get from its DT node when
> the second platform appears).

Why would you ever have varying channel names? I would expect that
the name is always fixed in the binding of the client driver, like
we do for clocks or interrupts for instance.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Girish K S <ks.giri@samsung.com>,
	devicetree@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Suman Anna <s-anna@ti.com>, Ilho Lee <ilho215.lee@samsung.com>
Subject: Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node
Date: Thu, 20 Mar 2014 17:12:46 +0100	[thread overview]
Message-ID: <7073716.9YBOcHOu36@wuerfel> (raw)
In-Reply-To: <CABb+yY1rvozkGS34CHt8YEJqvGRXuHV09=AdS3=zQBx=DjFDCQ@mail.gmail.com>

On Thursday 20 March 2014 21:39:56 Jassi Brar wrote:
> On Wed, Mar 19, 2014 at 11:16 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 17 March 2014, Jassi Brar wrote:
> 
> >>   Perhaps the mailbox controller driver should name its links as it
> >> wants. By how the remote works with the mailbox links, the client
> >> driver asks for a specific mailbox link (which maybe a hardcoded
> >> string in the driver or be gotten alongside other data via client's
> >> DT) ?
> >
> > I don't see why we should do it any different from the other bindings.
> > Let's just stick with mboxes/mbox-names or mailboxes/mailbox-names
> > if you prefer.
> >
> >>   IOW we can't have a generic API/DT-bindings that could get us
> >> reusable client drivers. But only common framework/code that would
> >> otherwise be duplicated by every platform.
> >
> > That is a major benefit though.
> > Also even if most drivers won't work across multiple platforms, there
> > is still a reasonable chance that /some/ drivers will.
> >
> It seems those /some/ drivers will have to work with everything same
> but the channel name (which the client could get from its DT node when
> the second platform appears).

Why would you ever have varying channel names? I would expect that
the name is always fixed in the binding of the client driver, like
we do for clocks or interrupts for instance.

	Arnd

  reply	other threads:[~2014-03-20 16:12 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17 12:03 [PATCH 0/2] Support for samsung mailbox controller Girish K S
2014-03-17 12:03 ` Girish K S
2014-03-17 12:03 ` Girish K S
2014-03-17 12:03 ` [PATCH 1/2] mailbox: samsung: added support for samsung mailbox Girish K S
2014-03-17 12:03   ` Girish K S
2014-03-17 12:03   ` Girish K S
2014-03-18 10:22   ` Girish KS
2014-03-18 10:22     ` Girish KS
2014-03-18 10:22     ` Girish KS
2014-03-18 10:56     ` Joe Perches
2014-03-18 10:56       ` Joe Perches
2014-03-18 10:56       ` Joe Perches
2014-03-19  3:49       ` Girish KS
2014-03-19  3:49         ` Girish KS
2014-03-19  3:49         ` Girish KS
2014-03-17 12:03 ` [PATCH 2/2] arm64: dts: exynos: added mailbox node Girish K S
2014-03-17 12:03   ` Girish K S
2014-03-17 12:03   ` Girish K S
2014-03-17 12:08   ` Girish KS
2014-03-17 12:08     ` Girish KS
2014-03-17 12:08     ` Girish KS
2014-03-17 12:15   ` Arnd Bergmann
2014-03-17 12:15     ` Arnd Bergmann
2014-03-17 12:15     ` Arnd Bergmann
2014-03-17 14:58     ` Jassi Brar
2014-03-17 14:58       ` Jassi Brar
2014-03-17 14:58       ` Jassi Brar
2014-03-19 17:46       ` Arnd Bergmann
2014-03-19 17:46         ` Arnd Bergmann
2014-03-19 17:46         ` Arnd Bergmann
2014-03-20 16:09         ` Jassi Brar
2014-03-20 16:09           ` Jassi Brar
2014-03-20 16:09           ` Jassi Brar
2014-03-20 16:12           ` Arnd Bergmann [this message]
2014-03-20 16:12             ` Arnd Bergmann
2014-03-20 16:31             ` Jassi Brar
2014-03-20 16:31               ` Jassi Brar
2014-03-20 16:31               ` Jassi Brar
2014-03-17 14:06   ` Mark Rutland
2014-03-17 14:06     ` Mark Rutland
2014-03-17 14:06     ` Mark Rutland
2014-03-19  4:06     ` Girish KS
2014-03-19  4:06       ` Girish KS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7073716.9YBOcHOu36@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.