From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Shivank Garg <shivankg@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
Zi Yan <ziy@nvidia.com>, Matthew Brost <matthew.brost@intel.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>,
Gregory Price <gourry@gourry.net>,
Ying Huang <ying.huang@linux.alibaba.com>,
Alistair Popple <apopple@nvidia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/migrate: rename PAGE_ migration flags to FOLIO_MF_
Date: Mon, 23 Mar 2026 20:21:07 +0100 [thread overview]
Message-ID: <7095112e-465d-49bf-9cbd-98e6e6ad2aa0@kernel.org> (raw)
In-Reply-To: <acGNG1T-4UBdvgYB@casper.infradead.org>
On 3/23/26 19:57, Matthew Wilcox wrote:
> On Mon, Mar 23, 2026 at 04:36:38PM +0100, David Hildenbrand (Arm) wrote:
>> On 3/23/26 15:46, Matthew Wilcox wrote:
>>>
>>> I mean, this doesn't make sense any more. PAGE_WAS_MLOCKED is a
>>> sentence that means something. FOLIO_MF_WAS_MLOCKED doesn't ... unless
>>> you imagine Samuel L Jackson saying it ...
>>
>> :)
>>
>> PAGE_WAS_MLOCKED was suboptimal given that the names overlap with things
>> like PAGE_SHARED or even PAGE_IS_PRESENT.
>
> PAGE_SHARED (and friends) are misnamed because really they're PTE flags,
> not page flags. Then PAGE_IS_* form a namespace for pagemap, which I
> think is fine. These are PAGE_WAS, so a distinct namespace already.
>
>> So using some prefix to indicate that these flag belong logically
>> together makes sense. Even if it's not a beautiful sentence.
>
> FOLIO_WAS_ seems like a fine namespace. Especially since it's local to
> this file.
Right, given that it's local to the file that's ok.
--
Cheers,
David
next prev parent reply other threads:[~2026-03-23 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 14:19 [PATCH] mm/migrate: rename PAGE_ migration flags to FOLIO_MF_ Shivank Garg
2026-03-23 14:46 ` Matthew Wilcox
2026-03-23 15:36 ` David Hildenbrand (Arm)
2026-03-23 18:57 ` Matthew Wilcox
2026-03-23 19:21 ` David Hildenbrand (Arm) [this message]
2026-03-24 5:04 ` Garg, Shivank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7095112e-465d-49bf-9cbd-98e6e6ad2aa0@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=byungchul@sk.com \
--cc=gourry@gourry.net \
--cc=joshua.hahnjy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=rakie.kim@sk.com \
--cc=shivankg@amd.com \
--cc=willy@infradead.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.