All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Shivank Garg <shivankg@amd.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>, Zi Yan <ziy@nvidia.com>,
	Matthew Brost <matthew.brost@intel.com>,
	Joshua Hahn <joshua.hahnjy@gmail.com>,
	Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>,
	Gregory Price <gourry@gourry.net>,
	Ying Huang <ying.huang@linux.alibaba.com>,
	Alistair Popple <apopple@nvidia.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/migrate: rename PAGE_ migration flags to FOLIO_MF_
Date: Mon, 23 Mar 2026 14:46:38 +0000	[thread overview]
Message-ID: <acFSTlF0epHIrA5v@casper.infradead.org> (raw)
In-Reply-To: <20260323141935.389232-3-shivankg@amd.com>

On Mon, Mar 23, 2026 at 02:19:37PM +0000, Shivank Garg wrote:
> +++ b/mm/migrate.c
> @@ -1135,26 +1135,26 @@ static int move_to_new_folio(struct folio *dst, struct folio *src,
>   * This is safe because nobody is using it except us.
>   */
>  enum {
> -	PAGE_WAS_MAPPED = BIT(0),
> -	PAGE_WAS_MLOCKED = BIT(1),
> -	PAGE_OLD_STATES = PAGE_WAS_MAPPED | PAGE_WAS_MLOCKED,
> +	FOLIO_MF_WAS_MAPPED = BIT(0),
> +	FOLIO_MF_WAS_MLOCKED = BIT(1),
> +	FOLIO_MF_OLD_STATES = FOLIO_MF_WAS_MAPPED | FOLIO_MF_WAS_MLOCKED,

what does 'MF' stand for?  i mean, presumably not the pop culture
meaning of MF ...

>  	locked = true;
>  	if (folio_test_mlocked(src))
> -		old_page_state |= PAGE_WAS_MLOCKED;
> +		old_folio_state |= FOLIO_MF_WAS_MLOCKED;

I mean, this doesn't make sense any more.  PAGE_WAS_MLOCKED is a
sentence that means something.  FOLIO_MF_WAS_MLOCKED doesn't ... unless
you imagine Samuel L Jackson saying it ...



  reply	other threads:[~2026-03-23 14:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 14:19 [PATCH] mm/migrate: rename PAGE_ migration flags to FOLIO_MF_ Shivank Garg
2026-03-23 14:46 ` Matthew Wilcox [this message]
2026-03-23 15:36   ` David Hildenbrand (Arm)
2026-03-23 18:57     ` Matthew Wilcox
2026-03-23 19:21       ` David Hildenbrand (Arm)
2026-03-24  5:04         ` Garg, Shivank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acFSTlF0epHIrA5v@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=byungchul@sk.com \
    --cc=david@kernel.org \
    --cc=gourry@gourry.net \
    --cc=joshua.hahnjy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew.brost@intel.com \
    --cc=rakie.kim@sk.com \
    --cc=shivankg@amd.com \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.