Re: [PATCH 1/3] drm/pcids: Split PTL pciids group to make wcl subplatform

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 12 Sep 2025, Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> wrote:
> To form the WCL platform as a subplatform of PTL in definition,
> WCL pci ids are splited into saparate group from PTL.
> So update the pciidlist struct to cover all the pci ids.

This stops wcl from being identified by display driver. You need to add
INTEL_WCL_IDS to intel_display_ids as well.

It's a good idea to use a code tagging tool such as cscope or gnu
global, and check the references to the symbols you're changing.

> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 1 +
>  include/drm/intel/pciids.h  | 4 +++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 701ba9baa9d7..fc2ea9132804 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -375,6 +375,7 @@ static const struct pci_device_id pciidlist[] = {
>  	INTEL_LNL_IDS(INTEL_VGA_DEVICE, &lnl_desc),
>  	INTEL_BMG_IDS(INTEL_VGA_DEVICE, &bmg_desc),
>  	INTEL_PTL_IDS(INTEL_VGA_DEVICE, &ptl_desc),
> +	INTEL_WCL_IDS(INTEL_VGA_DEVICE, &ptl_desc),
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(pci, pciidlist);
> diff --git a/include/drm/intel/pciids.h b/include/drm/intel/pciids.h
> index da6301a6fcea..9d378c65be4b 100644
> --- a/include/drm/intel/pciids.h
> +++ b/include/drm/intel/pciids.h
> @@ -877,7 +877,9 @@
>  	MACRO__(0xB08F, ## __VA_ARGS__), \
>  	MACRO__(0xB090, ## __VA_ARGS__), \
>  	MACRO__(0xB0A0, ## __VA_ARGS__), \
> -	MACRO__(0xB0B0, ## __VA_ARGS__), \
> +	MACRO__(0xB0B0, ## __VA_ARGS__)
> +

Please add comment

/* WCL */

here, see all the above recent groups of macros.

> +#define INTEL_WCL_IDS(MACRO__, ...) \
>  	MACRO__(0xFD80, ## __VA_ARGS__), \
>  	MACRO__(0xFD81, ## __VA_ARGS__)

-- 
Jani Nikula, Intel