Re: [PATCH 2/3] drm/i915/display: Add definition for wcl as subplatform

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 12 Sep 2025, Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> wrote:
> Update the device definition structs for adding wildcat lake as
> subplatfrom of pantherlake.
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_device.c | 13 +++++++++++++
>  drivers/gpu/drm/i915/display/intel_display_device.h |  4 +++-
>  2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.c b/drivers/gpu/drm/i915/display/intel_display_device.c
> index 65f0efc35bb7..1b9c921290e1 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.c
> @@ -1379,6 +1379,11 @@ static const u16 mtl_u_ids[] = {
>  	0
>  };
>  
> +static const u16 wcl_ids[] = {
> +	INTEL_WCL_IDS(ID),
> +	0
> +};
> +
>  /*
>   * Do not initialize the .info member of the platform desc for GMD ID based
>   * platforms. Their display will be probed automatically based on the IP version
> @@ -1406,6 +1411,13 @@ static const struct platform_desc bmg_desc = {
>  
>  static const struct platform_desc ptl_desc = {
>  	PLATFORM(pantherlake),
> +	.subplatforms = (const struct subplatform_desc[]) {
> +		{
> +			SUBPLATFORM(pantherlake, wildcatlake),
> +			.pciidlist = wcl_ids,
> +		},
> +		{},
> +	}
>  };
>  
>  __diag_pop();
> @@ -1482,6 +1494,7 @@ static const struct {
>  	INTEL_LNL_IDS(INTEL_DISPLAY_DEVICE, &lnl_desc),
>  	INTEL_BMG_IDS(INTEL_DISPLAY_DEVICE, &bmg_desc),
>  	INTEL_PTL_IDS(INTEL_DISPLAY_DEVICE, &ptl_desc),
> +	INTEL_WCL_IDS(INTEL_DISPLAY_DEVICE, &ptl_desc),

Right, so this part belongs in the previous patch. Otherwise the series
breaks bisect.

>  };
>  
>  static const struct {
> diff --git a/drivers/gpu/drm/i915/display/intel_display_device.h b/drivers/gpu/drm/i915/display/intel_display_device.h
> index 6e87b763fe7c..dcc010caa423 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_device.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_device.h
> @@ -101,7 +101,9 @@ struct pci_dev;
>  	/* Display ver 14.1 (based on GMD ID) */ \
>  	func(battlemage) \
>  	/* Display ver 30 (based on GMD ID) */ \
> -	func(pantherlake)
> +	func(pantherlake) \
> +	func(pantherlake_wildcatlake)
> +
>  
>  #define __MEMBER(name) unsigned long name:1;
>  #define __COUNT(x) 1 +

-- 
Jani Nikula, Intel