From: Artur Weber <aweber.kernel@gmail.com>
To: Henrik Grimler <henrik@grimler.se>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Russell King <linux@armlinux.org.uk>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Kukjin Kim <kgene@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-media@vger.kernel.org,
linux-phy@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 03/12] ARM: exynos: Re-introduce Exynos4212 support
Date: Sat, 29 Apr 2023 17:55:40 +0200 [thread overview]
Message-ID: <712cd0a7-fdb9-059a-90b7-5c3b6a08fd5b@gmail.com> (raw)
In-Reply-To: <ZEBN8ImTp/tRdej+@L14.lan>
On 19/04/2023 22:24, Henrik Grimler wrote:
>> /*
>> * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
>> + * But, Exynos4212 has only one secondary CPU so second parameter
>> + * isn't used for informing secure firmware about CPU id.
>> */
>> + if (soc_is_exynos4212())
>> + cpu = 0;
>
> Is it necessary to set cpu = 0? Are there any obvious issues without
> it (like second cpu not being brought up)?
Just tested this; looks like it's required here, without it the second
core fails to start up:
[ 0.064277] smp: Bringing up secondary CPUs ...
[ 1.067163] CPU1: failed to boot: -110
[ 1.069683] smp: Brought up 1 node, 1 CPU
[ 1.072470] SMP: Total of 1 processors activated (48.00 BogoMIPS).
SBOOT on my tablet claims the version is T310XXSBQB2, so it should match
with the one you checked.
Best regards
Artur Weber
WARNING: multiple messages have this Message-ID (diff)
From: Artur Weber <aweber.kernel@gmail.com>
To: Henrik Grimler <henrik@grimler.se>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Russell King <linux@armlinux.org.uk>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Kukjin Kim <kgene@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-media@vger.kernel.org,
linux-phy@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 03/12] ARM: exynos: Re-introduce Exynos4212 support
Date: Sat, 29 Apr 2023 17:55:40 +0200 [thread overview]
Message-ID: <712cd0a7-fdb9-059a-90b7-5c3b6a08fd5b@gmail.com> (raw)
In-Reply-To: <ZEBN8ImTp/tRdej+@L14.lan>
On 19/04/2023 22:24, Henrik Grimler wrote:
>> /*
>> * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
>> + * But, Exynos4212 has only one secondary CPU so second parameter
>> + * isn't used for informing secure firmware about CPU id.
>> */
>> + if (soc_is_exynos4212())
>> + cpu = 0;
>
> Is it necessary to set cpu = 0? Are there any obvious issues without
> it (like second cpu not being brought up)?
Just tested this; looks like it's required here, without it the second
core fails to start up:
[ 0.064277] smp: Bringing up secondary CPUs ...
[ 1.067163] CPU1: failed to boot: -110
[ 1.069683] smp: Brought up 1 node, 1 CPU
[ 1.072470] SMP: Total of 1 processors activated (48.00 BogoMIPS).
SBOOT on my tablet claims the version is T310XXSBQB2, so it should match
with the one you checked.
Best regards
Artur Weber
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Artur Weber <aweber.kernel@gmail.com>
To: Henrik Grimler <henrik@grimler.se>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Russell King <linux@armlinux.org.uk>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Kukjin Kim <kgene@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pm@vger.kernel.org, linux-media@vger.kernel.org,
linux-phy@lists.infradead.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 03/12] ARM: exynos: Re-introduce Exynos4212 support
Date: Sat, 29 Apr 2023 17:55:40 +0200 [thread overview]
Message-ID: <712cd0a7-fdb9-059a-90b7-5c3b6a08fd5b@gmail.com> (raw)
In-Reply-To: <ZEBN8ImTp/tRdej+@L14.lan>
On 19/04/2023 22:24, Henrik Grimler wrote:
>> /*
>> * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
>> + * But, Exynos4212 has only one secondary CPU so second parameter
>> + * isn't used for informing secure firmware about CPU id.
>> */
>> + if (soc_is_exynos4212())
>> + cpu = 0;
>
> Is it necessary to set cpu = 0? Are there any obvious issues without
> it (like second cpu not being brought up)?
Just tested this; looks like it's required here, without it the second
core fails to start up:
[ 0.064277] smp: Bringing up secondary CPUs ...
[ 1.067163] CPU1: failed to boot: -110
[ 1.069683] smp: Brought up 1 node, 1 CPU
[ 1.072470] SMP: Total of 1 processors activated (48.00 BogoMIPS).
SBOOT on my tablet claims the version is T310XXSBQB2, so it should match
with the one you checked.
Best regards
Artur Weber
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-29 15:55 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 13:34 [PATCH v2 00/12] Re-introduce Exynos4212 support and add Samsung Galaxy Tab 3 8.0 boards Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` [PATCH v2 01/12] dt-bindings: soc: samsung: add Exynos4212 PMU compatible Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 17:54 ` Krzysztof Kozlowski
2023-04-16 17:54 ` Krzysztof Kozlowski
2023-04-16 17:54 ` Krzysztof Kozlowski
2023-04-16 13:34 ` [PATCH v2 02/12] dt-bindings: clock: add Exynos4212 clock compatible Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 17:55 ` Krzysztof Kozlowski
2023-04-16 17:55 ` Krzysztof Kozlowski
2023-04-16 17:55 ` Krzysztof Kozlowski
2023-04-16 13:34 ` [PATCH v2 03/12] ARM: exynos: Re-introduce Exynos4212 support Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 18:00 ` Krzysztof Kozlowski
2023-04-16 18:00 ` Krzysztof Kozlowski
2023-04-16 18:00 ` Krzysztof Kozlowski
2023-04-19 20:24 ` Henrik Grimler
2023-04-19 20:24 ` Henrik Grimler
2023-04-19 20:24 ` Henrik Grimler
2023-04-29 15:55 ` Artur Weber [this message]
2023-04-29 15:55 ` Artur Weber
2023-04-29 15:55 ` Artur Weber
2023-04-16 13:34 ` [PATCH v2 04/12] soc: samsung: " Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` [PATCH v2 05/12] clk: samsung: Add Exynos4212 compatible to CLKOUT driver Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` [PATCH v2 06/12] clk: samsung: Re-add support for Exynos4212 CPU clock Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` [PATCH v2 07/12] Revert "media: exynos4-is: Remove dependency on obsolete SoC support" Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` [PATCH v2 08/12] Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB" Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 18:06 ` Krzysztof Kozlowski
2023-04-16 18:06 ` Krzysztof Kozlowski
2023-04-16 18:06 ` Krzysztof Kozlowski
2023-04-16 13:34 ` [PATCH v2 09/12] ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 18:08 ` Krzysztof Kozlowski
2023-04-16 18:08 ` Krzysztof Kozlowski
2023-04-16 18:08 ` Krzysztof Kozlowski
2023-04-16 13:34 ` [PATCH v2 10/12] ARM: dts: Re-introduce Exynos4212 DTSI Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 18:10 ` Krzysztof Kozlowski
2023-04-16 18:10 ` Krzysztof Kozlowski
2023-04-16 18:10 ` Krzysztof Kozlowski
2023-04-16 13:34 ` [PATCH v2 11/12] dt-bindings: arm: samsung: Add Samsung Galaxy Tab3 family boards Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 18:11 ` Krzysztof Kozlowski
2023-04-16 18:11 ` Krzysztof Kozlowski
2023-04-16 18:11 ` Krzysztof Kozlowski
2023-04-16 13:34 ` [PATCH v2 12/12] ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 13:34 ` Artur Weber
2023-04-16 18:26 ` Krzysztof Kozlowski
2023-04-16 18:26 ` Krzysztof Kozlowski
2023-04-16 18:26 ` Krzysztof Kozlowski
2023-04-22 13:50 ` Artur Weber
2023-04-22 13:50 ` Artur Weber
2023-04-22 13:50 ` Artur Weber
2023-04-23 8:25 ` Krzysztof Kozlowski
2023-04-23 8:25 ` Krzysztof Kozlowski
2023-04-23 8:25 ` Krzysztof Kozlowski
2023-04-19 20:23 ` Henrik Grimler
2023-04-19 20:23 ` Henrik Grimler
2023-04-19 20:23 ` Henrik Grimler
2023-04-23 12:52 ` Artur Weber
2023-04-23 12:52 ` Artur Weber
2023-04-23 12:52 ` Artur Weber
2023-04-16 14:14 ` [PATCH v2 00/12] Re-introduce Exynos4212 support and add " Krzysztof Kozlowski
2023-04-16 14:14 ` Krzysztof Kozlowski
2023-04-16 14:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=712cd0a7-fdb9-059a-90b7-5c3b6a08fd5b@gmail.com \
--to=aweber.kernel@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=kgene@kernel.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.