Re: [PATCH] [PATCH] tests: Keep grub-fs-tester ziso9660 from failing for wrong reasons

["Thomas Schmitt" <scdbackup@gmx.net>]

Hi,

i am working on the requested changes.

In my patch message i wrote:
> > A bug
> > in xorriso causes a distracting warning about FSLABEL being too long for
> > Joliet. Shortcommings of Joliet cause warnings about symbolic links.

Daniel Kiper wrote:
> s/links./links too./?

Rather not. Both warnings have very different reasons.
The xorriso bug was that the warning came if more than 16 bytes of volume
id are submitted. The correct test is to count the UCS-2 characters after
conversion from the local character set (meanwhile surely UTF-8).
The FSLABEL which is prepared by grub-fs-tester for ISO 9660 tests has
only 15 characters but 32 UTF-8 bytes.
The shortcomming of Joliet is in its specs. It was invented by Microsoft
Inc. for presenting Microsoft filesystem names. At least back in 1995
no symbolic links were desired for their version of ISO 9660. Other than
the xorriso bug i cannot fix this.

Both warnings could deceive the reader of the test report, especially
since the test is expected to fail. Thus my patch disables Joliet to
silence both for all xorriso versions.


> I have an itching to ask you to split this thing into two patches.

I decided against this because the test would indicate false success
after the early failure because of the FSLABEL length is fixed.
If i fix the xorriso command sequence problem first, then this first
patch does not have any effect at run time.

So i rather consider the ziso9660 test as untested sketch which i replace
by a working test with proper failure as long as no zisofs decompression
is implemented.


> You described everything in the commit message what you are doing here
> except of "-set_filter_r --zisofs -- -zisofs default" games. Could you
> explain that too?

Will try without copying a whole paragraph from man xorriso.


Have a nice day :)

Thomas