All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Chevrier <theburner1@yahoo.com>
To: qemu-devel@nongnu.org, Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] LSI53C895A: Do not update current_dma_len with dbc in TIA mode
Date: Wed, 26 Nov 2008 14:37:41 -0800 (PST)	[thread overview]
Message-ID: <714315.59707.qm@web51101.mail.re2.yahoo.com> (raw)
In-Reply-To: <20081126221450.GP31893@us.ibm.com>

Ryan Harper wrote:
> Do you also have SCSI debug on in scsi-disk.c ?  I'd
> really like to see
> the scsi command that was generating the read with lengh
> 69632.
> 
> Actually, have you tried this since the 40 bit DMA patch
> was included?

I'm running head.

The command is a Read:

scsi-disk: Command: lun=0 tag=0x1003b data=0x28 0x00 0x00 0x5a 0x81 0x57 0x00 0x00 0x88 0x00
scsi-disk: Read (sector 5931351, count 136)
scsi-disk: Read sector_count=136

The 69632 is coming from 136 * 512

> Yeah, I think for now, the right thing to do is revert the
> old patch
> until we figure how to handle this correctly for both test
> cases.

This reverts the relevant section of the original patch:

--- hw/lsi53c895a.c     (revision 5799)
+++ hw/lsi53c895a.c     (working copy)
@@ -920,7 +920,6 @@
             break;
         case PHASE_DI:
             s->waiting = 2;
-            s->current_dma_len = s->dbc;
             lsi_do_dma(s, 0);
             if (s->waiting)
                 s->waiting = 3;



      

      reply	other threads:[~2008-11-26 22:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26 15:32 [Qemu-devel] [PATCH] LSI53C895A: Do not update current_dma_len with dbc in TIA mode Justin Chevrier
2008-11-26 17:07 ` Ryan Harper
2008-11-26 18:08   ` Justin Chevrier
2008-11-26 22:14     ` Ryan Harper
2008-11-26 22:37       ` Justin Chevrier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=714315.59707.qm@web51101.mail.re2.yahoo.com \
    --to=theburner1@yahoo.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ryanh@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.