* [2.6 patch] frv: export empty_zero_page
@ 2008-05-21 17:42 Adrian Bunk
2008-05-21 18:55 ` David Howells
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2008-05-21 17:42 UTC (permalink / raw)
To: dhowells; +Cc: linux-kernel, Andrew Morton
This patch fixes the following build error:
<-- snip -->
...
MODPOST 1845 modules
ERROR: "empty_zero_page" [fs/ext4/ext4dev.ko] undefined!
...
make[2]: *** [__modpost] Error 1
<-- snip -->
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/frv/mm/init.c | 2 ++
1 file changed, 2 insertions(+)
55cf8b72a4e2a78f61de2ef01e70bdd533c6bcf5 diff --git a/arch/frv/mm/init.c b/arch/frv/mm/init.c
index b841ecf..94ea3d8 100644
--- a/arch/frv/mm/init.c
+++ b/arch/frv/mm/init.c
@@ -26,6 +26,7 @@
#include <linux/types.h>
#include <linux/bootmem.h>
#include <linux/highmem.h>
+#include <linux/module.h>
#include <asm/setup.h>
#include <asm/segment.h>
@@ -57,6 +58,7 @@ DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
static unsigned long empty_bad_page_table;
static unsigned long empty_bad_page;
unsigned long empty_zero_page;
+EXPORT_SYMBOL_GPL(empty_zero_page);
/*****************************************************************************/
/*
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [2.6 patch] frv: export empty_zero_page
2008-05-21 17:42 [2.6 patch] frv: export empty_zero_page Adrian Bunk
@ 2008-05-21 18:55 ` David Howells
2008-05-21 19:16 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: David Howells @ 2008-05-21 18:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: dhowells, linux-kernel, Andrew Morton
Adrian Bunk <bunk@kernel.org> wrote:
> EXPORT_SYMBOL_GPL(empty_zero_page);
EXPORT_SYMBOL() as elsewhere please.
I can't test it till I get home next week.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] frv: export empty_zero_page
2008-05-21 18:55 ` David Howells
@ 2008-05-21 19:16 ` Adrian Bunk
2008-05-21 19:24 ` David Howells
0 siblings, 1 reply; 5+ messages in thread
From: Adrian Bunk @ 2008-05-21 19:16 UTC (permalink / raw)
To: David Howells; +Cc: linux-kernel, Andrew Morton
On Wed, May 21, 2008 at 07:55:22PM +0100, David Howells wrote:
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > EXPORT_SYMBOL_GPL(empty_zero_page);
>
> EXPORT_SYMBOL() as elsewhere please.
ia64 also has EXPORT_SYMBOL_GPL...
> I can't test it till I get home next week.
No need to hurry.
> David
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] frv: export empty_zero_page
2008-05-21 19:16 ` Adrian Bunk
@ 2008-05-21 19:24 ` David Howells
2008-05-21 19:54 ` Adrian Bunk
0 siblings, 1 reply; 5+ messages in thread
From: David Howells @ 2008-05-21 19:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: dhowells, linux-kernel, Andrew Morton
Adrian Bunk <bunk@kernel.org> wrote:
> > > EXPORT_SYMBOL_GPL(empty_zero_page);
> >
> > EXPORT_SYMBOL() as elsewhere please.
>
> ia64 also has EXPORT_SYMBOL_GPL...
Okay, everywhere barring ia64 then.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.6 patch] frv: export empty_zero_page
2008-05-21 19:24 ` David Howells
@ 2008-05-21 19:54 ` Adrian Bunk
0 siblings, 0 replies; 5+ messages in thread
From: Adrian Bunk @ 2008-05-21 19:54 UTC (permalink / raw)
To: David Howells; +Cc: linux-kernel, Andrew Morton
On Wed, May 21, 2008 at 08:24:45PM +0100, David Howells wrote:
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > > > EXPORT_SYMBOL_GPL(empty_zero_page);
> > >
> > > EXPORT_SYMBOL() as elsewhere please.
> >
> > ia64 also has EXPORT_SYMBOL_GPL...
>
> Okay, everywhere barring ia64 then.
Updated patch below.
> David
cu
Adrian
<-- snip -->
This patch fixes the following build error:
<-- snip -->
...
MODPOST 1845 modules
ERROR: "empty_zero_page" [fs/ext4/ext4dev.ko] undefined!
...
make[2]: *** [__modpost] Error 1
<-- snip -->
Reported-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/frv/mm/init.c | 3 +++
1 file changed, 3 insertions(+)
69b697b58fe1a9d7f871285768efdbec443ad2e8 diff --git a/arch/frv/mm/init.c b/arch/frv/mm/init.c
index b841ecf..9af7740 100644
--- a/arch/frv/mm/init.c
+++ b/arch/frv/mm/init.c
@@ -26,6 +26,7 @@
#include <linux/types.h>
#include <linux/bootmem.h>
#include <linux/highmem.h>
+#include <linux/module.h>
#include <asm/setup.h>
#include <asm/segment.h>
@@ -56,7 +57,9 @@ DEFINE_PER_CPU(struct mmu_gather, mmu_gathers);
*/
static unsigned long empty_bad_page_table;
static unsigned long empty_bad_page;
+
unsigned long empty_zero_page;
+EXPORT_SYMBOL(empty_zero_page);
/*****************************************************************************/
/*
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-05-21 19:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-21 17:42 [2.6 patch] frv: export empty_zero_page Adrian Bunk
2008-05-21 18:55 ` David Howells
2008-05-21 19:16 ` Adrian Bunk
2008-05-21 19:24 ` David Howells
2008-05-21 19:54 ` Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.