From: Michal Simek <michal.simek@xilinx.com>
To: Colin King <colin.king@canonical.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Michal Simek <michal.simek@xilinx.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: xilinx_can: clean up indentation issue
Date: Thu, 20 Jun 2019 11:55:41 +0000 [thread overview]
Message-ID: <71bd82e7-ea1d-89be-c11b-9d79a1655726@xilinx.com> (raw)
In-Reply-To: <20190619164518.5683-1-colin.king@canonical.com>
On 19. 06. 19 18:45, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A statement is indented one level too deep, fix this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/can/xilinx_can.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
> index 63203ff452b5..a3940141555c 100644
> --- a/drivers/net/can/xilinx_can.c
> +++ b/drivers/net/can/xilinx_can.c
> @@ -924,7 +924,7 @@ static void xcan_err_interrupt(struct net_device *ndev, u32 isr)
> cf->data[3] = CAN_ERR_PROT_LOC_CRC_SEQ;
> }
> }
> - priv->can.can_stats.bus_error++;
> + priv->can.can_stats.bus_error++;
> }
>
> if (skb) {
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Colin King <colin.king@canonical.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Michal Simek <michal.simek@xilinx.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: xilinx_can: clean up indentation issue
Date: Thu, 20 Jun 2019 13:55:41 +0200 [thread overview]
Message-ID: <71bd82e7-ea1d-89be-c11b-9d79a1655726@xilinx.com> (raw)
In-Reply-To: <20190619164518.5683-1-colin.king@canonical.com>
On 19. 06. 19 18:45, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A statement is indented one level too deep, fix this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/can/xilinx_can.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
> index 63203ff452b5..a3940141555c 100644
> --- a/drivers/net/can/xilinx_can.c
> +++ b/drivers/net/can/xilinx_can.c
> @@ -924,7 +924,7 @@ static void xcan_err_interrupt(struct net_device *ndev, u32 isr)
> cf->data[3] = CAN_ERR_PROT_LOC_CRC_SEQ;
> }
> }
> - priv->can.can_stats.bus_error++;
> + priv->can.can_stats.bus_error++;
> }
>
> if (skb) {
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com>
To: Colin King <colin.king@canonical.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
"David S . Miller" <davem@davemloft.net>,
Michal Simek <michal.simek@xilinx.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: xilinx_can: clean up indentation issue
Date: Thu, 20 Jun 2019 13:55:41 +0200 [thread overview]
Message-ID: <71bd82e7-ea1d-89be-c11b-9d79a1655726@xilinx.com> (raw)
In-Reply-To: <20190619164518.5683-1-colin.king@canonical.com>
On 19. 06. 19 18:45, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A statement is indented one level too deep, fix this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/can/xilinx_can.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
> index 63203ff452b5..a3940141555c 100644
> --- a/drivers/net/can/xilinx_can.c
> +++ b/drivers/net/can/xilinx_can.c
> @@ -924,7 +924,7 @@ static void xcan_err_interrupt(struct net_device *ndev, u32 isr)
> cf->data[3] = CAN_ERR_PROT_LOC_CRC_SEQ;
> }
> }
> - priv->can.can_stats.bus_error++;
> + priv->can.can_stats.bus_error++;
> }
>
> if (skb) {
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-20 11:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 16:45 [PATCH] can: xilinx_can: clean up indentation issue Colin King
2019-06-19 16:45 ` Colin King
2019-06-19 16:45 ` Colin King
2019-06-20 11:55 ` Michal Simek [this message]
2019-06-20 11:55 ` Michal Simek
2019-06-20 11:55 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71bd82e7-ea1d-89be-c11b-9d79a1655726@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.