From: "Neronin, Niklas" <niklas.neronin@linux.intel.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: USB list <linux-usb@vger.kernel.org>
Subject: Re: Question regarding 5adc1cc038f4 ("usb: xhci: address off-by-one in xhci_num_trbs_free()")
Date: Wed, 8 Jan 2025 15:28:06 +0200 [thread overview]
Message-ID: <7245189f-87bc-424a-bac0-0ef4ba154e7b@linux.intel.com> (raw)
In-Reply-To: <cdf7cc9d-48a9-4b00-8e6e-ddbfdbbdb47d@suse.com>
On 08/01/2025 13.17, Oliver Neukum wrote:
> Hi,
>
> I was wondering whether this patch should go
> into the stable tree. As far as I can see the issue
> it fixes is old. What do you think?
>
> Regards
> Oliver
>
>
Hi Oliver,
My patch does not change any functionality. The extra loop was never
executed, and the function's return value remains unchanged [1].
I addressed this issue primarily for the benefit of developers.
While the function is straightforward, the extra loop is not.
Identifying its redundancy wastes time.
Since the patch does not fix a bug, it was not added to the stable tree.
[1], The first 'if' statement in the do-while loop will always trigger,
before the loop can terminate. Because a ring always has a Dequeue and
Enqueue pointer; they are integral to the core functionality of a ring.
Best Regards,
Niklas Neronin
next prev parent reply other threads:[~2025-01-08 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 11:17 Question regarding 5adc1cc038f4 ("usb: xhci: address off-by-one in xhci_num_trbs_free()") Oliver Neukum
2025-01-08 13:28 ` Neronin, Niklas [this message]
2025-01-08 13:43 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7245189f-87bc-424a-bac0-0ef4ba154e7b@linux.intel.com \
--to=niklas.neronin@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.