* Question regarding 5adc1cc038f4 ("usb: xhci: address off-by-one in xhci_num_trbs_free()")
@ 2025-01-08 11:17 Oliver Neukum
2025-01-08 13:28 ` Neronin, Niklas
0 siblings, 1 reply; 3+ messages in thread
From: Oliver Neukum @ 2025-01-08 11:17 UTC (permalink / raw)
To: Niklas Neronin; +Cc: USB list
Hi,
I was wondering whether this patch should go
into the stable tree. As far as I can see the issue
it fixes is old. What do you think?
Regards
Oliver
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Question regarding 5adc1cc038f4 ("usb: xhci: address off-by-one in xhci_num_trbs_free()")
2025-01-08 11:17 Question regarding 5adc1cc038f4 ("usb: xhci: address off-by-one in xhci_num_trbs_free()") Oliver Neukum
@ 2025-01-08 13:28 ` Neronin, Niklas
2025-01-08 13:43 ` Oliver Neukum
0 siblings, 1 reply; 3+ messages in thread
From: Neronin, Niklas @ 2025-01-08 13:28 UTC (permalink / raw)
To: Oliver Neukum; +Cc: USB list
On 08/01/2025 13.17, Oliver Neukum wrote:
> Hi,
>
> I was wondering whether this patch should go
> into the stable tree. As far as I can see the issue
> it fixes is old. What do you think?
>
> Regards
> Oliver
>
>
Hi Oliver,
My patch does not change any functionality. The extra loop was never
executed, and the function's return value remains unchanged [1].
I addressed this issue primarily for the benefit of developers.
While the function is straightforward, the extra loop is not.
Identifying its redundancy wastes time.
Since the patch does not fix a bug, it was not added to the stable tree.
[1], The first 'if' statement in the do-while loop will always trigger,
before the loop can terminate. Because a ring always has a Dequeue and
Enqueue pointer; they are integral to the core functionality of a ring.
Best Regards,
Niklas Neronin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Question regarding 5adc1cc038f4 ("usb: xhci: address off-by-one in xhci_num_trbs_free()")
2025-01-08 13:28 ` Neronin, Niklas
@ 2025-01-08 13:43 ` Oliver Neukum
0 siblings, 0 replies; 3+ messages in thread
From: Oliver Neukum @ 2025-01-08 13:43 UTC (permalink / raw)
To: Neronin, Niklas, Oliver Neukum; +Cc: USB list
On 08.01.25 14:28, Neronin, Niklas wrote:
>
>
> On 08/01/2025 13.17, Oliver Neukum wrote:
>> Hi,
>>
>> I was wondering whether this patch should go
>> into the stable tree. As far as I can see the issue
>> it fixes is old. What do you think?
>>
>> Regards
>> Oliver
>>
>>
>
> Hi Oliver,
>
> My patch does not change any functionality. The extra loop was never
> executed, and the function's return value remains unchanged [1].
> I addressed this issue primarily for the benefit of developers.
> While the function is straightforward, the extra loop is not.
> Identifying its redundancy wastes time.
Hi,
thank you. I admit, I overlooked the 'if' statement.
Thank you
Oliver
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-08 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-08 11:17 Question regarding 5adc1cc038f4 ("usb: xhci: address off-by-one in xhci_num_trbs_free()") Oliver Neukum
2025-01-08 13:28 ` Neronin, Niklas
2025-01-08 13:43 ` Oliver Neukum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.