From: David Laight <David.Laight@ACULAB.COM>
To: 'Giuseppe Scrivano' <gscrivan@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"containers@lists.linux-foundation.org"
<containers@lists.linux-foundation.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Subject: RE: [PATCH 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC
Date: Tue, 13 Oct 2020 15:22:50 +0000 [thread overview]
Message-ID: <725dd537afca44489dad48e8ef20e894@AcuMS.aculab.com> (raw)
In-Reply-To: <20201013140609.2269319-3-gscrivan@redhat.com>
> Subject: [PATCH 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC
You really ought to check that it skips closed files.
For instance using dup2() to move some open files to 'big numbers'.
Although you know how it works, a 'black box' test would also
reduce RLIMIT_NOFILES below one of the open files and check
files above the RLIMIT_NOFILES value are affected.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Giuseppe Scrivano' <gscrivan@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"christian.brauner@ubuntu.com" <christian.brauner@ubuntu.com>,
"containers@lists.linux-foundation.org"
<containers@lists.linux-foundation.org>
Subject: RE: [PATCH 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC
Date: Tue, 13 Oct 2020 15:22:50 +0000 [thread overview]
Message-ID: <725dd537afca44489dad48e8ef20e894@AcuMS.aculab.com> (raw)
In-Reply-To: <20201013140609.2269319-3-gscrivan@redhat.com>
> Subject: [PATCH 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC
You really ought to check that it skips closed files.
For instance using dup2() to move some open files to 'big numbers'.
Although you know how it works, a 'black box' test would also
reduce RLIMIT_NOFILES below one of the open files and check
files above the RLIMIT_NOFILES value are affected.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-10-13 15:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:06 [PATCH 0/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC Giuseppe Scrivano
2020-10-13 14:06 ` Giuseppe Scrivano
2020-10-13 14:06 ` [PATCH 1/2] " Giuseppe Scrivano
2020-10-13 14:06 ` Giuseppe Scrivano
2020-10-13 20:54 ` Christian Brauner
2020-10-13 20:54 ` Christian Brauner
2020-10-13 21:04 ` Rasmus Villemoes
2020-10-13 21:04 ` Rasmus Villemoes
2020-10-13 21:22 ` Christian Brauner
2020-10-13 21:22 ` Christian Brauner
2020-10-13 22:45 ` Giuseppe Scrivano
2020-10-13 22:45 ` Giuseppe Scrivano
2020-10-13 21:09 ` Al Viro
2020-10-13 21:09 ` Al Viro
2020-10-13 21:32 ` Christian Brauner
2020-10-13 21:32 ` Christian Brauner
2020-10-13 21:49 ` Rasmus Villemoes
2020-10-13 21:49 ` Rasmus Villemoes
2020-10-13 14:06 ` [PATCH 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC Giuseppe Scrivano
2020-10-13 14:06 ` Giuseppe Scrivano
2020-10-13 15:22 ` David Laight [this message]
2020-10-13 15:22 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=725dd537afca44489dad48e8ef20e894@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=containers@lists.linux-foundation.org \
--cc=gscrivan@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.