All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pragat Pandya <pragat.pandya@gmail.com>
To: "valdis.kletnieks@vt.edu" <valdis.kletnieks@vt.edu>,
	 "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	ppandya2103@gmail.com
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [Linux-kernel-mentees] [RESEND PATCH] staging: exfat: Fix alignment warnings
Date: Sat, 25 Jan 2020 17:49:48 +0530	[thread overview]
Message-ID: <7278a1cb979cd574bccbbbccaf1a9c90acd514b5.camel@gmail.com> (raw)

Fix checkpatch warning "Alignment should match open parenthesis".

Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
 drivers/staging/exfat/exfat_blkdev.c |  4 ++--
 drivers/staging/exfat/exfat_core.c   | 29 ++++++++++++++--------------
 drivers/staging/exfat/exfat_super.c  |  2 +-
 3 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/exfat/exfat_blkdev.c
b/drivers/staging/exfat/exfat_blkdev.c
index 7bcd98b13109..3068bfda39e4 100644
--- a/drivers/staging/exfat/exfat_blkdev.c
+++ b/drivers/staging/exfat/exfat_blkdev.c
@@ -31,7 +31,7 @@ void exfat_bdev_close(struct super_block *sb)
 }
 
 int exfat_bdev_read(struct super_block *sb, sector_t secno, struct
buffer_head **bh,
-             u32 num_secs, bool read)
+                   u32 num_secs, bool read)
 {
        struct bd_info_t *p_bd = &(EXFAT_SB(sb)->bd_info);
        struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
@@ -66,7 +66,7 @@ int exfat_bdev_read(struct super_block *sb, sector_t
secno, struct buffer_head *
 }
 
 int exfat_bdev_write(struct super_block *sb, sector_t secno, struct
buffer_head *bh,
-              u32 num_secs, bool sync)
+                    u32 num_secs, bool sync)
 {
        s32 count;
        struct buffer_head *bh2;
diff --git a/drivers/staging/exfat/exfat_core.c
b/drivers/staging/exfat/exfat_core.c
index 794000e7bc6f..754407c738b7 100644
--- a/drivers/staging/exfat/exfat_core.c
+++ b/drivers/staging/exfat/exfat_core.c
@@ -250,7 +250,7 @@ static u32 test_alloc_bitmap(struct super_block
*sb, u32 clu)
 }
 
 static s32 exfat_alloc_cluster(struct super_block *sb, s32 num_alloc,
-                       struct chain_t *p_chain)
+                              struct chain_t *p_chain)
 {
        s32 num_clusters = 0;
        u32 hint_clu, new_clu, last_clu = CLUSTER_32(~0);
@@ -329,7 +329,7 @@ static s32 exfat_alloc_cluster(struct super_block
*sb, s32 num_alloc,
 }
 
 static void exfat_free_cluster(struct super_block *sb, struct chain_t
*p_chain,
-                       s32 do_relse)
+                              s32 do_relse)
 {
        s32 num_clusters = 0;
        u32 clu;
@@ -920,7 +920,7 @@ static void exfat_set_entry_size(struct dentry_t
*p_entry, u64 size)
 }
 
 static void exfat_get_entry_time(struct dentry_t *p_entry, struct
timestamp_t *tp,
-                         u8 mode)
+                                u8 mode)
 {
        u16 t = 0x00, d = 0x21;
        struct file_dentry_t *ep = (struct file_dentry_t *)p_entry;
@@ -949,7 +949,7 @@ static void exfat_get_entry_time(struct dentry_t
*p_entry, struct timestamp_t *t
 }
 
 static void exfat_set_entry_time(struct dentry_t *p_entry, struct
timestamp_t *tp,
-                         u8 mode)
+                                u8 mode)
 {
        u16 t, d;
        struct file_dentry_t *ep = (struct file_dentry_t *)p_entry;
@@ -1013,7 +1013,7 @@ static void init_name_entry(struct name_dentry_t
*ep, u16 *uniname)
 }
 
 static s32 exfat_init_dir_entry(struct super_block *sb, struct chain_t
*p_dir,
-                        s32 entry, u32 type, u32 start_clu, u64 size)
+                               s32 entry, u32 type, u32 start_clu, u64
size)
 {
        sector_t sector;
        u8 flags;
@@ -1089,7 +1089,7 @@ static s32 exfat_init_ext_entry(struct
super_block *sb, struct chain_t *p_dir,
 }
 
 static void exfat_delete_dir_entry(struct super_block *sb, struct
chain_t *p_dir,
-                           s32 entry, s32 order, s32 num_entries)
+                                  s32 entry, s32 order, s32
num_entries)
 {
        int i;
        sector_t sector;
@@ -1256,7 +1256,7 @@ static s32 _walk_fat_chain(struct super_block
*sb, struct chain_t *p_dir,
 }
 
 static s32 find_location(struct super_block *sb, struct chain_t
*p_dir, s32 entry,
-                 sector_t *sector, s32 *offset)
+                        sector_t *sector, s32 *offset)
 {
        s32 off, ret;
        u32 clu = 0;
@@ -1492,7 +1492,8 @@ void release_entry_set(struct entry_set_cache_t
*es)
 
 /* search EMPTY CONTINUOUS "num_entries" entries */
 static s32 search_deleted_or_unused_entry(struct super_block *sb,
-                                  struct chain_t *p_dir, s32
num_entries)
+                                         struct chain_t *p_dir,
+                                         s32 num_entries)
 {
        int i, dentry, num_empty = 0;
        s32 dentries_per_clu;
@@ -1668,7 +1669,7 @@ static s32 find_empty_entry(struct inode *inode,
struct chain_t *p_dir, s32 num_
 }
 
 static s32 extract_uni_name_from_name_entry(struct name_dentry_t *ep,
u16 *uniname,
-                                    s32 order)
+                                           s32 order)
 {
        int i, len = 0;
 
@@ -1690,8 +1691,8 @@ static s32
extract_uni_name_from_name_entry(struct name_dentry_t *ep, u16 *unina
  * -2 : entry with the name does not exist
  */
 static s32 exfat_find_dir_entry(struct super_block *sb, struct chain_t
*p_dir,
-                        struct uni_name_t *p_uniname, s32 num_entries,
-                        struct dos_name_t *p_dosname, u32 type)
+                               struct uni_name_t *p_uniname, s32
num_entries,
+                               struct dos_name_t *p_dosname, u32 type)
 {
        int i = 0, dentry = 0, num_ext_entries = 0, len, step;
        s32 order = 0;
@@ -1833,7 +1834,7 @@ static s32 exfat_find_dir_entry(struct
super_block *sb, struct chain_t *p_dir,
 }
 
 static s32 exfat_count_ext_entries(struct super_block *sb, struct
chain_t *p_dir,
-                           s32 entry, struct dentry_t *p_entry)
+                                  s32 entry, struct dentry_t *p_entry)
 {
        int i, count = 0;
        u32 type;
@@ -1996,8 +1997,8 @@ s32 get_num_entries_and_dos_name(struct
super_block *sb, struct chain_t *p_dir,
 }
 
 static void exfat_get_uni_name_from_ext_entry(struct super_block *sb,
-                                      struct chain_t *p_dir, s32
entry,
-                                      u16 *uniname)
+                                             struct chain_t *p_dir,
s32 entry,
+                                             u16 *uniname)
 {
        int i;
        struct dentry_t *ep;
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging/exfat/exfat_super.c
index 9f91853b189b..75bb36071722 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -365,7 +365,7 @@ static int ffsMountVol(struct super_block *sb)
 
        if (p_bd->sector_size < sb->s_blocksize) {
                printk(KERN_INFO "EXFAT: mount failed - sector size %d
less than blocksize %ld\n",
-                       p_bd->sector_size,  sb->s_blocksize);
+                      p_bd->sector_size,  sb->s_blocksize);
                ret = -EINVAL;
                goto out;
        }
-- 
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Pragat Pandya <pragat.pandya@gmail.com>
To: "valdis.kletnieks@vt.edu" <valdis.kletnieks@vt.edu>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	ppandya2103@gmail.com
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: [RESEND PATCH] staging: exfat: Fix alignment warnings
Date: Sat, 25 Jan 2020 17:49:48 +0530	[thread overview]
Message-ID: <7278a1cb979cd574bccbbbccaf1a9c90acd514b5.camel@gmail.com> (raw)

Fix checkpatch warning "Alignment should match open parenthesis".

Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
 drivers/staging/exfat/exfat_blkdev.c |  4 ++--
 drivers/staging/exfat/exfat_core.c   | 29 ++++++++++++++--------------
 drivers/staging/exfat/exfat_super.c  |  2 +-
 3 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/exfat/exfat_blkdev.c
b/drivers/staging/exfat/exfat_blkdev.c
index 7bcd98b13109..3068bfda39e4 100644
--- a/drivers/staging/exfat/exfat_blkdev.c
+++ b/drivers/staging/exfat/exfat_blkdev.c
@@ -31,7 +31,7 @@ void exfat_bdev_close(struct super_block *sb)
 }
 
 int exfat_bdev_read(struct super_block *sb, sector_t secno, struct
buffer_head **bh,
-             u32 num_secs, bool read)
+                   u32 num_secs, bool read)
 {
        struct bd_info_t *p_bd = &(EXFAT_SB(sb)->bd_info);
        struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
@@ -66,7 +66,7 @@ int exfat_bdev_read(struct super_block *sb, sector_t
secno, struct buffer_head *
 }
 
 int exfat_bdev_write(struct super_block *sb, sector_t secno, struct
buffer_head *bh,
-              u32 num_secs, bool sync)
+                    u32 num_secs, bool sync)
 {
        s32 count;
        struct buffer_head *bh2;
diff --git a/drivers/staging/exfat/exfat_core.c
b/drivers/staging/exfat/exfat_core.c
index 794000e7bc6f..754407c738b7 100644
--- a/drivers/staging/exfat/exfat_core.c
+++ b/drivers/staging/exfat/exfat_core.c
@@ -250,7 +250,7 @@ static u32 test_alloc_bitmap(struct super_block
*sb, u32 clu)
 }
 
 static s32 exfat_alloc_cluster(struct super_block *sb, s32 num_alloc,
-                       struct chain_t *p_chain)
+                              struct chain_t *p_chain)
 {
        s32 num_clusters = 0;
        u32 hint_clu, new_clu, last_clu = CLUSTER_32(~0);
@@ -329,7 +329,7 @@ static s32 exfat_alloc_cluster(struct super_block
*sb, s32 num_alloc,
 }
 
 static void exfat_free_cluster(struct super_block *sb, struct chain_t
*p_chain,
-                       s32 do_relse)
+                              s32 do_relse)
 {
        s32 num_clusters = 0;
        u32 clu;
@@ -920,7 +920,7 @@ static void exfat_set_entry_size(struct dentry_t
*p_entry, u64 size)
 }
 
 static void exfat_get_entry_time(struct dentry_t *p_entry, struct
timestamp_t *tp,
-                         u8 mode)
+                                u8 mode)
 {
        u16 t = 0x00, d = 0x21;
        struct file_dentry_t *ep = (struct file_dentry_t *)p_entry;
@@ -949,7 +949,7 @@ static void exfat_get_entry_time(struct dentry_t
*p_entry, struct timestamp_t *t
 }
 
 static void exfat_set_entry_time(struct dentry_t *p_entry, struct
timestamp_t *tp,
-                         u8 mode)
+                                u8 mode)
 {
        u16 t, d;
        struct file_dentry_t *ep = (struct file_dentry_t *)p_entry;
@@ -1013,7 +1013,7 @@ static void init_name_entry(struct name_dentry_t
*ep, u16 *uniname)
 }
 
 static s32 exfat_init_dir_entry(struct super_block *sb, struct chain_t
*p_dir,
-                        s32 entry, u32 type, u32 start_clu, u64 size)
+                               s32 entry, u32 type, u32 start_clu, u64
size)
 {
        sector_t sector;
        u8 flags;
@@ -1089,7 +1089,7 @@ static s32 exfat_init_ext_entry(struct
super_block *sb, struct chain_t *p_dir,
 }
 
 static void exfat_delete_dir_entry(struct super_block *sb, struct
chain_t *p_dir,
-                           s32 entry, s32 order, s32 num_entries)
+                                  s32 entry, s32 order, s32
num_entries)
 {
        int i;
        sector_t sector;
@@ -1256,7 +1256,7 @@ static s32 _walk_fat_chain(struct super_block
*sb, struct chain_t *p_dir,
 }
 
 static s32 find_location(struct super_block *sb, struct chain_t
*p_dir, s32 entry,
-                 sector_t *sector, s32 *offset)
+                        sector_t *sector, s32 *offset)
 {
        s32 off, ret;
        u32 clu = 0;
@@ -1492,7 +1492,8 @@ void release_entry_set(struct entry_set_cache_t
*es)
 
 /* search EMPTY CONTINUOUS "num_entries" entries */
 static s32 search_deleted_or_unused_entry(struct super_block *sb,
-                                  struct chain_t *p_dir, s32
num_entries)
+                                         struct chain_t *p_dir,
+                                         s32 num_entries)
 {
        int i, dentry, num_empty = 0;
        s32 dentries_per_clu;
@@ -1668,7 +1669,7 @@ static s32 find_empty_entry(struct inode *inode,
struct chain_t *p_dir, s32 num_
 }
 
 static s32 extract_uni_name_from_name_entry(struct name_dentry_t *ep,
u16 *uniname,
-                                    s32 order)
+                                           s32 order)
 {
        int i, len = 0;
 
@@ -1690,8 +1691,8 @@ static s32
extract_uni_name_from_name_entry(struct name_dentry_t *ep, u16 *unina
  * -2 : entry with the name does not exist
  */
 static s32 exfat_find_dir_entry(struct super_block *sb, struct chain_t
*p_dir,
-                        struct uni_name_t *p_uniname, s32 num_entries,
-                        struct dos_name_t *p_dosname, u32 type)
+                               struct uni_name_t *p_uniname, s32
num_entries,
+                               struct dos_name_t *p_dosname, u32 type)
 {
        int i = 0, dentry = 0, num_ext_entries = 0, len, step;
        s32 order = 0;
@@ -1833,7 +1834,7 @@ static s32 exfat_find_dir_entry(struct
super_block *sb, struct chain_t *p_dir,
 }
 
 static s32 exfat_count_ext_entries(struct super_block *sb, struct
chain_t *p_dir,
-                           s32 entry, struct dentry_t *p_entry)
+                                  s32 entry, struct dentry_t *p_entry)
 {
        int i, count = 0;
        u32 type;
@@ -1996,8 +1997,8 @@ s32 get_num_entries_and_dos_name(struct
super_block *sb, struct chain_t *p_dir,
 }
 
 static void exfat_get_uni_name_from_ext_entry(struct super_block *sb,
-                                      struct chain_t *p_dir, s32
entry,
-                                      u16 *uniname)
+                                             struct chain_t *p_dir,
s32 entry,
+                                             u16 *uniname)
 {
        int i;
        struct dentry_t *ep;
diff --git a/drivers/staging/exfat/exfat_super.c
b/drivers/staging/exfat/exfat_super.c
index 9f91853b189b..75bb36071722 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -365,7 +365,7 @@ static int ffsMountVol(struct super_block *sb)
 
        if (p_bd->sector_size < sb->s_blocksize) {
                printk(KERN_INFO "EXFAT: mount failed - sector size %d
less than blocksize %ld\n",
-                       p_bd->sector_size,  sb->s_blocksize);
+                      p_bd->sector_size,  sb->s_blocksize);
                ret = -EINVAL;
                goto out;
        }
-- 
2.17.1


             reply	other threads:[~2020-01-25 12:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-25 12:19 Pragat Pandya [this message]
2020-01-25 12:19 ` [RESEND PATCH] staging: exfat: Fix alignment warnings Pragat Pandya
2020-01-25 13:38 ` [Linux-kernel-mentees] " gregkh
2020-01-25 13:38   ` gregkh
2020-01-26 11:02   ` [Linux-kernel-mentees] " Pragat Pandya
2020-01-26 11:02     ` Pragat Pandya
2020-01-27  8:11     ` [Linux-kernel-mentees] " Dan Carpenter
2020-01-27  8:11       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7278a1cb979cd574bccbbbccaf1a9c90acd514b5.camel@gmail.com \
    --to=pragat.pandya@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ppandya2103@gmail.com \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.