From: kgunda@codeaurora.org
To: Dan Murphy <dmurphy@ti.com>
Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com,
lee.jones@linaro.org, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
mark.rutland@arm.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for WLED3
Date: Fri, 04 Oct 2019 17:10:55 +0530 [thread overview]
Message-ID: <7300c740873439b341d05ee40e071c3f@codeaurora.org> (raw)
In-Reply-To: <6f50ea19-f320-b4e6-f269-4d1e2189fa77@ti.com>
On 2019-10-01 20:47, Dan Murphy wrote:
> Kiran
>
> On 9/30/19 1:39 AM, Kiran Gunda wrote:
>> Restructure the driver to add the support for new WLED
>> peripherals.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>> ---
>> drivers/video/backlight/qcom-wled.c | 395
>> ++++++++++++++++++++++--------------
>> 1 file changed, 245 insertions(+), 150 deletions(-)
>>
>> diff --git a/drivers/video/backlight/qcom-wled.c
>> b/drivers/video/backlight/qcom-wled.c
>> index f191242..740f1b6 100644
>> --- a/drivers/video/backlight/qcom-wled.c
>> +++ b/drivers/video/backlight/qcom-wled.c
>> @@ -7,59 +7,71 @@
>> #include <linux/module.h>
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> +#include <linux/of_address.h>
>> #include <linux/regmap.h>
>> /* From DT binding */
>> +#define WLED_MAX_STRINGS 4
>> +
>> #define WLED_DEFAULT_BRIGHTNESS 2048
>> -#define WLED3_SINK_REG_BRIGHT_MAX 0xFFF
>> -#define WLED3_CTRL_REG_VAL_BASE 0x40
>> +#define WLED_SINK_REG_BRIGHT_MAX 0xFFF
>
> Why did you change some of these again?
>
> Can you just change it to the final #define in patch 4/8?
>
> Dan
>
> <snip>
Ok.. Looks like some thing went wrong with this series. I will re-upload
it again.
WARNING: multiple messages have this Message-ID (diff)
From: kgunda@codeaurora.org
To: Dan Murphy <dmurphy@ti.com>
Cc: bjorn.andersson@linaro.org, jingoohan1@gmail.com,
lee.jones@linaro.org, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
mark.rutland@arm.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for WLED3
Date: Fri, 04 Oct 2019 11:52:55 +0000 [thread overview]
Message-ID: <7300c740873439b341d05ee40e071c3f@codeaurora.org> (raw)
In-Reply-To: <6f50ea19-f320-b4e6-f269-4d1e2189fa77@ti.com>
On 2019-10-01 20:47, Dan Murphy wrote:
> Kiran
>
> On 9/30/19 1:39 AM, Kiran Gunda wrote:
>> Restructure the driver to add the support for new WLED
>> peripherals.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>> ---
>> drivers/video/backlight/qcom-wled.c | 395
>> ++++++++++++++++++++++--------------
>> 1 file changed, 245 insertions(+), 150 deletions(-)
>>
>> diff --git a/drivers/video/backlight/qcom-wled.c
>> b/drivers/video/backlight/qcom-wled.c
>> index f191242..740f1b6 100644
>> --- a/drivers/video/backlight/qcom-wled.c
>> +++ b/drivers/video/backlight/qcom-wled.c
>> @@ -7,59 +7,71 @@
>> #include <linux/module.h>
>> #include <linux/of.h>
>> #include <linux/of_device.h>
>> +#include <linux/of_address.h>
>> #include <linux/regmap.h>
>> /* From DT binding */
>> +#define WLED_MAX_STRINGS 4
>> +
>> #define WLED_DEFAULT_BRIGHTNESS 2048
>> -#define WLED3_SINK_REG_BRIGHT_MAX 0xFFF
>> -#define WLED3_CTRL_REG_VAL_BASE 0x40
>> +#define WLED_SINK_REG_BRIGHT_MAX 0xFFF
>
> Why did you change some of these again?
>
> Can you just change it to the final #define in patch 4/8?
>
> Dan
>
> <snip>
Ok.. Looks like some thing went wrong with this series. I will re-upload
it again.
next prev parent reply other threads:[~2019-10-04 11:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 6:39 [PATCH V6 0/8] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2019-09-30 6:39 ` [PATCH V6 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2019-09-30 6:51 ` Kiran Gunda
2019-10-01 15:03 ` Dan Murphy
2019-10-01 15:03 ` Dan Murphy
2019-10-01 15:03 ` Dan Murphy
2019-09-30 6:39 ` [PATCH V6 2/8] backlight: qcom-wled: restructure the qcom-wled bindings Kiran Gunda
2019-10-01 15:04 ` Dan Murphy
2019-10-01 15:04 ` Dan Murphy
2019-10-13 12:10 ` Pavel Machek
2019-10-13 12:10 ` Pavel Machek
2019-10-14 6:35 ` Lee Jones
2019-11-04 9:09 ` Pavel Machek
2019-11-04 9:09 ` Pavel Machek
2019-09-30 6:39 ` [PATCH V6 3/8] backlight: qcom-wled: Add new properties for PMI8998 Kiran Gunda
2019-10-01 15:12 ` Dan Murphy
2019-10-01 15:12 ` Dan Murphy
2019-10-15 8:54 ` kgunda
2019-09-30 6:39 ` [PATCH V6 4/8] backlight: qcom-wled: Rename PM8941* to WLED3 Kiran Gunda
2019-09-30 6:51 ` Kiran Gunda
2019-09-30 6:39 ` [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for WLED3 Kiran Gunda
2019-09-30 6:51 ` Kiran Gunda
2019-10-01 15:17 ` Dan Murphy
2019-10-01 15:17 ` Dan Murphy
2019-10-01 15:17 ` Dan Murphy
2019-10-04 11:40 ` kgunda [this message]
2019-10-04 11:52 ` kgunda
2019-09-30 6:39 ` [PATCH V6 6/8] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2019-09-30 6:51 ` Kiran Gunda
2019-09-30 6:39 ` [PATCH V6 7/8] backlight: qcom-wled: add support for short circuit handling Kiran Gunda
2019-09-30 6:51 ` Kiran Gunda
2019-09-30 6:39 ` [PATCH V6 8/8] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2019-09-30 6:51 ` Kiran Gunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7300c740873439b341d05ee40e071c3f@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=agross@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.