From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Tomasz Figa <tfiga@chromium.org>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Mark Brown <broonie@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH 03/10] gpio: samsung: move gpio-samsung driver back to platform code
Date: Tue, 01 Dec 2015 16:33:24 +0100 [thread overview]
Message-ID: <7302923.ORKinVl6Ne@wuerfel> (raw)
In-Reply-To: <565CEB0A.4090107@samsung.com>
On Tuesday 01 December 2015 09:34:18 Krzysztof Kozlowski wrote:
> On 26.11.2015 01:06, Arnd Bergmann wrote:
> > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> > index 57729b915003..83697414bfa0 100644
> > --- a/arch/arm/plat-samsung/Kconfig
> > +++ b/arch/arm/plat-samsung/Kconfig
> > @@ -294,6 +294,9 @@ config SAMSUNG_WDT_RESET
> > Compile support for system restart by triggering watchdog reset.
> > Used on SoCs that do not provide dedicated reset control.
> >
> > +config GPIO_SAMSUNG
> > + def_bool SAMSUNG_ATAGS
> > +
>
> I think this should be put inside "if SAMSUNG_ATAGS" section, just
> before SAMSUNG_PM_GPIO (with default=y?). It makes more consistent with
> rest of the options depending on ATAGS.
Good idea, changed that now.
> Rest seems fine:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Thanks,
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] gpio: samsung: move gpio-samsung driver back to platform code
Date: Tue, 01 Dec 2015 16:33:24 +0100 [thread overview]
Message-ID: <7302923.ORKinVl6Ne@wuerfel> (raw)
In-Reply-To: <565CEB0A.4090107@samsung.com>
On Tuesday 01 December 2015 09:34:18 Krzysztof Kozlowski wrote:
> On 26.11.2015 01:06, Arnd Bergmann wrote:
> > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> > index 57729b915003..83697414bfa0 100644
> > --- a/arch/arm/plat-samsung/Kconfig
> > +++ b/arch/arm/plat-samsung/Kconfig
> > @@ -294,6 +294,9 @@ config SAMSUNG_WDT_RESET
> > Compile support for system restart by triggering watchdog reset.
> > Used on SoCs that do not provide dedicated reset control.
> >
> > +config GPIO_SAMSUNG
> > + def_bool SAMSUNG_ATAGS
> > +
>
> I think this should be put inside "if SAMSUNG_ATAGS" section, just
> before SAMSUNG_PM_GPIO (with default=y?). It makes more consistent with
> rest of the options depending on ATAGS.
Good idea, changed that now.
> Rest seems fine:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Thanks,
Arnd
next prev parent reply other threads:[~2015-12-01 15:34 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 16:06 [PATCH 00/10] ARM: s3c64xx multiplatform Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` [PATCH 01/10] Input: s3c2410_ts: fix S3C_ADC dependency Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-30 23:48 ` Krzysztof Kozlowski
2015-11-30 23:48 ` Krzysztof Kozlowski
2015-11-25 16:06 ` [PATCH 02/10] ASoC: samsung/smartq: use dynamic registration Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-12-01 0:24 ` Krzysztof Kozlowski
2015-12-01 0:24 ` Krzysztof Kozlowski
2015-12-01 15:11 ` Arnd Bergmann
2015-12-01 15:11 ` Arnd Bergmann
2015-11-25 16:06 ` [PATCH 03/10] gpio: samsung: move gpio-samsung driver back to platform code Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-12-01 0:34 ` Krzysztof Kozlowski
2015-12-01 0:34 ` Krzysztof Kozlowski
2015-12-01 15:33 ` Arnd Bergmann [this message]
2015-12-01 15:33 ` Arnd Bergmann
2015-11-25 16:06 ` [PATCH 04/10] ARM: s3c64xx: prepare initcalls for multiplatform Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-12-01 1:23 ` Krzysztof Kozlowski
2015-12-01 1:23 ` Krzysztof Kozlowski
2015-11-25 16:06 ` [PATCH 05/10] ARM: s3c64xx: enable sparse IRQ support Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` [PATCH 06/10] iio: exynos-adc: add experimental touchscreen support Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` [PATCH 07/10] ARM: s3c64xx: use new adc/touchscreen driver Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` [PATCH 08/10] ARM: s3c64xx: use common debug-ll implementation Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` [PATCH 09/10] ARM: s3c64xx: multiplatform support Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` [PATCH 10/10] ARM: s3c64xx: allow building without board support Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:06 ` Arnd Bergmann
2015-11-25 16:31 ` [PATCH 00/10] ARM: s3c64xx multiplatform Mark Brown
2015-11-25 16:31 ` Mark Brown
2015-11-25 16:33 ` Arnd Bergmann
2015-11-25 16:33 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2015-03-02 12:35 [PATCH 00/10] ARM: s3c64xx multiplatform, help needed Arnd Bergmann
2015-03-02 12:35 ` [PATCH 03/10] gpio: samsung: move gpio-samsung driver back to platform code Arnd Bergmann
2015-03-02 12:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7302923.ORKinVl6Ne@wuerfel \
--to=arnd@arndb.de \
--cc=anarsoul@gmail.com \
--cc=ben.dooks@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.