All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <slava@dubeyko.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: zlang@kernel.org, fstests@vger.kernel.org,
	glaubitz@physik.fu-berlin.de, vdubeyko@coreweave.com,
	linux-fsdevel@vger.kernel.org, frank.li@vivo.com
Subject: Re: [PATCH] xfstests: exclude hfs/hfsplus from generic/339 run
Date: Thu, 10 Sep 2026 13:13:12 -0700	[thread overview]
Message-ID: <730a395bb6eed86bdff7eb21668f4f1fb42f664f.camel@dubeyko.com> (raw)
In-Reply-To: <aqJ--AqubS-CWiV-@infradead.org>

On Thu, 2026-09-10 at 02:57 -0700, Christoph Hellwig wrote:
> On Wed, Sep 09, 2026 at 05:04:50PM -0700, Viacheslav Dubeyko wrote:
> > The dirhash_collide generates filenames from arbitrary random
> > bytes (only '.' and '/' are filtered out), which are not valid
> > UTF-8 in general. Catalog names on both classic HFS and HFS+ are
> > Unicode. Feeding random bytes causes fsck to report "Illegal name"
> > or catalog corruption that has nothing to do with directory
> > hash-collision handling, which is what this test is actually meant
> > to exercise.
> 
> If user file name creation manage to trigger fsck complaints, you
> need
> to righten the input checks in the file systems first to fix this.
> 
> We can then find a programmatic way to deal with these rejects in
> xfstests, as ext4/f2fs in case insensiive mode probably have the same
> issue.

I see your point. And I really like your suggestion. But what is your
vision of the proper way to check the validity of Unicode symbols?

Thanks,
Slava.

  parent reply	other threads:[~2026-09-10 20:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  0:04 [PATCH] xfstests: exclude hfs/hfsplus from generic/339 run Viacheslav Dubeyko
2026-09-10  9:57 ` Christoph Hellwig
2026-09-10 13:49   ` Theodore Tso
2026-09-10 21:14     ` Viacheslav Dubeyko
2026-09-11 14:48       ` Theodore Tso
2026-09-10 20:13   ` Viacheslav Dubeyko [this message]
2026-09-11  7:09     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=730a395bb6eed86bdff7eb21668f4f1fb42f664f.camel@dubeyko.com \
    --to=slava@dubeyko.com \
    --cc=frank.li@vivo.com \
    --cc=fstests@vger.kernel.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=vdubeyko@coreweave.com \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.