Re: [PATCH] xfstests: exclude hfs/hfsplus from generic/339 run

[Christoph Hellwig <hch@infradead.org>]

On Thu, Sep 10, 2026 at 01:13:12PM -0700, Viacheslav Dubeyko wrote:
> On Thu, 2026-09-10 at 02:57 -0700, Christoph Hellwig wrote:
> > On Wed, Sep 09, 2026 at 05:04:50PM -0700, Viacheslav Dubeyko wrote:
> > > The dirhash_collide generates filenames from arbitrary random
> > > bytes (only '.' and '/' are filtered out), which are not valid
> > > UTF-8 in general. Catalog names on both classic HFS and HFS+ are
> > > Unicode. Feeding random bytes causes fsck to report "Illegal name"
> > > or catalog corruption that has nothing to do with directory
> > > hash-collision handling, which is what this test is actually meant
> > > to exercise.
> > 
> > If user file name creation manage to trigger fsck complaints, you
> > need
> > to righten the input checks in the file systems first to fix this.
> > 
> > We can then find a programmatic way to deal with these rejects in
> > xfstests, as ext4/f2fs in case insensiive mode probably have the same
> > issue.
> 
> I see your point. And I really like your suggestion. But what is your
> vision of the proper way to check the validity of Unicode symbols?

I don't think validity of a unicode symbol matter directly here.  You
need to check what the Apple implementation accepts and/or what
Apple documents and follow that.