From: Joe Konno <joe.konno@linux.intel.com>
To: grub-devel@gnu.org
Cc: david.e.box@intel.com
Subject: Re: [PATCH] tsc: Change default tsc calibration method to EFI on EFI systems
Date: Wed, 6 Sep 2017 13:56:57 -0700 [thread overview]
Message-ID: <7327ef$3ubqpm@orsmga002.jf.intel.com> (raw)
In-Reply-To: <20170906202054.2214-1-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
On Wed, 6 Sep 2017 13:20:54 -0700
"David E. Box" <david.e.box@linux.intel.com> wrote:
> On efi systems, make efi based tsc calibration the default, followed by
> the pmtimer before using the pit. This prevents Grub boot failure on
> newer x86 systems that power gate the pit.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> grub-core/kern/i386/tsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/kern/i386/tsc.c b/grub-core/kern/i386/tsc.c
> index 2e85289d8..de4057ddb 100644
> --- a/grub-core/kern/i386/tsc.c
> +++ b/grub-core/kern/i386/tsc.c
> @@ -68,7 +68,7 @@ grub_tsc_init (void)
> #ifdef GRUB_MACHINE_XEN
> (void) (grub_tsc_calibrate_from_xen () || calibrate_tsc_hardcode());
> #elif defined (GRUB_MACHINE_EFI)
> - (void) (grub_tsc_calibrate_from_pit () || grub_tsc_calibrate_from_pmtimer () || grub_tsc_calibrate_from_efi() || calibrate_tsc_hardcode());
> + (void) (grub_tsc_calibrate_from_efi () || grub_tsc_calibrate_from_pmtimer () || grub_tsc_calibrate_from_pit () || calibrate_tsc_hardcode());
> #elif defined (GRUB_MACHINE_COREBOOT)
> (void) (grub_tsc_calibrate_from_pmtimer () || grub_tsc_calibrate_from_pit () || calibrate_tsc_hardcode());
> #else
Good catch!
Noted the baked-in, minor style cleanup:
grub_tsc_calibrate_from_efi() -> grub_tsc_calibrate_from_efi ()
You have my:
Reviewed-by: Joe Konno <joe.konno@intel.com>
Cheers
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-09-06 20:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 20:20 [PATCH] tsc: Change default tsc calibration method to EFI on EFI systems David E. Box
2017-09-06 20:56 ` Joe Konno [this message]
2017-09-12 7:10 ` Paul Menzel
2017-09-12 23:40 ` David E. Box
2017-09-12 23:46 ` Vladimir 'phcoder' Serbinenko
2017-09-15 22:06 ` David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='7327ef$3ubqpm@orsmga002.jf.intel.com' \
--to=joe.konno@linux.intel.com \
--cc=david.e.box@intel.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.