All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, "Li Qiang" <liq3ea@gmail.com>
Cc: ehabkost@redhat.com, qemu-trivial@nongnu.org, laurent@vivier.eu,
	pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target: hax: fix a typo
Date: Mon, 26 Nov 2018 22:25:36 +0100	[thread overview]
Message-ID: <733cd094-3775-ba2f-242d-e58bc7f2daaa@redhat.com> (raw)
In-Reply-To: <87mupw3vm2.fsf@linaro.org>

Hi Li, Alex.

On 26/11/18 12:51, Alex Bennée wrote:
> 
> Li Qiang <liq3ea@gmail.com> writes:
> 
>> Cc: qemu-trivial@nongnu.org
>>
>> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> 
>> ---
>>  target/i386/hax-all.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
>> index 502ce6f0af..464744a406 100644
>> --- a/target/i386/hax-all.c
>> +++ b/target/i386/hax-all.c
>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>>      }
>>
>>      /*
>> -     * 1. The hax_tunnel is also destroied when vcpu destroy
>> +     * 1. The hax_tunnel is also destroyed when vcpu destroy

I'm not native english speaker. Isn't it:

'The hax_tunnel is also destroyed at vcpu destroy'

or

'The hax_tunnel is also destroyed when vcpu is destroyed'?

>>       * 2. close fd will cause hax module vcpu be cleaned
>>       */
>>      hax_close_fd(vcpu->fd);
> 
> 
> --
> Alex Bennée
> 


WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, "Li Qiang" <liq3ea@gmail.com>
Cc: ehabkost@redhat.com, qemu-trivial@nongnu.org, laurent@vivier.eu,
	pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] target: hax: fix a typo
Date: Mon, 26 Nov 2018 22:25:36 +0100	[thread overview]
Message-ID: <733cd094-3775-ba2f-242d-e58bc7f2daaa@redhat.com> (raw)
In-Reply-To: <87mupw3vm2.fsf@linaro.org>

Hi Li, Alex.

On 26/11/18 12:51, Alex Bennée wrote:
> 
> Li Qiang <liq3ea@gmail.com> writes:
> 
>> Cc: qemu-trivial@nongnu.org
>>
>> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> 
>> ---
>>  target/i386/hax-all.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
>> index 502ce6f0af..464744a406 100644
>> --- a/target/i386/hax-all.c
>> +++ b/target/i386/hax-all.c
>> @@ -205,7 +205,7 @@ int hax_vcpu_destroy(CPUState *cpu)
>>      }
>>
>>      /*
>> -     * 1. The hax_tunnel is also destroied when vcpu destroy
>> +     * 1. The hax_tunnel is also destroyed when vcpu destroy

I'm not native english speaker. Isn't it:

'The hax_tunnel is also destroyed at vcpu destroy'

or

'The hax_tunnel is also destroyed when vcpu is destroyed'?

>>       * 2. close fd will cause hax module vcpu be cleaned
>>       */
>>      hax_close_fd(vcpu->fd);
> 
> 
> --
> Alex Bennée
> 

  reply	other threads:[~2018-11-26 21:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26  9:58 [Qemu-trivial] [PATCH] target: hax: fix a typo Li Qiang
2018-11-26  9:58 ` [Qemu-devel] " Li Qiang
2018-11-26 11:51 ` [Qemu-trivial] " Alex Bennée
2018-11-26 11:51   ` Alex Bennée
2018-11-26 21:25   ` Philippe Mathieu-Daudé [this message]
2018-11-26 21:25     ` Philippe Mathieu-Daudé
2018-11-26 21:33     ` [Qemu-trivial] " Richard Henderson
2018-11-26 21:33       ` Richard Henderson
2018-11-28 12:43 ` [Qemu-trivial] " Paolo Bonzini
2018-11-28 12:43   ` [Qemu-devel] " Paolo Bonzini
2018-11-28 12:47   ` [Qemu-trivial] " Laurent Vivier
2018-11-28 12:47     ` [Qemu-devel] " Laurent Vivier
2018-11-28 13:03     ` [Qemu-trivial] " Paolo Bonzini
2018-11-28 13:03       ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=733cd094-3775-ba2f-242d-e58bc7f2daaa@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=liq3ea@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.