From: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Horng-Shyang Liao
<hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Jassi Brar
<jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Devicetree List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Nicolas Boichat
<drinkcat-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
CK HU <ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
cawa cheng <cawa.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Bibby Hsieh <bibby.hsieh-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
YT Shen <yt.shen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Daoyuan Huang
<daoyuan.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Damon Chu <damon.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Josh-YC Liu <josh-yc.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Glory Hung <glor>
Subject: Re: [PATCH v14 4/4] CMDQ: save more energy in idle
Date: Fri, 30 Sep 2016 11:01:32 +0200 [thread overview]
Message-ID: <73a10cdc-6aeb-73be-adcb-0367e2e07824@gmail.com> (raw)
In-Reply-To: <1475225766.25044.33.camel@mtksdaap41>
On 09/30/2016 10:56 AM, Horng-Shyang Liao wrote:
> On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote:
>> On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote:
>>> On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
>>>> Use clk_disable_unprepare instead of clk_disable to save more energy
>>>> when CMDQ is idle.
>>>>
>>>> Signed-off-by: HS Liao <hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
>>>> ---
>>>> drivers/mailbox/mtk-cmdq.c | 54 +++++++++++++++++++++++++++++++++++++++-------
>>>
>>> The driver is introduced by second patch of the set, so it makes sense
>>> to merge this patch into patch 2/4.
>>
>> Hi Jassi,
>>
>> Could you take a look at previous discussion between Matthias and me?
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05239.html
>> His basic idea is to simplify first working version.
>> Therefore, I move some code to this patch.
>>
Well what I wanted to say is, that right now this driver is quite a big
beast and this makes it difficult to review. So my idea was to just
submit the most basic version of this driver.
Any improvements on the driver should be sent in follow-up patches after
the basic driver got merged. That was my idea.
Regards,
Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v14 4/4] CMDQ: save more energy in idle
Date: Fri, 30 Sep 2016 11:01:32 +0200 [thread overview]
Message-ID: <73a10cdc-6aeb-73be-adcb-0367e2e07824@gmail.com> (raw)
In-Reply-To: <1475225766.25044.33.camel@mtksdaap41>
On 09/30/2016 10:56 AM, Horng-Shyang Liao wrote:
> On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote:
>> On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote:
>>> On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.liao@mediatek.com> wrote:
>>>> Use clk_disable_unprepare instead of clk_disable to save more energy
>>>> when CMDQ is idle.
>>>>
>>>> Signed-off-by: HS Liao <hs.liao@mediatek.com>
>>>> ---
>>>> drivers/mailbox/mtk-cmdq.c | 54 +++++++++++++++++++++++++++++++++++++++-------
>>>
>>> The driver is introduced by second patch of the set, so it makes sense
>>> to merge this patch into patch 2/4.
>>
>> Hi Jassi,
>>
>> Could you take a look at previous discussion between Matthias and me?
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05239.html
>> His basic idea is to simplify first working version.
>> Therefore, I move some code to this patch.
>>
Well what I wanted to say is, that right now this driver is quite a big
beast and this makes it difficult to review. So my idea was to just
submit the most basic version of this driver.
Any improvements on the driver should be sent in follow-up patches after
the basic driver got merged. That was my idea.
Regards,
Matthias
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Horng-Shyang Liao <hs.liao@mediatek.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Daniel Kurtz <djkurtz@chromium.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Devicetree List <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
Sascha Hauer <kernel@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Nicolas Boichat <drinkcat@chromium.org>,
CK HU <ck.hu@mediatek.com>, cawa cheng <cawa.cheng@mediatek.com>,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
YT Shen <yt.shen@mediatek.com>,
Daoyuan Huang <daoyuan.huang@mediatek.com>,
Damon Chu <damon.chu@mediatek.com>,
Josh-YC Liu <josh-yc.liu@mediatek.com>,
Glory Hung <glory.hung@mediatek.com>,
Jiaguang Zhang <jiaguang.zhang@mediatek.com>,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
Monica Wang <monica.wang@mediatek.com>
Subject: Re: [PATCH v14 4/4] CMDQ: save more energy in idle
Date: Fri, 30 Sep 2016 11:01:32 +0200 [thread overview]
Message-ID: <73a10cdc-6aeb-73be-adcb-0367e2e07824@gmail.com> (raw)
In-Reply-To: <1475225766.25044.33.camel@mtksdaap41>
On 09/30/2016 10:56 AM, Horng-Shyang Liao wrote:
> On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote:
>> On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote:
>>> On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.liao@mediatek.com> wrote:
>>>> Use clk_disable_unprepare instead of clk_disable to save more energy
>>>> when CMDQ is idle.
>>>>
>>>> Signed-off-by: HS Liao <hs.liao@mediatek.com>
>>>> ---
>>>> drivers/mailbox/mtk-cmdq.c | 54 +++++++++++++++++++++++++++++++++++++++-------
>>>
>>> The driver is introduced by second patch of the set, so it makes sense
>>> to merge this patch into patch 2/4.
>>
>> Hi Jassi,
>>
>> Could you take a look at previous discussion between Matthias and me?
>> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05239.html
>> His basic idea is to simplify first working version.
>> Therefore, I move some code to this patch.
>>
Well what I wanted to say is, that right now this driver is quite a big
beast and this makes it difficult to review. So my idea was to just
submit the most basic version of this driver.
Any improvements on the driver should be sent in follow-up patches after
the basic driver got merged. That was my idea.
Regards,
Matthias
next prev parent reply other threads:[~2016-09-30 9:01 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 1:44 [PATCH v14 0/4] Mediatek MT8173 CMDQ support HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-05 1:44 ` [PATCH v14 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-05 1:44 ` [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-22 8:17 ` Jassi Brar
2016-09-22 8:17 ` Jassi Brar
2016-09-22 8:17 ` Jassi Brar
2016-09-23 9:28 ` Horng-Shyang Liao
2016-09-23 9:28 ` Horng-Shyang Liao
2016-09-23 9:28 ` Horng-Shyang Liao
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 3:06 ` CK Hu
2016-09-30 3:06 ` CK Hu
2016-09-30 3:06 ` CK Hu
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 9:11 ` CK Hu
2016-09-30 9:11 ` CK Hu
2016-09-30 9:11 ` CK Hu
2016-09-30 9:47 ` Horng-Shyang Liao
2016-09-30 9:47 ` Horng-Shyang Liao
2016-09-30 9:47 ` Horng-Shyang Liao
2016-10-05 2:54 ` Horng-Shyang Liao
2016-10-05 2:54 ` Horng-Shyang Liao
2016-10-05 2:54 ` Horng-Shyang Liao
2016-10-05 3:37 ` Jassi Brar
2016-10-05 3:37 ` Jassi Brar
2016-10-05 3:37 ` Jassi Brar
2016-10-05 12:31 ` Horng-Shyang Liao
2016-10-05 12:31 ` Horng-Shyang Liao
2016-10-05 12:31 ` Horng-Shyang Liao
2016-10-05 14:43 ` Jassi Brar
2016-10-05 14:43 ` Jassi Brar
2016-10-05 14:43 ` Jassi Brar
2016-10-06 13:01 ` Horng-Shyang Liao
2016-10-06 13:01 ` Horng-Shyang Liao
2016-10-06 13:01 ` Horng-Shyang Liao
2016-10-06 13:10 ` Jassi Brar
2016-10-06 13:10 ` Jassi Brar
2016-10-06 13:10 ` Jassi Brar
[not found] ` <CAJe_ZheptRQSmQp2gagqUyXqkOpi1qaTo8QPDTFpQ-+62B6kUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-11 2:40 ` Horng-Shyang Liao
2016-10-11 2:40 ` Horng-Shyang Liao
2016-10-11 2:40 ` Horng-Shyang Liao
2016-10-11 4:19 ` Jassi Brar
2016-10-11 4:19 ` Jassi Brar
2016-10-11 4:19 ` Jassi Brar
[not found] ` <1473039885-24009-1-git-send-email-hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-09-05 1:44 ` [PATCH v14 3/4] arm64: dts: mt8173: Add GCE node HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-05 1:44 ` [PATCH v14 4/4] CMDQ: save more energy in idle HS Liao
2016-09-05 1:44 ` HS Liao
2016-09-05 1:44 ` HS Liao
[not found] ` <1473039885-24009-5-git-send-email-hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2016-09-22 7:52 ` Jassi Brar
2016-09-22 7:52 ` Jassi Brar
2016-09-22 7:52 ` Jassi Brar
2016-09-23 9:28 ` Horng-Shyang Liao
2016-09-23 9:28 ` Horng-Shyang Liao
2016-09-23 9:28 ` Horng-Shyang Liao
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 8:56 ` Horng-Shyang Liao
2016-09-30 9:01 ` Matthias Brugger [this message]
2016-09-30 9:01 ` Matthias Brugger
2016-09-30 9:01 ` Matthias Brugger
2016-09-19 6:43 ` [PATCH v14 0/4] Mediatek MT8173 CMDQ support Horng-Shyang Liao
2016-09-19 6:43 ` Horng-Shyang Liao
2016-09-19 6:43 ` Horng-Shyang Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a10cdc-6aeb-73be-adcb-0367e2e07824@gmail.com \
--to=matthias.bgg-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=bibby.hsieh-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=cawa.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=ck.hu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=damon.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=daoyuan.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=drinkcat-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=josh-yc.liu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=yt.shen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.