[PATCH] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[PATCH] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[genevieve.chan]

From: Genevieve Chan <genevieve.chan@altera.com>

Correct the kernel-doc for INTEL_SIP_SMC_FCS_SEND_CERTIFICATE to
describe an async call instead of sync, and fix incorrect return
status macro names
(INTEL_SIP_SMC_FCS_REJECTED -> INTEL_SIP_SMC_REJECTED).

For INTEL_SIP_SMC_FCS_GET_PROVISION_DATA, align the documented
return status macros with the standard values
(INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
and document the full async return register usage in a1-a3:
mailbox error code, physical address of the fuse/key hash structure,
and structure size.

Signed-off-by: Genevieve Chan <genevieve.chan@altera.com>
---
 include/linux/firmware/intel/stratix10-smc.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/include/linux/firmware/intel/stratix10-smc.h b/include/linux/firmware/intel/stratix10-smc.h
index 9116512169dc..2c603a24967f 100644
--- a/include/linux/firmware/intel/stratix10-smc.h
+++ b/include/linux/firmware/intel/stratix10-smc.h
@@ -606,7 +606,7 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE)
 
 /**
  * Request INTEL_SIP_SMC_FUNCID_FCS_SEND_CERTIFICATE
- * Sync call to send a signed certificate
+ * Async call to send a signed certificate
  *
  * Call register usage:
  * a0 INTEL_SIP_SMC_FCS_SEND_CERTIFICATE
@@ -615,7 +615,7 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE)
  * a3-a7 not used
  *
  * Return status:
- * a0 INTEL_SIP_SMC_STATUS_OK or INTEL_SIP_SMC_FCS_REJECTED
+ * a0 INTEL_SIP_SMC_STATUS_OK or INTEL_SIP_SMC_REJECTED
  * a1-a3 not used
  */
 #define INTEL_SIP_SMC_FUNCID_FCS_SEND_CERTIFICATE 93
@@ -631,9 +631,11 @@ INTEL_SIP_SMC_FAST_CALL_VAL(INTEL_SIP_SMC_FUNCID_FPGA_CONFIG_COMPLETED_WRITE)
  * a1-a7 not used
  *
  * Return status:
- * a0 INTEL_SIP_SMC_STATUS_OK, INTEL_SIP_SMC_FCS_ERROR or
- *      INTEL_SIP_SMC_FCS_REJECTED
- * a1-a3 not used
+ * a0 INTEL_SIP_SMC_STATUS_OK, INTEL_SIP_SMC_STATUS_ERROR or
+ *	INTEL_SIP_SMC_STATUS_REJECTED
+ * a1 mailbox error if a0 is INTEL_SIP_SMC_STATUS_ERROR
+ * a2 physical address for the structure of fuse and key hashes
+ * a3 the size of structure
  *
  */
 #define INTEL_SIP_SMC_FUNCID_FCS_GET_PROVISION_DATA 94
-- 
2.43.7

Re: [PATCH] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[Dinh Nguyen]

On 6/23/26 04:10, genevieve.chan@altera.com wrote:
> From: Genevieve Chan <genevieve.chan@altera.com>
> 
> Correct the kernel-doc for INTEL_SIP_SMC_FCS_SEND_CERTIFICATE to
> describe an async call instead of sync, and fix incorrect return
> status macro names
> (INTEL_SIP_SMC_FCS_REJECTED -> INTEL_SIP_SMC_REJECTED).
> 
> For INTEL_SIP_SMC_FCS_GET_PROVISION_DATA, align the documented
> return status macros with the standard values
> (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
> and document the full async return register usage in a1-a3:
> mailbox error code, physical address of the fuse/key hash structure,
> and structure size.
> 
> Signed-off-by: Genevieve Chan <genevieve.chan@altera.com>
> ---
>   include/linux/firmware/intel/stratix10-smc.h | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
>

If this is a fix, you forgot to include the Fixes tag and Cc: stable.

Please refer to : Documentation/process/stable-kernel-rules.rst

Thanks,
Dinh

Re: [PATCH] firmware: stratix10-svc: fix FCS SMC call kernel-doc

[Chan, Genevieve]

V2 patch is submitted: https://lore.kernel.org/all/20260702082844.9648-1-genevieve.chan@altera.com/

Thanks,
Genevieve Chan

On 29/6/2026 10:02 pm, Dinh Nguyen wrote:
> 
> 
> On 6/23/26 04:10, genevieve.chan@altera.com wrote:
>> From: Genevieve Chan <genevieve.chan@altera.com>
>>
>> Correct the kernel-doc for INTEL_SIP_SMC_FCS_SEND_CERTIFICATE to
>> describe an async call instead of sync, and fix incorrect return
>> status macro names
>> (INTEL_SIP_SMC_FCS_REJECTED -> INTEL_SIP_SMC_REJECTED).
>>
>> For INTEL_SIP_SMC_FCS_GET_PROVISION_DATA, align the documented
>> return status macros with the standard values
>> (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
>> and document the full async return register usage in a1-a3:
>> mailbox error code, physical address of the fuse/key hash structure,
>> and structure size.
>>
>> Signed-off-by: Genevieve Chan <genevieve.chan@altera.com>
>> ---
>>   include/linux/firmware/intel/stratix10-smc.h | 12 +++++++-----
>>   1 file changed, 7 insertions(+), 5 deletions(-)
>>
> 
> If this is a fix, you forgot to include the Fixes tag and Cc: stable.
> 
> Please refer to : Documentation/process/stable-kernel-rules.rst
> 
> Thanks,
> Dinh