From: poza@codeaurora.org
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>,
Keith Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>,
Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v12 3/6] PCI/PORTDRV: Implement generic find service
Date: Thu, 08 Mar 2018 13:26:02 +0530 [thread overview]
Message-ID: <73d083f125a11dbc6779dae6c0ffa6e3@codeaurora.org> (raw)
In-Reply-To: <ac53deae-8fad-b896-805f-36343253a34b@codeaurora.org>
On 2018-03-06 19:32, Sinan Kaya wrote:
> On 2/28/2018 12:04 PM, Oza Pawandeep wrote:
>> +struct pcie_port_service_driver *pcie_port_find_service(struct
>> pci_dev *dev,
>> + u32 service)
>> +{
>> + struct pcie_port_service_driver *drv = NULL;
>
> Remove initialization
>
>> + struct portdrv_service_data pdrvs;
>> +
>> + pdrvs.service = service;
>
> initialize pdrvs.drv = NULL here.
>
good point, will take care of this. [along with other comments if any]
>> + device_for_each_child(&dev->dev, &pdrvs, find_service_iter);
>> +
>> + drv = pdrvs.drv;
>> + return drv;
>> +}
next prev parent reply other threads:[~2018-03-08 7:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 17:04 [PATCH v12 0/6] Address error and recovery for AER and DPC Oza Pawandeep
2018-02-28 17:04 ` [PATCH v12 1/6] PCI/AER: Rename error recovery to generic PCI naming Oza Pawandeep
2018-02-28 17:04 ` [PATCH v12 2/6] PCI/AER: Factor out error reporting from AER Oza Pawandeep
2018-02-28 17:04 ` [PATCH v12 3/6] PCI/PORTDRV: Implement generic find service Oza Pawandeep
2018-03-06 14:02 ` Sinan Kaya
2018-03-08 7:56 ` poza [this message]
2018-02-28 17:04 ` [PATCH v12 4/6] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-02-28 17:04 ` [PATCH v12 5/6] PCI: Unify wait for link active into generic PCI Oza Pawandeep
2018-02-28 17:04 ` [PATCH v12 6/6] PCI/DPC: Enumerate the devices after DPC trigger event Oza Pawandeep
2018-03-11 22:03 ` [PATCH v12 0/6] Address error and recovery for AER and DPC Bjorn Helgaas
2018-03-12 3:03 ` Sinan Kaya
2018-03-12 14:25 ` Keith Busch
2018-03-12 14:46 ` poza
2018-03-12 14:58 ` Keith Busch
2018-03-12 15:34 ` poza
2018-03-12 17:33 ` Keith Busch
2018-03-12 17:41 ` Sinan Kaya
2018-03-12 17:56 ` Keith Busch
2018-03-12 19:47 ` Bjorn Helgaas
2018-03-12 23:26 ` Keith Busch
2018-03-13 3:47 ` Sinan Kaya
2018-03-14 20:50 ` Keith Busch
2018-03-14 21:00 ` Sinan Kaya
2018-05-08 19:25 ` Bjorn Helgaas
2018-03-12 14:01 ` poza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d083f125a11dbc6779dae6c0ffa6e3@codeaurora.org \
--to=poza@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.