* [PATCH v4 1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device()
@ 2023-10-07 8:12 Andy Shevchenko
2023-10-09 11:33 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-10-07 8:12 UTC (permalink / raw)
To: Andy Shevchenko, acpi4asus-user, platform-driver-x86,
linux-kernel
Cc: Corentin Chary, João Paulo Rechi Vita, Hans de Goede,
Ilpo Järvinen, Mark Gross
Replace open coded acpi_match_device() in asus_wireless_add().
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v4: used proper API, added tag (Hans)
v3: rewrote error path logic (Hans)
v2: fixed compilation error
drivers/platform/x86/asus-wireless.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index abf01e00b799..41227bf95878 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -148,16 +148,12 @@ static int asus_wireless_add(struct acpi_device *adev)
if (err)
return err;
- for (id = device_ids; id->id[0]; id++) {
- if (!strcmp((char *) id->id, acpi_device_hid(adev))) {
- data->hswc_params =
- (const struct hswc_params *)id->driver_data;
- break;
- }
- }
- if (!data->hswc_params)
+ id = acpi_match_acpi_device(device_ids, adev);
+ if (!id)
return 0;
+ data->hswc_params = (const struct hswc_params *)id->driver_data;
+
data->wq = create_singlethread_workqueue("asus_wireless_workqueue");
if (!data->wq)
return -ENOMEM;
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v4 1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device()
2023-10-07 8:12 [PATCH v4 1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device() Andy Shevchenko
@ 2023-10-09 11:33 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2023-10-09 11:33 UTC (permalink / raw)
To: Andy Shevchenko
Cc: acpi4asus-user, platform-driver-x86, LKML, Corentin Chary,
João Paulo Rechi Vita, Hans de Goede, Mark Gross
On Sat, 7 Oct 2023, Andy Shevchenko wrote:
> Replace open coded acpi_match_device() in asus_wireless_add().
Could you update this and shortlog too to match the patch (the same
applies also to the other similar patch you've inflight).
--
i.
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> v4: used proper API, added tag (Hans)
> v3: rewrote error path logic (Hans)
> v2: fixed compilation error
>
> drivers/platform/x86/asus-wireless.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index abf01e00b799..41227bf95878 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -148,16 +148,12 @@ static int asus_wireless_add(struct acpi_device *adev)
> if (err)
> return err;
>
> - for (id = device_ids; id->id[0]; id++) {
> - if (!strcmp((char *) id->id, acpi_device_hid(adev))) {
> - data->hswc_params =
> - (const struct hswc_params *)id->driver_data;
> - break;
> - }
> - }
> - if (!data->hswc_params)
> + id = acpi_match_acpi_device(device_ids, adev);
> + if (!id)
> return 0;
>
> + data->hswc_params = (const struct hswc_params *)id->driver_data;
> +
> data->wq = create_singlethread_workqueue("asus_wireless_workqueue");
> if (!data->wq)
> return -ENOMEM;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-09 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-07 8:12 [PATCH v4 1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device() Andy Shevchenko
2023-10-09 11:33 ` Ilpo Järvinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.