From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig
Date: Thu, 14 May 2026 16:04:00 +0100 [thread overview]
Message-ID: <73f69782-2758-495f-8086-e971483133a0@opensource.cirrus.com> (raw)
In-Reply-To: <20260513162758.365972-1-andriy.shevchenko@linux.intel.com>
On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> First of all, it has to be 'default n' (small letter n), otherwise
> it looks for CONFIG_N which is absent and in case of appearance
> will enable something unrelated. Second and most important is that
> 'n' *is* the default 'default' already. Hence just drop malformed
> line.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> sound/hda/codecs/side-codecs/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/hda/codecs/side-codecs/Kconfig b/sound/hda/codecs/side-codecs/Kconfig
> index fc5651e555e3..e51964c0a091 100644
> --- a/sound/hda/codecs/side-codecs/Kconfig
> +++ b/sound/hda/codecs/side-codecs/Kconfig
> @@ -94,7 +94,6 @@ menu "CS35L56 driver options"
>
> config SND_HDA_SCODEC_CS35L56_CAL_DEBUGFS
> bool "CS35L56 create debugfs for factory calibration"
> - default N
> depends on DEBUG_FS
> select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
> help
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
next prev parent reply other threads:[~2026-05-14 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 16:27 [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig Andy Shevchenko
2026-05-13 16:46 ` Richard Fitzgerald
2026-05-13 17:22 ` Andy Shevchenko
2026-05-13 17:24 ` Andy Shevchenko
2026-05-14 15:04 ` Richard Fitzgerald [this message]
2026-05-15 7:26 ` Andy Shevchenko
2026-05-15 7:08 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73f69782-2758-495f-8086-e971483133a0@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.