From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Takashi Iwai <tiwai@suse.de>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig
Date: Wed, 13 May 2026 20:22:19 +0300 [thread overview]
Message-ID: <agSzS1rdEOm_QeLM@ashevche-desk.local> (raw)
In-Reply-To: <48cf7f5c-4135-4111-8222-659c07cd44bd@opensource.cirrus.com>
On Wed, May 13, 2026 at 05:46:03PM +0100, Richard Fitzgerald wrote:
> On 13/05/2026 5:27 pm, Andy Shevchenko wrote:
> > First of all, it has to be 'default n' (small letter n), otherwise
> > it looks for CONFIG_N which is absent and in case of appearance
> > will enable something unrelated. Second and most important is that
> > 'n' *is* the default 'default' already. Hence just drop malformed
> > line.
>
> The redundant default was added intentionally to be explicit that the
> default really must be "no". But if that sort of thing is forbidden you
> can drop the line.
Torvalds gave his opinion on the Subject a few years ago, here is what he would
do.
0192f17529fa ("clean up x86 platform driver default values")
> I apologize for the typo, but that is why you shouldn't use case
> difference as language syntax.
It's not me whom you should ask for that :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-13 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 16:27 [PATCH v1 1/1] ALSA: hda/cs35l56: Drop malformed default N from Kconfig Andy Shevchenko
2026-05-13 16:46 ` Richard Fitzgerald
2026-05-13 17:22 ` Andy Shevchenko [this message]
2026-05-13 17:24 ` Andy Shevchenko
2026-05-14 15:04 ` Richard Fitzgerald
2026-05-15 7:26 ` Andy Shevchenko
2026-05-15 7:08 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agSzS1rdEOm_QeLM@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.