All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, anup@brainfault.org, guoren@kernel.org,
	mick@ics.forth.gr, alexandre.ghiti@canonical.com,
	Xianting Tian <xianting.tian@linux.alibaba.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	crash-utility@redhat.com, huanyi.xj@alibaba-inc.com,
	heinrich.schuchardt@canonical.com, k-hagio-ab@nec.com,
	hschauhan@nulltrace.org,
	Xianting Tian <xianting.tian@linux.alibaba.com>
Subject: Re: [PATCH 4/5] riscv: Add modules to virtual kernel memory layout dump
Date: Fri, 22 Jul 2022 09:24:44 +0200	[thread overview]
Message-ID: <7405851.EvYhyI6sBW@diego> (raw)
In-Reply-To: <20220717101323.370245-5-xianting.tian@linux.alibaba.com>

Am Sonntag, 17. Juli 2022, 12:13:22 CEST schrieb Xianting Tian:
> Modules always live before the kernel, MODULES_END is fixed but
> MODULES_VADDR isn't fixed, it depends on the kernel size.
> Let's add it to virtual kernel memory layout dump.
> 
> As MODULES is only defined for CONFIG_64BIT, so we dump it when
> CONFIG_64BIT=y.
> 
> eg,
> MODULES_VADDR - MODULES_END
> 0xffffffff01133000 - 0xffffffff80000000
> 
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>

I'm still not sure if it would be better to define MODULES_* constants
even on 32bit (with their VMALLOC_START etc values) and prevent
needing the CONFIG_64BIT ifdef, but that's for others to decide :-)

The below also looks good, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  arch/riscv/mm/init.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index d466ec670e1f..2c4a64e97aec 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -135,6 +135,10 @@ static void __init print_vm_layout(void)
>  		(unsigned long)VMEMMAP_END);
>  	print_ml("vmalloc", (unsigned long)VMALLOC_START,
>  		(unsigned long)VMALLOC_END);
> +#ifdef CONFIG_64BIT
> +	print_ml("modules", (unsigned long)MODULES_VADDR,
> +		(unsigned long)MODULES_END);
> +#endif
>  	print_ml("lowmem", (unsigned long)PAGE_OFFSET,
>  		(unsigned long)high_memory);
>  	if (IS_ENABLED(CONFIG_64BIT)) {
> 





_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, anup@brainfault.org, guoren@kernel.org,
	mick@ics.forth.gr, alexandre.ghiti@canonical.com,
	Xianting Tian <xianting.tian@linux.alibaba.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	crash-utility@redhat.com, huanyi.xj@alibaba-inc.com,
	heinrich.schuchardt@canonical.com, k-hagio-ab@nec.com,
	hschauhan@nulltrace.org,
	Xianting Tian <xianting.tian@linux.alibaba.com>
Subject: Re: [PATCH 4/5] riscv: Add modules to virtual kernel memory layout dump
Date: Fri, 22 Jul 2022 09:24:44 +0200	[thread overview]
Message-ID: <7405851.EvYhyI6sBW@diego> (raw)
In-Reply-To: <20220717101323.370245-5-xianting.tian@linux.alibaba.com>

Am Sonntag, 17. Juli 2022, 12:13:22 CEST schrieb Xianting Tian:
> Modules always live before the kernel, MODULES_END is fixed but
> MODULES_VADDR isn't fixed, it depends on the kernel size.
> Let's add it to virtual kernel memory layout dump.
> 
> As MODULES is only defined for CONFIG_64BIT, so we dump it when
> CONFIG_64BIT=y.
> 
> eg,
> MODULES_VADDR - MODULES_END
> 0xffffffff01133000 - 0xffffffff80000000
> 
> Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>

I'm still not sure if it would be better to define MODULES_* constants
even on 32bit (with their VMALLOC_START etc values) and prevent
needing the CONFIG_64BIT ifdef, but that's for others to decide :-)

The below also looks good, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  arch/riscv/mm/init.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index d466ec670e1f..2c4a64e97aec 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -135,6 +135,10 @@ static void __init print_vm_layout(void)
>  		(unsigned long)VMEMMAP_END);
>  	print_ml("vmalloc", (unsigned long)VMALLOC_START,
>  		(unsigned long)VMALLOC_END);
> +#ifdef CONFIG_64BIT
> +	print_ml("modules", (unsigned long)MODULES_VADDR,
> +		(unsigned long)MODULES_END);
> +#endif
>  	print_ml("lowmem", (unsigned long)PAGE_OFFSET,
>  		(unsigned long)high_memory);
>  	if (IS_ENABLED(CONFIG_64BIT)) {
> 





  reply	other threads:[~2022-07-22  7:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-17 10:13 [PATCH 0/5] Fixups to work with crash tool Xianting Tian
2022-07-17 10:13 ` Xianting Tian
2022-07-17 10:13 ` [PATCH 1/5] RISC-V: Fixup fast call of crash_kexec() Xianting Tian
2022-07-17 10:13   ` Xianting Tian
2022-07-17 10:13 ` [PATCH 2/5] RISC-V: use __smp_processor_id() instead of smp_processor_id() Xianting Tian
2022-07-17 10:13   ` Xianting Tian
2022-07-22  7:17   ` Heiko Stübner
2022-07-22  7:17     ` Heiko Stübner
2022-07-22  7:43   ` Atish Patra
2022-07-22  7:43     ` Atish Patra
2022-07-17 10:13 ` [PATCH 3/5] RISC-V: Add arch_crash_save_vmcoreinfo support Xianting Tian
2022-07-17 10:13   ` Xianting Tian
2022-07-17 10:13 ` [PATCH 4/5] riscv: Add modules to virtual kernel memory layout dump Xianting Tian
2022-07-17 10:13   ` Xianting Tian
2022-07-22  7:24   ` Heiko Stübner [this message]
2022-07-22  7:24     ` Heiko Stübner
2022-07-22  7:51     ` Guo Ren
2022-07-22  7:51       ` Guo Ren
2022-07-22 10:10   ` Andreas Schwab
2022-07-22 10:10     ` Andreas Schwab
2022-07-22 12:49     ` tianxianting
2022-07-22 12:49       ` tianxianting
2022-07-17 10:13 ` [PATCH 5/5] RISC-V: Fixup getting correct current pc Xianting Tian
2022-07-17 10:13   ` Xianting Tian
2022-07-22  8:13 ` [Crash-utility] [PATCH 0/5] Fixups to work with crash tool Dave Young
2022-07-22  8:13   ` Dave Young
2022-07-22  8:13   ` Dave Young
2022-07-24  2:38   ` tianxianting
2022-07-24  2:38     ` tianxianting
2022-07-24  2:38     ` tianxianting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7405851.EvYhyI6sBW@diego \
    --to=heiko@sntech.de \
    --cc=alexandre.ghiti@canonical.com \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=crash-utility@redhat.com \
    --cc=guoren@kernel.org \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=hschauhan@nulltrace.org \
    --cc=huanyi.xj@alibaba-inc.com \
    --cc=k-hagio-ab@nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mick@ics.forth.gr \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=xianting.tian@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.