Re: [PATCH v5 3/4] arm64: dts: rockchip: Add magnetometer sensor to Pinephone Pro

From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	guptarud@gmail.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org, Rudraksha Gupta <guptarud@gmail.com>,
	Ondrej Jirman <megi@xff.cz>,
	"Leonardo G. Trombetta" <lgtrombetta@gmx.com>,
	Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v5 3/4] arm64: dts: rockchip: Add magnetometer sensor to Pinephone Pro
Date: Mon, 15 Dec 2025 12:38:17 +0100	[thread overview]
Message-ID: <7420522.MhkbZ0Pkbq@phil> (raw)
In-Reply-To: <20251124-ppp_light_accel_mag_vol-down-v5-3-f9a10a0a50eb@gmail.com>

Am Dienstag, 25. November 2025, 04:47:02 Mitteleuropäische Normalzeit schrieb Rudraksha Gupta via B4 Relay:

>  arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index f8c74b43ae9f..03721d71766c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -553,6 +553,21 @@ mpu6500@68 {
>  	};
>  };
>  
> +&i2c4 {
> +	af8133j: compass@1c {
> +		compatible = "voltafield,af8133j";
> +		reg = <0x1c>;
> +		reset-gpios = <&gpio1 RK_PA1 GPIO_ACTIVE_LOW>;

reset-gpios below dvdd-*

And for completeness sake, you probably want to also add a simple
pinctrl entry

> +		avdd-supply = <&vcc_3v0>;
> +		dvdd-supply = <&vcc_1v8>;
> +
> +		mount-matrix =
> +			"0", "1", "0",
> +			"-1", "0", "0",
> +			"0", "0", "1";
> +	};
> +};
> +

Thanks
Heiko