[PATCH 1/1] spi: fsl-dspi: Fix probe info message

[PATCH 1/1] spi: fsl-dspi: Fix probe info message

[Alexander Stein]

No need to add KERN_INFO to pr_info. Output is:
6Freescale DSPI master initialized

While at it, use dev_info instead for a device specific message.

Signed-off-by: Alexander Stein <alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>
---
 drivers/spi/spi-fsl-dspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 5021ddf..e55144c 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -535,7 +535,7 @@ static int dspi_probe(struct platform_device *pdev)
 		goto out_clk_put;
 	}
 
-	pr_info(KERN_INFO "Freescale DSPI master initialized\n");
+	dev_info(&pdev->dev, "master initialized\n");
 	return ret;
 
 out_clk_put:
-- 
1.8.5.5

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] spi: fsl-dspi: Fix probe info message

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

On Thu, Sep 25, 2014 at 10:53:32AM +0200, Alexander Stein wrote:

> -	pr_info(KERN_INFO "Freescale DSPI master initialized\n");
> +	dev_info(&pdev->dev, "master initialized\n");

This message has no content, it should just be removed entirely.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 1/1] spi: fsl-dspi: Fix probe info message

[Alexander Stein]

On Thursday 25 September 2014 11:14:30, Mark Brown wrote:
> On Thu, Sep 25, 2014 at 10:53:32AM +0200, Alexander Stein wrote:
> 
> > -	pr_info(KERN_INFO "Freescale DSPI master initialized\n");
> > +	dev_info(&pdev->dev, "master initialized\n");
> 
> This message has no content, it should just be removed entirely.

Well, you know that the device has been probed successfully, which IMO is a message the user should be able to see in dmesg.

Best regards,
Alexander
-- 
Dipl.-Inf. Alexander Stein

SYS TEC electronic GmbH
Am Windrad 2
08468 Heinsdorfergrund
Tel.: 03765 38600-1156
Fax: 03765 38600-4100
Email: alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org
Website: www.systec-electronic.com
 
Managing Director: Dipl.-Phys. Siegmar Schmidt
Commercial registry: Amtsgericht Chemnitz, HRB 28082

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] spi: fsl-dspi: Fix probe info message

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

On Thu, Sep 25, 2014 at 12:30:58PM +0200, Alexander Stein wrote:
> On Thursday 25 September 2014 11:14:30, Mark Brown wrote:
> > On Thu, Sep 25, 2014 at 10:53:32AM +0200, Alexander Stein wrote:

> > > -	pr_info(KERN_INFO "Freescale DSPI master initialized\n");
> > > +	dev_info(&pdev->dev, "master initialized\n");

> > This message has no content, it should just be removed entirely.

Fix your mailer to word wrap within paragraphs please.

> Well, you know that the device has been probed successfully, which IMO is a message the user should be able to see in dmesg.

The same thing applies to absolutely every driver in the system; if this
is a useful thing to do we should just make the driver core do it,
though there are then problems with noise during boot and an impact on
boot time when using a serial console.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]