From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 5/5] tests/i915/pm_rc6_residency: Fix linking
Date: Thu, 28 Feb 2019 14:48:55 +0000 [thread overview]
Message-ID: <744b4fc8-7064-8d6b-34e7-99a008732e9e@linux.intel.com> (raw)
In-Reply-To: <155136438087.5847.12673828758236657477@skylake-alporthouse-com>
On 28/02/2019 14:33, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-02-28 14:18:28)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Probably a leftover from test renames:
>>
>> tests/Makefile.am:134: warning: variable 'pm_rc6_residency_LDADD' is defined but no program or
>> tests/Makefile.am:134: library has 'pm_rc6_residency' as canonical name (possible typo)
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>> tests/Makefile.am | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> index c5dd210c7163..80bc5f92a13b 100644
>> --- a/tests/Makefile.am
>> +++ b/tests/Makefile.am
>> @@ -131,7 +131,7 @@ perf_pmu_LDADD = $(LDADD) $(top_builddir)/lib/libigt_perf.la
>> gem_eio_LDADD = $(LDADD) -lrt
>> gem_wait_LDADD = $(LDADD) -lrt
>> kms_flip_LDADD = $(LDADD) -lrt -lpthread
>> -pm_rc6_residency_LDADD = $(LDADD) -lrt
>> +i915_pm_rc6_residency_LDADD = $(LDADD) -lrt
>
> Have we not snuck -lrt into the core library yet, pretty sure libigt.la
> now includes clock_gettime() and so must be pulling it in already?
>
> i.e. can we just drop the above line?
Looks like it. And many more in this case.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 5/5] tests/i915/pm_rc6_residency: Fix linking
Date: Thu, 28 Feb 2019 14:48:55 +0000 [thread overview]
Message-ID: <744b4fc8-7064-8d6b-34e7-99a008732e9e@linux.intel.com> (raw)
In-Reply-To: <155136438087.5847.12673828758236657477@skylake-alporthouse-com>
On 28/02/2019 14:33, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-02-28 14:18:28)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Probably a leftover from test renames:
>>
>> tests/Makefile.am:134: warning: variable 'pm_rc6_residency_LDADD' is defined but no program or
>> tests/Makefile.am:134: library has 'pm_rc6_residency' as canonical name (possible typo)
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>> tests/Makefile.am | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/Makefile.am b/tests/Makefile.am
>> index c5dd210c7163..80bc5f92a13b 100644
>> --- a/tests/Makefile.am
>> +++ b/tests/Makefile.am
>> @@ -131,7 +131,7 @@ perf_pmu_LDADD = $(LDADD) $(top_builddir)/lib/libigt_perf.la
>> gem_eio_LDADD = $(LDADD) -lrt
>> gem_wait_LDADD = $(LDADD) -lrt
>> kms_flip_LDADD = $(LDADD) -lrt -lpthread
>> -pm_rc6_residency_LDADD = $(LDADD) -lrt
>> +i915_pm_rc6_residency_LDADD = $(LDADD) -lrt
>
> Have we not snuck -lrt into the core library yet, pretty sure libigt.la
> now includes clock_gettime() and so must be pulling it in already?
>
> i.e. can we just drop the above line?
Looks like it. And many more in this case.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-02-28 14:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 14:18 [igt-dev] [PATCH i-g-t 1/5] lib/i915: Assert mmap size alignment Tvrtko Ursulin
2019-02-28 14:18 ` Tvrtko Ursulin
2019-02-28 14:18 ` [Intel-gfx] [PATCH i-g-t 2/5] gem_wsim: Round mmap to page size Tvrtko Ursulin
2019-02-28 14:18 ` Tvrtko Ursulin
2019-02-28 14:25 ` [Intel-gfx] " Chris Wilson
2019-02-28 14:25 ` Chris Wilson
2019-02-28 14:41 ` [igt-dev] [Intel-gfx] " Tvrtko Ursulin
2019-02-28 14:41 ` Tvrtko Ursulin
2019-02-28 14:44 ` [igt-dev] [Intel-gfx] " Chris Wilson
2019-02-28 14:44 ` Chris Wilson
2019-02-28 14:18 ` [igt-dev] [PATCH i-g-t 3/5] gem_wsim: Remove some unused struct members Tvrtko Ursulin
2019-02-28 14:18 ` Tvrtko Ursulin
2019-02-28 14:30 ` [igt-dev] " Chris Wilson
2019-02-28 14:30 ` Chris Wilson
2019-02-28 14:18 ` [igt-dev] [PATCH i-g-t 4/5] autoconf: Silence void pointer arithmetic warnings Tvrtko Ursulin
2019-02-28 14:18 ` Tvrtko Ursulin
2019-02-28 14:31 ` [igt-dev] " Chris Wilson
2019-02-28 14:31 ` Chris Wilson
2019-02-28 14:42 ` Tvrtko Ursulin
2019-02-28 14:42 ` Tvrtko Ursulin
2019-02-28 14:18 ` [Intel-gfx] [PATCH i-g-t 5/5] tests/i915/pm_rc6_residency: Fix linking Tvrtko Ursulin
2019-02-28 14:18 ` Tvrtko Ursulin
2019-02-28 14:33 ` [igt-dev] " Chris Wilson
2019-02-28 14:33 ` Chris Wilson
2019-02-28 14:48 ` Tvrtko Ursulin [this message]
2019-02-28 14:48 ` Tvrtko Ursulin
2019-02-28 14:24 ` [igt-dev] [PATCH i-g-t 1/5] lib/i915: Assert mmap size alignment Chris Wilson
2019-02-28 14:24 ` Chris Wilson
2019-02-28 14:38 ` Tvrtko Ursulin
2019-02-28 14:38 ` Tvrtko Ursulin
2019-02-28 15:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/5] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744b4fc8-7064-8d6b-34e7-99a008732e9e@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.