All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Shunsuke Nakamura <nakamura.shun@fujitsu.com>, <will@kernel.org>,
	<mathieu.poirier@linaro.org>, <leo.yan@linaro.org>,
	<peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
	<jolsa@redhat.com>, <namhyung@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name
Date: Thu, 4 Mar 2021 09:34:44 +0000	[thread overview]
Message-ID: <74955041-45ab-10df-e044-5d64898c81d9@huawei.com> (raw)
In-Reply-To: <20210304032610.3112996-3-nakamura.shun@fujitsu.com>

On 04/03/2021 03:26, Shunsuke Nakamura wrote:
> From: Shunsuke Nakamura <nakamura.shun@jp.fujitsu.com>
> 
> Add the lexical definition of event name so that the numbers are recognizable.
> 

Sorry for the hassle, but it's not clear that we got a definitive 
conclusion on this patch from v6 series:

https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/

Would it be so much worse for you to change format of these event names 
to not start with a numberic?

Thanks



> A64FX defines an event name that starts with a number.
>   - 0inst_commit
>   - 1inst_commit
>   - 2inst_commit
>   - 3inst_commit
>   - 4inst_commit
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
> Acked-by: John Garry <john.garry@huawei.com>
> ---
>   tools/perf/util/parse-events.l | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 0b36285a9435..33f627187415 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -205,7 +205,7 @@ bpf_source	[^,{}]+\.c[a-zA-Z0-9._]*
>   num_dec		[0-9]+
>   num_hex		0x[a-fA-F0-9]+
>   num_raw_hex	[a-fA-F0-9]+
> -name		[a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]*
> +name		[a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]*
>   name_tag	[\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\']
>   name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?.:]*
>   drv_cfg_term	[a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)?
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Shunsuke Nakamura <nakamura.shun@fujitsu.com>, <will@kernel.org>,
	<mathieu.poirier@linaro.org>, <leo.yan@linaro.org>,
	<peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
	<jolsa@redhat.com>, <namhyung@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name
Date: Thu, 4 Mar 2021 09:34:44 +0000	[thread overview]
Message-ID: <74955041-45ab-10df-e044-5d64898c81d9@huawei.com> (raw)
In-Reply-To: <20210304032610.3112996-3-nakamura.shun@fujitsu.com>

On 04/03/2021 03:26, Shunsuke Nakamura wrote:
> From: Shunsuke Nakamura <nakamura.shun@jp.fujitsu.com>
> 
> Add the lexical definition of event name so that the numbers are recognizable.
> 

Sorry for the hassle, but it's not clear that we got a definitive 
conclusion on this patch from v6 series:

https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/

Would it be so much worse for you to change format of these event names 
to not start with a numberic?

Thanks



> A64FX defines an event name that starts with a number.
>   - 0inst_commit
>   - 1inst_commit
>   - 2inst_commit
>   - 3inst_commit
>   - 4inst_commit
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
> Acked-by: John Garry <john.garry@huawei.com>
> ---
>   tools/perf/util/parse-events.l | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 0b36285a9435..33f627187415 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -205,7 +205,7 @@ bpf_source	[^,{}]+\.c[a-zA-Z0-9._]*
>   num_dec		[0-9]+
>   num_hex		0x[a-fA-F0-9]+
>   num_raw_hex	[a-fA-F0-9]+
> -name		[a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]*
> +name		[a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]*
>   name_tag	[\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\']
>   name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?.:]*
>   drv_cfg_term	[a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)?
> 


  reply	other threads:[~2021-03-04  9:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04  3:26 [PATCH v7 0/4] perf vendor events: Support PMU events for A64FX Shunsuke Nakamura
2021-03-04  3:26 ` Shunsuke Nakamura
2021-03-04  3:26 ` [PATCH v7 1/4] perf vendor events arm64: Add more common and uarch events Shunsuke Nakamura
2021-03-04  3:26   ` Shunsuke Nakamura
2021-03-04  3:26 ` [PATCH v7 2/4] perf tools: Add lexical definition of event name Shunsuke Nakamura
2021-03-04  3:26   ` Shunsuke Nakamura
2021-03-04  9:34   ` John Garry [this message]
2021-03-04  9:34     ` John Garry
2021-03-05 10:09     ` nakamura.shun
2021-03-05 10:09       ` nakamura.shun
2021-03-06 19:14       ` Jiri Olsa
2021-03-06 19:14         ` Jiri Olsa
2021-03-08  3:19         ` nakamura.shun
2021-03-08  3:19           ` nakamura.shun
2021-03-04  3:26 ` [PATCH v7 3/4] perf vendor events arm64: Add Fujitsu A64FX pmu event Shunsuke Nakamura
2021-03-04  3:26   ` Shunsuke Nakamura
2021-03-04  3:26 ` [PATCH v7 4/4] perf test: Add test for event name starting with a number Shunsuke Nakamura
2021-03-04  3:26   ` Shunsuke Nakamura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74955041-45ab-10df-e044-5d64898c81d9@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=nakamura.shun@fujitsu.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.