From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v5] vfio: Support for no-IOMMU mode
Date: Wed, 27 Jan 2016 18:07:06 +0100 [thread overview]
Message-ID: <7496408.z4nt1qSYiL@xps13> (raw)
In-Reply-To: <1453913438-22991-1-git-send-email-anatoly.burakov@intel.com>
2016-01-27 16:50, Anatoly Burakov:
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +int vfio_type1_dma_map(int);
> +int vfio_noiommu_dma_map(int);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
I agree with checkpatch, they should be static ;)
> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h
> +/* older kernels may not have no-IOMMU mode */
> +#ifndef VFIO_NOIOMMU_IOMMU
> +#define VFIO_NOIOMMU_IOMMU 8
> +#endif
Shouldn't it be defined privately in .c file?
next prev parent reply other threads:[~2016-01-27 17:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 20:16 [PATCH] vfio: Support for no-IOMMU mode Anatoly Burakov
2016-01-13 12:36 ` [PATCH v2] " Anatoly Burakov
2016-01-13 16:45 ` Stephen Hemminger
2016-01-14 9:50 ` Burakov, Anatoly
2016-01-27 9:05 ` Thomas Monjalon
2016-01-27 10:08 ` Burakov, Anatoly
2016-01-27 10:12 ` Thomas Monjalon
2016-01-27 10:24 ` David Marchand
2016-01-27 10:29 ` Burakov, Anatoly
2016-01-27 14:04 ` [PATCH v3] " Anatoly Burakov
2016-01-27 14:23 ` Burakov, Anatoly
2016-01-27 14:32 ` [PATCH v4] " Anatoly Burakov
2016-01-27 15:50 ` Thomas Monjalon
2016-01-27 16:01 ` Burakov, Anatoly
2016-01-27 16:30 ` Burakov, Anatoly
2016-01-27 16:50 ` [PATCH v5] " Anatoly Burakov
2016-01-27 17:07 ` Thomas Monjalon [this message]
2016-01-28 10:03 ` Burakov, Anatoly
2016-01-28 13:27 ` Thomas Monjalon
2016-01-28 11:57 ` [PATCH v6] " Anatoly Burakov
2016-01-28 13:58 ` Thomas Monjalon
2016-01-28 14:16 ` Burakov, Anatoly
2016-01-28 14:40 ` Thomas Monjalon
2016-01-28 15:00 ` Burakov, Anatoly
2016-01-28 16:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7496408.z4nt1qSYiL@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.